From: Joe Perches <joe@perches.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: netdev@vger.kernel.org, Len Brown <lenb@kernel.org>,
Pantelis Antoniou <pantelis.antoniou@gmail.com>,
Vitaly Bordug <vbordug@ru.mvista.com>,
Steve Glendinning <steve.glendinning@shawell.net>,
Mauro Carvalho Chehab <m.chehab@samsung.com>,
Samuel Ortiz <samuel@sortiz.org>,
"David S. Miller" <davem@davemloft.net>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-usb@vger.kernel.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH 2/3] include: Convert ethernet mac address declarations to use ETH_ALEN
Date: Mon, 29 Jul 2013 12:34:24 -0700 [thread overview]
Message-ID: <1375126464.2075.46.camel@joe-AO722> (raw)
In-Reply-To: <2929374.frUlkyTFNL@vostro.rjw.lan>
On Mon, 2013-07-29 at 13:59 +0200, Rafael J. Wysocki wrote:
> On Sunday, July 28, 2013 10:29:04 PM Joe Perches wrote:
> > It's convenient to have ethernet mac addresses use
> > ETH_ALEN to be able to grep for them a bit easier and
> > also to ensure that the addresses are __aligned(2).
[]
> > diff --git a/include/acpi/actbl2.h b/include/acpi/actbl2.h
[]
> > @@ -44,6 +44,8 @@
[]
> > +#include <linux/if_ether.h>
> > +
[]
> > @@ -605,7 +607,7 @@ struct acpi_ibft_nic {
[]
> > - u8 mac_address[6];
> > + u8 mac_address[ETH_ALEN];
> Please don't touch this file.
>
> It comes from a code base outside of the kernel and should be kept in sync with
> the upstream.
Which files in include/acpi have this characteristic?
Perhaps an include/acpi/README is appropriate.
next prev parent reply other threads:[~2013-07-29 19:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-29 5:29 [PATCH 0/3] networking: Use ETH_ALEN where appropriate Joe Perches
2013-07-29 5:29 ` [PATCH 1/3] uapi: Convert some uses of 6 to ETH_ALEN Joe Perches
2013-07-29 5:29 ` [PATCH 2/3] include: Convert ethernet mac address declarations to use ETH_ALEN Joe Perches
2013-07-29 11:59 ` Rafael J. Wysocki
2013-07-29 19:34 ` Joe Perches [this message]
2013-07-29 20:06 ` Rafael J. Wysocki
2013-08-01 17:50 ` Mauro Carvalho Chehab
2013-07-29 5:29 ` [PATCH 3/3] ethernet: Convert mac address uses of 6 to ETH_ALEN Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375126464.2075.46.camel@joe-AO722 \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=m.chehab@samsung.com \
--cc=netdev@vger.kernel.org \
--cc=pantelis.antoniou@gmail.com \
--cc=rjw@sisk.pl \
--cc=samuel@sortiz.org \
--cc=steve.glendinning@shawell.net \
--cc=vbordug@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).