* [PATCH] net/vmw_vsock/af_vsock.c: drop unneeded semicolon [not found] <1375714059-29567-1-git-send-email-Julia.Lawall@lip6.fr> @ 2013-08-05 14:47 ` Julia Lawall 2013-08-05 18:08 ` David Miller 0 siblings, 1 reply; 2+ messages in thread From: Julia Lawall @ 2013-08-05 14:47 UTC (permalink / raw) To: David S. Miller; +Cc: kernel-janitors, netdev, linux-kernel From: Julia Lawall <Julia.Lawall@lip6.fr> Drop the semicolon at the end of the list_for_each_entry loop header. Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> --- Not tested, but I can't imagine how the current code could work, since vsk should end up pointing to a dummy value. net/vmw_vsock/af_vsock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c index 593071d..4d93346 100644 --- a/net/vmw_vsock/af_vsock.c +++ b/net/vmw_vsock/af_vsock.c @@ -347,7 +347,7 @@ void vsock_for_each_connected_socket(void (*fn)(struct sock *sk)) for (i = 0; i < ARRAY_SIZE(vsock_connected_table); i++) { struct vsock_sock *vsk; list_for_each_entry(vsk, &vsock_connected_table[i], - connected_table); + connected_table) fn(sk_vsock(vsk)); } ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net/vmw_vsock/af_vsock.c: drop unneeded semicolon 2013-08-05 14:47 ` [PATCH] net/vmw_vsock/af_vsock.c: drop unneeded semicolon Julia Lawall @ 2013-08-05 18:08 ` David Miller 0 siblings, 0 replies; 2+ messages in thread From: David Miller @ 2013-08-05 18:08 UTC (permalink / raw) To: Julia.Lawall; +Cc: kernel-janitors, netdev, linux-kernel From: Julia Lawall <Julia.Lawall@lip6.fr> Date: Mon, 5 Aug 2013 16:47:38 +0200 > From: Julia Lawall <Julia.Lawall@lip6.fr> > > Drop the semicolon at the end of the list_for_each_entry loop header. > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> > > --- > Not tested, but I can't imagine how the current code could work, since vsk > should end up pointing to a dummy value. This bug has been there since the code was first checked in, and indeed it's going to work on garbage since it's going to pass in the list head transformed into a vsock structure. Applied, thanks Julia. ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-05 18:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1375714059-29567-1-git-send-email-Julia.Lawall@lip6.fr>
2013-08-05 14:47 ` [PATCH] net/vmw_vsock/af_vsock.c: drop unneeded semicolon Julia Lawall
2013-08-05 18:08 ` David Miller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).