From: Ben Hutchings <ben@decadent.org.uk>
To: Venkata Duvvuru <VenkatKumar.Duvvuru@Emulex.Com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH 2/4 ethtool] ethtool: Support for configurable RSS hash key.
Date: Mon, 20 Jan 2014 13:43:18 +0000 [thread overview]
Message-ID: <1390225398.3651.86.camel@deadeye.wl.decadent.org.uk> (raw)
In-Reply-To: <BF3270C86E8B1349A26C34E4EC1C44CB2C84C38B@CMEXMB1.ad.emulex.com>
[-- Attachment #1: Type: text/plain, Size: 1436 bytes --]
On Mon, 2014-01-20 at 13:28 +0000, Venkata Duvvuru wrote:
> Ben, Please ignore my previous reply. My reply options were screwed up in that.
>
> > -----Original Message-----
> > From: Ben Hutchings [mailto:ben@decadent.org.uk]
> > Sent: Monday, January 20, 2014 12:06 AM
> > To: Venkata Duvvuru
> > Cc: netdev@vger.kernel.org
> > Subject: Re: [PATCH 2/4 ethtool] ethtool: Support for configurable RSS hash
> > key.
> >
> > On Fri, 2014-01-17 at 13:02 +0000, Venkata Duvvuru wrote:
> > > This ethtool patch will primarily implement the parser for the options
> > provided by the user for set and get hashkey before invoking the ioctl.
> > > This patch also has Ethtool man page changes which describes the Usage of
> > set and get hashkey options.
> >
> > I'd prefer to have this combined with the -x/-X options (and add new long
> > options to reflect that they cover the key as well).
>
> if we add hashkey options to the existing -x/-X (--show-rxfh-indir/ --set-rxfh-indir), I think it won't be appropriate going by the command name.
> We could change the command name to something like --show-rssconfig /--rss-config but I'm afraid would that be backward compatible?
[...]
That's why I said 'add new long options'. The ethtool argument parser
allows arbitrarily many aliases for each sub-command.
Ben.
--
Ben Hutchings
One of the nice things about standards is that there are so many of them.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2014-01-20 13:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-17 13:02 [PATCH 2/4 ethtool] ethtool: Support for configurable RSS hash key Venkata Duvvuru
2014-01-19 18:35 ` Ben Hutchings
2014-01-20 11:15 ` Venkata Duvvuru
2014-01-20 13:28 ` Venkata Duvvuru
2014-01-20 13:43 ` Ben Hutchings [this message]
2014-01-22 12:06 ` Venkata Duvvuru
2014-01-23 5:42 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1390225398.3651.86.camel@deadeye.wl.decadent.org.uk \
--to=ben@decadent.org.uk \
--cc=VenkatKumar.Duvvuru@Emulex.Com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).