RE: [PATCH 2/4 ethtool] ethtool: Support for configurable RSS hash key.

[Venkata Duvvuru <VenkatKumar.Duvvuru@Emulex.Com>]

> -----Original Message-----
> From: Ben Hutchings [mailto:ben@decadent.org.uk]
> Sent: Monday, January 20, 2014 7:13 PM
> To: Venkata Duvvuru
> Cc: netdev@vger.kernel.org
> Subject: Re: [PATCH 2/4 ethtool] ethtool: Support for configurable RSS hash
> key.
> 
> On Mon, 2014-01-20 at 13:28 +0000, Venkata Duvvuru wrote:
> > Ben, Please ignore my previous reply. My reply options were screwed up in
> that.
> >
> > > -----Original Message-----
> > > From: Ben Hutchings [mailto:ben@decadent.org.uk]
> > > Sent: Monday, January 20, 2014 12:06 AM
> > > To: Venkata Duvvuru
> > > Cc: netdev@vger.kernel.org
> > > Subject: Re: [PATCH 2/4 ethtool] ethtool: Support for configurable
> > > RSS hash key.
> > >
> > > On Fri, 2014-01-17 at 13:02 +0000, Venkata Duvvuru wrote:
> > > > This ethtool patch will primarily implement the parser for the
> > > > options
> > > provided by the user for set and get hashkey before invoking the ioctl.
> > > > This patch also has Ethtool man page changes which describes the
> > > > Usage of
> > > set and get hashkey options.
> > >
> > > I'd prefer to have this combined with the -x/-X options (and add new
> > > long options to reflect that they cover the key as well).
> >
> > if we add hashkey options to the existing -x/-X (--show-rxfh-indir/ --set-
> rxfh-indir), I think it won't be appropriate going by the command name.
> > We could change the command name to something like --show-rssconfig /-
> -rss-config but I'm afraid would that be backward compatible?
> [...]
> 
> That's why I said 'add new long options'.  The ethtool argument parser allows
> arbitrarily many aliases for each sub-command.

Just to make sure that we are in sync
        { "-x|--show-rxfh-indir|--show-hashkey", 1, do_getrssconfig,
          "Show RSS configuration" },

        { "-X|--set-rxfh-indir|--hashkey", 1, do_setrssconfig,
          "Set RSS configuration",
          "             equal N | weight W0 W1 ...\n"
          "             hkey %x:%x:%x:%x:%x:....:%x\n" },

And equal/weight will be mutually exclusive with hkey.
Does it makes sense?
> 
> Ben.
> 
> --
> Ben Hutchings
> One of the nice things about standards is that there are so many of them.