* [PATCH] net/mac80211: Use RCU_INIT_POINTER(x, NULL) in util.c
@ 2014-03-23 19:21 Monam Agarwal
2014-03-28 8:36 ` Johannes Berg
0 siblings, 1 reply; 2+ messages in thread
From: Monam Agarwal @ 2014-03-23 19:21 UTC (permalink / raw)
To: linville, johannes, davem, linux-wireless, netdev, linux-kernel
This patch replaces rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL)
The rcu_assign_pointer() ensures that the initialization of a structure
is carried out before storing a pointer to that structure.
And in the case of the NULL pointer, there is no structure to initialize.
So, rcu_assign_pointer(p, NULL) can be safely converted to RCU_INIT_POINTER(p, NULL)
Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
---
net/mac80211/util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/mac80211/util.c b/net/mac80211/util.c
index 275c94f..7601657 100644
--- a/net/mac80211/util.c
+++ b/net/mac80211/util.c
@@ -1546,7 +1546,7 @@ int ieee80211_reconfig(struct ieee80211_local *local)
WARN_ON(local->resuming);
res = drv_add_interface(local, sdata);
if (WARN_ON(res)) {
- rcu_assign_pointer(local->monitor_sdata, NULL);
+ RCU_INIT_POINTER(local->monitor_sdata, NULL);
synchronize_net();
kfree(sdata);
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net/mac80211: Use RCU_INIT_POINTER(x, NULL) in util.c
2014-03-23 19:21 [PATCH] net/mac80211: Use RCU_INIT_POINTER(x, NULL) in util.c Monam Agarwal
@ 2014-03-28 8:36 ` Johannes Berg
0 siblings, 0 replies; 2+ messages in thread
From: Johannes Berg @ 2014-03-28 8:36 UTC (permalink / raw)
To: Monam Agarwal; +Cc: linville, davem, linux-wireless, netdev, linux-kernel
Applied, but I rewrote the commit log and squashed the mac80211 patches
into one.
johannes
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-03-28 8:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-03-23 19:21 [PATCH] net/mac80211: Use RCU_INIT_POINTER(x, NULL) in util.c Monam Agarwal
2014-03-28 8:36 ` Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).