* [patch net] team: forbid incorrect fall-through in notifier
@ 2014-04-23 12:17 Jiri Pirko
2014-04-24 17:26 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Jiri Pirko @ 2014-04-23 12:17 UTC (permalink / raw)
To: netdev; +Cc: davem, fbl
There are two breaks missing there. The result is that userspace
receives multiple messages which might be confusing.
Introduced-by: 3d249d4c "net: introduce ethernet teaming device"
Signed-off-by: Jiri Pirko <jiri@resnulli.us>
---
drivers/net/team/team.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c
index 33008c1..767fe61 100644
--- a/drivers/net/team/team.c
+++ b/drivers/net/team/team.c
@@ -2834,8 +2834,10 @@ static int team_device_event(struct notifier_block *unused,
case NETDEV_UP:
if (netif_carrier_ok(dev))
team_port_change_check(port, true);
+ break;
case NETDEV_DOWN:
team_port_change_check(port, false);
+ break;
case NETDEV_CHANGE:
if (netif_running(port->dev))
team_port_change_check(port,
--
1.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch net] team: forbid incorrect fall-through in notifier
2014-04-23 12:17 [patch net] team: forbid incorrect fall-through in notifier Jiri Pirko
@ 2014-04-24 17:26 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-04-24 17:26 UTC (permalink / raw)
To: jiri; +Cc: netdev, fbl
From: Jiri Pirko <jiri@resnulli.us>
Date: Wed, 23 Apr 2014 14:17:55 +0200
> There are two breaks missing there. The result is that userspace
> receives multiple messages which might be confusing.
>
> Introduced-by: 3d249d4c "net: introduce ethernet teaming device"
> Signed-off-by: Jiri Pirko <jiri@resnulli.us>
Applied, thanks Jiri.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-24 17:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-23 12:17 [patch net] team: forbid incorrect fall-through in notifier Jiri Pirko
2014-04-24 17:26 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).