* [PATCH 1/3] net: vxge: Use time_is_before_jiffies() for time comparison
@ 2014-05-19 16:47 Manuel Schölling
2014-05-19 16:51 ` (unknown), Manuel Schölling
2014-05-19 16:53 ` [PATCH 1/3] net: vxge: Use time_is_before_jiffies() for time comparison Manuel Schoelling
0 siblings, 2 replies; 8+ messages in thread
From: Manuel Schölling @ 2014-05-19 16:47 UTC (permalink / raw)
To: davem; +Cc: netdev, linux-kernel, kernel-janitors, Manuel Schölling
To be future-proof and for better readability the time comparisons are modified
to use time_is_before_jiffies() instead of plain, error-prone math.
Signed-off-by: Manuel Schölling <manuel.schoelling@gmx.de>
---
drivers/net/ethernet/neterion/vxge/vxge-main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/neterion/vxge/vxge-main.c b/drivers/net/ethernet/neterion/vxge/vxge-main.c
index d107bcb..79f42db 100644
--- a/drivers/net/ethernet/neterion/vxge/vxge-main.c
+++ b/drivers/net/ethernet/neterion/vxge/vxge-main.c
@@ -2122,7 +2122,7 @@ static int vxge_open_vpaths(struct vxgedev *vdev)
static void adaptive_coalesce_tx_interrupts(struct vxge_fifo *fifo)
{
fifo->interrupt_count++;
- if (jiffies > fifo->jiffies + HZ / 100) {
+ if (time_is_before_jiffies(fifo->jiffies + HZ / 100)) {
struct __vxge_hw_fifo *hw_fifo = fifo->handle;
fifo->jiffies = jiffies;
@@ -2150,7 +2150,7 @@ static void adaptive_coalesce_tx_interrupts(struct vxge_fifo *fifo)
static void adaptive_coalesce_rx_interrupts(struct vxge_ring *ring)
{
ring->interrupt_count++;
- if (jiffies > ring->jiffies + HZ / 100) {
+ if (time_is_before_jiffies(ring->jiffies + HZ / 100)) {
struct __vxge_hw_ring *hw_ring = ring->handle;
ring->jiffies = jiffies;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* (unknown),
2014-05-19 16:47 [PATCH 1/3] net: vxge: Use time_is_before_jiffies() for time comparison Manuel Schölling
@ 2014-05-19 16:51 ` Manuel Schölling
2014-05-19 16:51 ` [PATCH] net: vxge: Use time_is_before_jiffies() for time comparison Manuel Schölling
2014-05-19 16:53 ` [PATCH 1/3] net: vxge: Use time_is_before_jiffies() for time comparison Manuel Schoelling
1 sibling, 1 reply; 8+ messages in thread
From: Manuel Schölling @ 2014-05-19 16:51 UTC (permalink / raw)
To: davem; +Cc: netdev, linux-kernel, kernel-janitors
Sorry, contrary to the subject of the previous email, this is a single file patch.
Patches 2-3 do not exist
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] net: vxge: Use time_is_before_jiffies() for time comparison
2014-05-19 16:51 ` (unknown), Manuel Schölling
@ 2014-05-19 16:51 ` Manuel Schölling
2014-05-19 17:35 ` Joe Perches
0 siblings, 1 reply; 8+ messages in thread
From: Manuel Schölling @ 2014-05-19 16:51 UTC (permalink / raw)
To: davem; +Cc: netdev, linux-kernel, kernel-janitors, Manuel Schölling
To be future-proof and for better readability the time comparisons are modified
to use time_is_before_jiffies() instead of plain, error-prone math.
Signed-off-by: Manuel Schölling <manuel.schoelling@gmx.de>
---
drivers/net/ethernet/neterion/vxge/vxge-main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/neterion/vxge/vxge-main.c b/drivers/net/ethernet/neterion/vxge/vxge-main.c
index d107bcb..79f42db 100644
--- a/drivers/net/ethernet/neterion/vxge/vxge-main.c
+++ b/drivers/net/ethernet/neterion/vxge/vxge-main.c
@@ -2122,7 +2122,7 @@ static int vxge_open_vpaths(struct vxgedev *vdev)
static void adaptive_coalesce_tx_interrupts(struct vxge_fifo *fifo)
{
fifo->interrupt_count++;
- if (jiffies > fifo->jiffies + HZ / 100) {
+ if (time_is_before_jiffies(fifo->jiffies + HZ / 100)) {
struct __vxge_hw_fifo *hw_fifo = fifo->handle;
fifo->jiffies = jiffies;
@@ -2150,7 +2150,7 @@ static void adaptive_coalesce_tx_interrupts(struct vxge_fifo *fifo)
static void adaptive_coalesce_rx_interrupts(struct vxge_ring *ring)
{
ring->interrupt_count++;
- if (jiffies > ring->jiffies + HZ / 100) {
+ if (time_is_before_jiffies(ring->jiffies + HZ / 100)) {
struct __vxge_hw_ring *hw_ring = ring->handle;
ring->jiffies = jiffies;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/3] net: vxge: Use time_is_before_jiffies() for time comparison
2014-05-19 16:47 [PATCH 1/3] net: vxge: Use time_is_before_jiffies() for time comparison Manuel Schölling
2014-05-19 16:51 ` (unknown), Manuel Schölling
@ 2014-05-19 16:53 ` Manuel Schoelling
1 sibling, 0 replies; 8+ messages in thread
From: Manuel Schoelling @ 2014-05-19 16:53 UTC (permalink / raw)
To: davem; +Cc: netdev, linux-kernel, kernel-janitors
Sorry, contrary to the subject of this mail, this is a single file
patch.
Patches 2-3 do not exist.
On Mo, 2014-05-19 at 18:47 +0200, Manuel Schölling wrote:
> To be future-proof and for better readability the time comparisons are modified
> to use time_is_before_jiffies() instead of plain, error-prone math.
>
> Signed-off-by: Manuel Schölling <manuel.schoelling@gmx.de>
> ---
> drivers/net/ethernet/neterion/vxge/vxge-main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/neterion/vxge/vxge-main.c b/drivers/net/ethernet/neterion/vxge/vxge-main.c
> index d107bcb..79f42db 100644
> --- a/drivers/net/ethernet/neterion/vxge/vxge-main.c
> +++ b/drivers/net/ethernet/neterion/vxge/vxge-main.c
> @@ -2122,7 +2122,7 @@ static int vxge_open_vpaths(struct vxgedev *vdev)
> static void adaptive_coalesce_tx_interrupts(struct vxge_fifo *fifo)
> {
> fifo->interrupt_count++;
> - if (jiffies > fifo->jiffies + HZ / 100) {
> + if (time_is_before_jiffies(fifo->jiffies + HZ / 100)) {
> struct __vxge_hw_fifo *hw_fifo = fifo->handle;
>
> fifo->jiffies = jiffies;
> @@ -2150,7 +2150,7 @@ static void adaptive_coalesce_tx_interrupts(struct vxge_fifo *fifo)
> static void adaptive_coalesce_rx_interrupts(struct vxge_ring *ring)
> {
> ring->interrupt_count++;
> - if (jiffies > ring->jiffies + HZ / 100) {
> + if (time_is_before_jiffies(ring->jiffies + HZ / 100)) {
> struct __vxge_hw_ring *hw_ring = ring->handle;
>
> ring->jiffies = jiffies;
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] net: vxge: Use time_is_before_jiffies() for time comparison
2014-05-19 16:51 ` [PATCH] net: vxge: Use time_is_before_jiffies() for time comparison Manuel Schölling
@ 2014-05-19 17:35 ` Joe Perches
2014-05-19 20:56 ` [PATCH v3] vxge: Use time_before() Manuel Schölling
2014-05-19 20:59 ` [PATCH] " Manuel Schölling
0 siblings, 2 replies; 8+ messages in thread
From: Joe Perches @ 2014-05-19 17:35 UTC (permalink / raw)
To: Manuel Schölling; +Cc: davem, netdev, linux-kernel, kernel-janitors
On Mon, 2014-05-19 at 18:51 +0200, Manuel Schölling wrote:
> To be future-proof and for better readability the time comparisons are modified
> to use time_is_before_jiffies() instead of plain, error-prone math.
Hi again Manuel.
Just a couple of FYIs/nits:
The "net: " prefix in your patch subject is a little
misleading. One reading might be that the patch is
to the net/ subsystem but it's for a driver.
It might be better as:
[PATCH] vxge: Use time_is_before_jiffies
Generally, just use the last directory name
for the subject prefix.
ie: patching: foo/bar/baz/qux.c
subject prefix is generally:
[PATCH] baz: whatever changed...
and a single patch to a number of different files
in foo/bar/baz/*.[ch] is still
[PATCH] baz: etc...
Also, the time_is_(before|after)_jiffies variants
are not used particularly often in the kernel.
The form using of time_<foo>(jiffies, ...)
is used _far_ more often (and it saves a little
typing too).
time_before(<foo>, jiffies)
time_is_before_jiffies(<foo>)
$ git grep -E -w "time_is_(before|after|before_eq|after_eq)_jiffies" | wc -l
93
$ git grep -E "\btime_(before|after|before_eq|after_eq)+\s*\(.*jiffies" | wc -l
1695
<shrug> Maybe there's some reading clarity using
the time_is_(before|after)_jiffies variants.
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v3] vxge: Use time_before()
2014-05-19 17:35 ` Joe Perches
@ 2014-05-19 20:56 ` Manuel Schölling
2014-05-19 20:59 ` [PATCH] " Manuel Schölling
1 sibling, 0 replies; 8+ messages in thread
From: Manuel Schölling @ 2014-05-19 20:56 UTC (permalink / raw)
To: jdmason; +Cc: netdev, linux-kernel, kernel-janitors, joe
Thanks for your hints. I tried to incorporate your points into this new version.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] vxge: Use time_before()
2014-05-19 17:35 ` Joe Perches
2014-05-19 20:56 ` [PATCH v3] vxge: Use time_before() Manuel Schölling
@ 2014-05-19 20:59 ` Manuel Schölling
2014-05-21 20:43 ` David Miller
1 sibling, 1 reply; 8+ messages in thread
From: Manuel Schölling @ 2014-05-19 20:59 UTC (permalink / raw)
To: jdmason; +Cc: netdev, linux-kernel, kernel-janitors, joe, Manuel Schölling
To be future-proof and for better readability the time comparisons are modified
to use time_before() instead of plain, error-prone math.
Signed-off-by: Manuel Schölling <manuel.schoelling@gmx.de>
---
drivers/net/ethernet/neterion/vxge/vxge-main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/neterion/vxge/vxge-main.c b/drivers/net/ethernet/neterion/vxge/vxge-main.c
index d107bcb..7a0dead 100644
--- a/drivers/net/ethernet/neterion/vxge/vxge-main.c
+++ b/drivers/net/ethernet/neterion/vxge/vxge-main.c
@@ -2122,7 +2122,7 @@ static int vxge_open_vpaths(struct vxgedev *vdev)
static void adaptive_coalesce_tx_interrupts(struct vxge_fifo *fifo)
{
fifo->interrupt_count++;
- if (jiffies > fifo->jiffies + HZ / 100) {
+ if (time_before(fifo->jiffies + HZ / 100, jiffies)) {
struct __vxge_hw_fifo *hw_fifo = fifo->handle;
fifo->jiffies = jiffies;
@@ -2150,7 +2150,7 @@ static void adaptive_coalesce_tx_interrupts(struct vxge_fifo *fifo)
static void adaptive_coalesce_rx_interrupts(struct vxge_ring *ring)
{
ring->interrupt_count++;
- if (jiffies > ring->jiffies + HZ / 100) {
+ if (time_before(ring->jiffies + HZ / 100, jiffies)) {
struct __vxge_hw_ring *hw_ring = ring->handle;
ring->jiffies = jiffies;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] vxge: Use time_before()
2014-05-19 20:59 ` [PATCH] " Manuel Schölling
@ 2014-05-21 20:43 ` David Miller
0 siblings, 0 replies; 8+ messages in thread
From: David Miller @ 2014-05-21 20:43 UTC (permalink / raw)
To: manuel.schoelling; +Cc: jdmason, netdev, linux-kernel, kernel-janitors, joe
From: Manuel Schölling <manuel.schoelling@gmx.de>
Date: Mon, 19 May 2014 22:59:04 +0200
> To be future-proof and for better readability the time comparisons are modified
> to use time_before() instead of plain, error-prone math.
>
> Signed-off-by: Manuel Schölling <manuel.schoelling@gmx.de>
Applied, thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-05-21 20:43 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-19 16:47 [PATCH 1/3] net: vxge: Use time_is_before_jiffies() for time comparison Manuel Schölling
2014-05-19 16:51 ` (unknown), Manuel Schölling
2014-05-19 16:51 ` [PATCH] net: vxge: Use time_is_before_jiffies() for time comparison Manuel Schölling
2014-05-19 17:35 ` Joe Perches
2014-05-19 20:56 ` [PATCH v3] vxge: Use time_before() Manuel Schölling
2014-05-19 20:59 ` [PATCH] " Manuel Schölling
2014-05-21 20:43 ` David Miller
2014-05-19 16:53 ` [PATCH 1/3] net: vxge: Use time_is_before_jiffies() for time comparison Manuel Schoelling
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).