netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] [TRIVIAL] atm: remove commented out check
@ 2014-05-27 15:07 Paul Bolle
  2014-05-31  0:17 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Paul Bolle @ 2014-05-27 15:07 UTC (permalink / raw)
  To: Jiri Kosina; +Cc: netdev, linux-kernel

This preprocessor check is commented out ever since this file was added
during the v2.3 development cycle. It is unclear what it purpose might
have been. Whatever it was, it can safely be removed now.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
Compile tested.

Perhaps someone on netdev knows what CONFIG_SINGLE_SIGITF might have
been for. Not that it actually matters.

 net/atm/svc.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/net/atm/svc.c b/net/atm/svc.c
index 1281049c135f..d8e5d0c2ebbc 100644
--- a/net/atm/svc.c
+++ b/net/atm/svc.c
@@ -263,17 +263,11 @@ static int svc_connect(struct socket *sock, struct sockaddr *sockaddr,
 			goto out;
 		}
 	}
-/*
- * Not supported yet
- *
- * #ifndef CONFIG_SINGLE_SIGITF
- */
+
 	vcc->qos.txtp.max_pcr = SELECT_TOP_PCR(vcc->qos.txtp);
 	vcc->qos.txtp.pcr = 0;
 	vcc->qos.txtp.min_pcr = 0;
-/*
- * #endif
- */
+
 	error = vcc_connect(sock, vcc->itf, vcc->vpi, vcc->vci);
 	if (!error)
 		sock->state = SS_CONNECTED;
-- 
1.9.3

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] [TRIVIAL] atm: remove commented out check
  2014-05-27 15:07 [PATCH] [TRIVIAL] atm: remove commented out check Paul Bolle
@ 2014-05-31  0:17 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-05-31  0:17 UTC (permalink / raw)
  To: pebolle; +Cc: trivial, netdev, linux-kernel

From: Paul Bolle <pebolle@tiscali.nl>
Date: Tue, 27 May 2014 17:07:12 +0200

> This preprocessor check is commented out ever since this file was added
> during the v2.3 development cycle. It is unclear what it purpose might
> have been. Whatever it was, it can safely be removed now.
> 
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> Compile tested.
> 
> Perhaps someone on netdev knows what CONFIG_SINGLE_SIGITF might have
> been for. Not that it actually matters.

Yeah it can't actually matter, applied to net-next, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-05-31  0:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-27 15:07 [PATCH] [TRIVIAL] atm: remove commented out check Paul Bolle
2014-05-31  0:17 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).