From: Michal Schmidt <mschmidt@redhat.com>
To: netdev@vger.kernel.org
Cc: Nicolas Dichtel <nicolas.dichtel@6wind.com>,
David Miller <davem@davemloft.net>
Subject: [PATCH] netlink: rate-limit leftover bytes warning and print process name
Date: Fri, 30 May 2014 14:57:27 +0200 [thread overview]
Message-ID: <1401454647-28228-1-git-send-email-mschmidt@redhat.com> (raw)
In-Reply-To: <5385DAE5.2020009@6wind.com>
Any process is able to send netlink messages with leftover bytes.
Make the warning rate-limited to prevent too much log spam.
The warning is supposed to help find userspace bugs, so print the
triggering command name to implicate the buggy program.
Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
---
lib/nlattr.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lib/nlattr.c b/lib/nlattr.c
index fc67547..31047c4 100644
--- a/lib/nlattr.c
+++ b/lib/nlattr.c
@@ -201,8 +201,9 @@ int nla_parse(struct nlattr **tb, int maxtype, const struct nlattr *head,
}
if (unlikely(rem > 0))
- printk(KERN_WARNING "netlink: %d bytes leftover after parsing "
- "attributes.\n", rem);
+ printk_ratelimited(KERN_WARNING
+ "netlink: %d bytes leftover after parsing attributes in process `%s'.\n",
+ rem, current->comm);
err = 0;
errout:
--
1.9.3
next prev parent reply other threads:[~2014-05-30 12:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-27 13:16 [PATCH] netlink: downgrade warning about leftover bytes to debug level Michal Schmidt
2014-05-28 7:42 ` Nicolas Dichtel
2014-05-28 9:18 ` Michal Schmidt
2014-05-28 12:47 ` Nicolas Dichtel
2014-05-30 12:57 ` Michal Schmidt [this message]
2014-05-30 14:26 ` [PATCH] netlink: rate-limit leftover bytes warning and print process name Sergei Shtylyov
2014-06-02 16:25 ` [PATCH v2] " Michal Schmidt
2014-06-02 18:16 ` David Miller
2014-05-31 0:16 ` [PATCH] " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401454647-28228-1-git-send-email-mschmidt@redhat.com \
--to=mschmidt@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).