From: Michal Schmidt <mschmidt@redhat.com>
To: nicolas.dichtel@6wind.com, David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] netlink: downgrade warning about leftover bytes to debug level
Date: Wed, 28 May 2014 11:18:09 +0200 [thread overview]
Message-ID: <5385A9D1.4000102@redhat.com> (raw)
In-Reply-To: <53859359.70304@6wind.com>
On 05/28/2014 09:42 AM, Nicolas Dichtel wrote:
> Le 27/05/2014 15:16, Michal Schmidt a écrit :
>> Any process is able to send netlink messages with leftover bytes, so
>> downgrade the warning message to pr_debug in order to avoid possible
>> kernel log spam.
> Yes, but that's not a normal case. I think that the level warning is good,
> there is something wrong with this kind of messages.
As an alternative we could at least guard it with net_ratelimit().
But still, the message indicates a userspace bug. It can be useful
for a developer of a netlink library, but not for many more.
I think it's odd to let unprivileged userspace spam the dmesg,
even if rate-limited. The kernel does not emit warning messages when
userspace is buggy in other ways, like calling syscalls with invalid
arguments.
Regards,
Michal
next prev parent reply other threads:[~2014-05-28 9:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-27 13:16 [PATCH] netlink: downgrade warning about leftover bytes to debug level Michal Schmidt
2014-05-28 7:42 ` Nicolas Dichtel
2014-05-28 9:18 ` Michal Schmidt [this message]
2014-05-28 12:47 ` Nicolas Dichtel
2014-05-30 12:57 ` [PATCH] netlink: rate-limit leftover bytes warning and print process name Michal Schmidt
2014-05-30 14:26 ` Sergei Shtylyov
2014-06-02 16:25 ` [PATCH v2] " Michal Schmidt
2014-06-02 18:16 ` David Miller
2014-05-31 0:16 ` [PATCH] " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5385A9D1.4000102@redhat.com \
--to=mschmidt@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).