* [PATCH v2] net: wireless: rtlwifi: rtl8188ee: reg.h: Cleaning up if statement that always evaluates to false
@ 2014-06-14 13:27 Rickard Strandqvist
2014-06-14 13:27 ` Rickard Strandqvist
0 siblings, 1 reply; 2+ messages in thread
From: Rickard Strandqvist @ 2014-06-14 13:27 UTC (permalink / raw)
To: Larry Finger, Chaoming Li
Cc: Rickard Strandqvist, John W. Linville, linux-wireless, netdev,
linux-kernel
I found a logical error in an if statement that always evaluates to false.
This has after same discussion resulted in that we add a macro to handle this.
This was partly found using a static code analysis program called cppcheck.
Rickard Strandqvist (1):
net: wireless: rtlwifi: rtl8188ee: reg.h: Cleaning up if statement that always evaluates to false
drivers/net/wireless/rtlwifi/rtl8188ee/reg.h | 1 +
1 file changed, 1 insertion(+)
--
1.7.10.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH v2] net: wireless: rtlwifi: rtl8188ee: reg.h: Cleaning up if statement that always evaluates to false
2014-06-14 13:27 [PATCH v2] net: wireless: rtlwifi: rtl8188ee: reg.h: Cleaning up if statement that always evaluates to false Rickard Strandqvist
@ 2014-06-14 13:27 ` Rickard Strandqvist
0 siblings, 0 replies; 2+ messages in thread
From: Rickard Strandqvist @ 2014-06-14 13:27 UTC (permalink / raw)
To: Larry Finger, Chaoming Li
Cc: Rickard Strandqvist, John W. Linville, linux-wireless, netdev,
linux-kernel
I found a logical error in an if statement that always evaluates to false.
This has after same discussion resulted in that we add a macro to handle this.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/net/wireless/rtlwifi/rtl8188ee/reg.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/rtlwifi/rtl8188ee/reg.h b/drivers/net/wireless/rtlwifi/rtl8188ee/reg.h
index 7af85cf..cd7e7a5 100644
--- a/drivers/net/wireless/rtlwifi/rtl8188ee/reg.h
+++ b/drivers/net/wireless/rtlwifi/rtl8188ee/reg.h
@@ -411,6 +411,7 @@
#define MSR_ADHOC 0x01
#define MSR_INFRA 0x02
#define MSR_AP 0x03
+#define MSR_MASK 0x03
#define RRSR_RSC_OFFSET 21
#define RRSR_SHORT_OFFSET 23
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-14 13:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-14 13:27 [PATCH v2] net: wireless: rtlwifi: rtl8188ee: reg.h: Cleaning up if statement that always evaluates to false Rickard Strandqvist
2014-06-14 13:27 ` Rickard Strandqvist
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).