* [PATCH 20/30] igb: remove unnecessary break after return
@ 2014-07-20 14:27 Fabian Frederick
2014-07-20 14:27 ` [PATCH 21/30] 8390: " Fabian Frederick
` (8 more replies)
0 siblings, 9 replies; 11+ messages in thread
From: Fabian Frederick @ 2014-07-20 14:27 UTC (permalink / raw)
To: linux-kernel
Cc: Linux NICS, e1000-devel, Bruce Allan, Jesse Brandeburg,
Fabian Frederick, John Ronciak, netdev, joe, davem
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
drivers/net/ethernet/intel/igb/e1000_82575.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/igb/e1000_82575.c b/drivers/net/ethernet/intel/igb/e1000_82575.c
index ee74f95..807496e 100644
--- a/drivers/net/ethernet/intel/igb/e1000_82575.c
+++ b/drivers/net/ethernet/intel/igb/e1000_82575.c
@@ -579,7 +579,6 @@ static s32 igb_get_invariants_82575(struct e1000_hw *hw)
break;
default:
return -E1000_ERR_MAC_INIT;
- break;
}
/* Set media type */
--
1.9.1
------------------------------------------------------------------------------
Want fast and easy access to all the code in your enterprise? Index and
search up to 200,000 lines of code with a free copy of Black Duck
Code Sight - the same software that powers the world's largest code
search on Ohloh, the Black Duck Open Hub! Try it now.
http://p.sf.net/sfu/bds
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 21/30] 8390: remove unnecessary break after return
2014-07-20 14:27 [PATCH 20/30] igb: remove unnecessary break after return Fabian Frederick
@ 2014-07-20 14:27 ` Fabian Frederick
2014-07-20 14:27 ` [PATCH 22/30] net: tulip: " Fabian Frederick
` (7 subsequent siblings)
8 siblings, 0 replies; 11+ messages in thread
From: Fabian Frederick @ 2014-07-20 14:27 UTC (permalink / raw)
To: linux-kernel; +Cc: davem, joe, Fabian Frederick, netdev
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
drivers/net/ethernet/8390/mac8390.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/net/ethernet/8390/mac8390.c b/drivers/net/ethernet/8390/mac8390.c
index 90e825e..65cf60f 100644
--- a/drivers/net/ethernet/8390/mac8390.c
+++ b/drivers/net/ethernet/8390/mac8390.c
@@ -178,10 +178,8 @@ static enum mac8390_type __init mac8390_ident(struct nubus_dev *dev)
case NUBUS_DRHW_APPLE_SONIC_LC:
case NUBUS_DRHW_SONNET:
return MAC8390_NONE;
- break;
default:
return MAC8390_APPLE;
- break;
}
break;
@@ -189,13 +187,10 @@ static enum mac8390_type __init mac8390_ident(struct nubus_dev *dev)
switch (dev->dr_hw) {
case NUBUS_DRHW_ASANTE_LC:
return MAC8390_NONE;
- break;
case NUBUS_DRHW_CABLETRON:
return MAC8390_CABLETRON;
- break;
default:
return MAC8390_APPLE;
- break;
}
break;
@@ -220,10 +215,8 @@ static enum mac8390_type __init mac8390_ident(struct nubus_dev *dev)
switch (dev->dr_hw) {
case NUBUS_DRHW_INTERLAN:
return MAC8390_INTERLAN;
- break;
default:
return MAC8390_KINETICS;
- break;
}
break;
@@ -563,7 +556,6 @@ static int __init mac8390_initdev(struct net_device *dev,
case ACCESS_UNKNOWN:
pr_err("Don't know how to access card memory!\n");
return -ENODEV;
- break;
case ACCESS_16:
/* 16 bit card, register map is reversed */
--
1.9.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 22/30] net: tulip: remove unnecessary break after return
2014-07-20 14:27 [PATCH 20/30] igb: remove unnecessary break after return Fabian Frederick
2014-07-20 14:27 ` [PATCH 21/30] 8390: " Fabian Frederick
@ 2014-07-20 14:27 ` Fabian Frederick
2014-07-20 14:27 ` [PATCH 23/30] bna: " Fabian Frederick
` (6 subsequent siblings)
8 siblings, 0 replies; 11+ messages in thread
From: Fabian Frederick @ 2014-07-20 14:27 UTC (permalink / raw)
To: linux-kernel; +Cc: davem, joe, Fabian Frederick, Grant Grundler, netdev
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
drivers/net/ethernet/dec/tulip/de4x5.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/dec/tulip/de4x5.c b/drivers/net/ethernet/dec/tulip/de4x5.c
index c05b66d..7091fa6 100644
--- a/drivers/net/ethernet/dec/tulip/de4x5.c
+++ b/drivers/net/ethernet/dec/tulip/de4x5.c
@@ -3250,7 +3250,6 @@ srom_map_media(struct net_device *dev)
printk("%s: Bad media code [%d] detected in SROM!\n", dev->name,
lp->infoblock_media);
return -1;
- break;
}
return 0;
--
1.9.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 23/30] bna: remove unnecessary break after return
2014-07-20 14:27 [PATCH 20/30] igb: remove unnecessary break after return Fabian Frederick
2014-07-20 14:27 ` [PATCH 21/30] 8390: " Fabian Frederick
2014-07-20 14:27 ` [PATCH 22/30] net: tulip: " Fabian Frederick
@ 2014-07-20 14:27 ` Fabian Frederick
2014-07-20 14:27 ` [PATCH 24/30] sis900: " Fabian Frederick
` (5 subsequent siblings)
8 siblings, 0 replies; 11+ messages in thread
From: Fabian Frederick @ 2014-07-20 14:27 UTC (permalink / raw)
To: linux-kernel; +Cc: davem, joe, Fabian Frederick, Rasesh Mody, netdev
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
drivers/net/ethernet/brocade/bna/cna_fwimg.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/ethernet/brocade/bna/cna_fwimg.c b/drivers/net/ethernet/brocade/bna/cna_fwimg.c
index 6a68e8d..6f72771 100644
--- a/drivers/net/ethernet/brocade/bna/cna_fwimg.c
+++ b/drivers/net/ethernet/brocade/bna/cna_fwimg.c
@@ -68,10 +68,8 @@ bfa_cb_image_get_chunk(enum bfi_asic_gen asic_gen, u32 off)
switch (asic_gen) {
case BFI_ASIC_GEN_CT:
return (bfi_image_ct_cna + off);
- break;
case BFI_ASIC_GEN_CT2:
return (bfi_image_ct2_cna + off);
- break;
default:
return NULL;
}
@@ -83,10 +81,8 @@ bfa_cb_image_get_size(enum bfi_asic_gen asic_gen)
switch (asic_gen) {
case BFI_ASIC_GEN_CT:
return bfi_image_ct_cna_size;
- break;
case BFI_ASIC_GEN_CT2:
return bfi_image_ct2_cna_size;
- break;
default:
return 0;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 24/30] sis900: remove unnecessary break after return
2014-07-20 14:27 [PATCH 20/30] igb: remove unnecessary break after return Fabian Frederick
` (2 preceding siblings ...)
2014-07-20 14:27 ` [PATCH 23/30] bna: " Fabian Frederick
@ 2014-07-20 14:27 ` Fabian Frederick
2014-07-21 6:26 ` Daniele Venzano
2014-07-20 14:27 ` [PATCH 25/30] niu: " Fabian Frederick
` (4 subsequent siblings)
8 siblings, 1 reply; 11+ messages in thread
From: Fabian Frederick @ 2014-07-20 14:27 UTC (permalink / raw)
To: linux-kernel; +Cc: davem, joe, Fabian Frederick, Daniele Venzano, netdev
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
drivers/net/ethernet/sis/sis900.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/sis/sis900.c b/drivers/net/ethernet/sis/sis900.c
index 6072f09..7bea17c 100644
--- a/drivers/net/ethernet/sis/sis900.c
+++ b/drivers/net/ethernet/sis/sis900.c
@@ -2258,7 +2258,6 @@ static int sis900_set_config(struct net_device *dev, struct ifmap *map)
case IF_PORT_100BASEFX: /* 100BaseFx */
/* These Modes are not supported (are they?)*/
return -EOPNOTSUPP;
- break;
default:
return -EINVAL;
--
1.9.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 25/30] niu: remove unnecessary break after return
2014-07-20 14:27 [PATCH 20/30] igb: remove unnecessary break after return Fabian Frederick
` (3 preceding siblings ...)
2014-07-20 14:27 ` [PATCH 24/30] sis900: " Fabian Frederick
@ 2014-07-20 14:27 ` Fabian Frederick
2014-07-20 14:27 ` [PATCH 26/30] ucc_geth: " Fabian Frederick
` (3 subsequent siblings)
8 siblings, 0 replies; 11+ messages in thread
From: Fabian Frederick @ 2014-07-20 14:27 UTC (permalink / raw)
To: linux-kernel; +Cc: davem, joe, Fabian Frederick, netdev
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
drivers/net/ethernet/sun/niu.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/sun/niu.c b/drivers/net/ethernet/sun/niu.c
index 79606f47a..db8ffde 100644
--- a/drivers/net/ethernet/sun/niu.c
+++ b/drivers/net/ethernet/sun/niu.c
@@ -2584,7 +2584,6 @@ static int niu_determine_phy_disposition(struct niu *np)
break;
default:
return -EINVAL;
- break;
}
phy_addr_off = niu_atca_port_num[np->port];
break;
--
1.9.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 26/30] ucc_geth: remove unnecessary break after return
2014-07-20 14:27 [PATCH 20/30] igb: remove unnecessary break after return Fabian Frederick
` (4 preceding siblings ...)
2014-07-20 14:27 ` [PATCH 25/30] niu: " Fabian Frederick
@ 2014-07-20 14:27 ` Fabian Frederick
2014-07-20 14:27 ` [PATCH 27/30] atl1e: " Fabian Frederick
` (2 subsequent siblings)
8 siblings, 0 replies; 11+ messages in thread
From: Fabian Frederick @ 2014-07-20 14:27 UTC (permalink / raw)
To: linux-kernel; +Cc: davem, joe, Fabian Frederick, Li Yang, netdev, linuxppc-dev
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
drivers/net/ethernet/freescale/ucc_geth.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/freescale/ucc_geth.c b/drivers/net/ethernet/freescale/ucc_geth.c
index 36fc429..8ceaf7a 100644
--- a/drivers/net/ethernet/freescale/ucc_geth.c
+++ b/drivers/net/ethernet/freescale/ucc_geth.c
@@ -2396,7 +2396,6 @@ static int ucc_geth_startup(struct ucc_geth_private *ugeth)
if (netif_msg_ifup(ugeth))
pr_err("Bad number of Rx threads value\n");
return -EINVAL;
- break;
}
switch (ug_info->numThreadsTx) {
@@ -2419,7 +2418,6 @@ static int ucc_geth_startup(struct ucc_geth_private *ugeth)
if (netif_msg_ifup(ugeth))
pr_err("Bad number of Tx threads value\n");
return -EINVAL;
- break;
}
/* Calculate rx_extended_features */
--
1.9.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 27/30] atl1e: remove unnecessary break after return
2014-07-20 14:27 [PATCH 20/30] igb: remove unnecessary break after return Fabian Frederick
` (5 preceding siblings ...)
2014-07-20 14:27 ` [PATCH 26/30] ucc_geth: " Fabian Frederick
@ 2014-07-20 14:27 ` Fabian Frederick
2014-07-20 14:27 ` [PATCH 28/30] atlx: " Fabian Frederick
2014-07-20 14:27 ` [PATCH 29/30] atl1c: " Fabian Frederick
8 siblings, 0 replies; 11+ messages in thread
From: Fabian Frederick @ 2014-07-20 14:27 UTC (permalink / raw)
To: linux-kernel
Cc: davem, joe, Fabian Frederick, Jay Cliburn, Chris Snook, netdev
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
drivers/net/ethernet/atheros/atl1e/atl1e_hw.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/atheros/atl1e/atl1e_hw.c b/drivers/net/ethernet/atheros/atl1e/atl1e_hw.c
index 923063d..113565d 100644
--- a/drivers/net/ethernet/atheros/atl1e/atl1e_hw.c
+++ b/drivers/net/ethernet/atheros/atl1e/atl1e_hw.c
@@ -618,7 +618,6 @@ int atl1e_get_speed_and_duplex(struct atl1e_hw *hw, u16 *speed, u16 *duplex)
break;
default:
return AT_ERR_PHY_SPEED;
- break;
}
if (phy_data & MII_AT001_PSSR_DPLX)
--
1.9.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 28/30] atlx: remove unnecessary break after return
2014-07-20 14:27 [PATCH 20/30] igb: remove unnecessary break after return Fabian Frederick
` (6 preceding siblings ...)
2014-07-20 14:27 ` [PATCH 27/30] atl1e: " Fabian Frederick
@ 2014-07-20 14:27 ` Fabian Frederick
2014-07-20 14:27 ` [PATCH 29/30] atl1c: " Fabian Frederick
8 siblings, 0 replies; 11+ messages in thread
From: Fabian Frederick @ 2014-07-20 14:27 UTC (permalink / raw)
To: linux-kernel
Cc: davem, joe, Fabian Frederick, Jay Cliburn, Chris Snook, netdev
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
drivers/net/ethernet/atheros/atlx/atl1.c | 1 -
drivers/net/ethernet/atheros/atlx/atl2.c | 3 ---
2 files changed, 4 deletions(-)
diff --git a/drivers/net/ethernet/atheros/atlx/atl1.c b/drivers/net/ethernet/atheros/atlx/atl1.c
index b460db7..1546d55 100644
--- a/drivers/net/ethernet/atheros/atlx/atl1.c
+++ b/drivers/net/ethernet/atheros/atlx/atl1.c
@@ -910,7 +910,6 @@ static s32 atl1_get_speed_and_duplex(struct atl1_hw *hw, u16 *speed, u16 *duplex
if (netif_msg_hw(adapter))
dev_dbg(&pdev->dev, "error getting speed\n");
return ATLX_ERR_PHY_SPEED;
- break;
}
if (phy_data & MII_ATLX_PSSR_DPLX)
*duplex = FULL_DUPLEX;
diff --git a/drivers/net/ethernet/atheros/atlx/atl2.c b/drivers/net/ethernet/atheros/atlx/atl2.c
index 6746bd7..c194bc6 100644
--- a/drivers/net/ethernet/atheros/atlx/atl2.c
+++ b/drivers/net/ethernet/atheros/atlx/atl2.c
@@ -2493,7 +2493,6 @@ static s32 atl2_get_speed_and_duplex(struct atl2_hw *hw, u16 *speed,
break;
default:
return ATLX_ERR_PHY_SPEED;
- break;
}
if (phy_data & MII_ATLX_PSSR_DPLX)
@@ -2933,11 +2932,9 @@ static int atl2_validate_option(int *value, struct atl2_option *opt)
case OPTION_ENABLED:
printk(KERN_INFO "%s Enabled\n", opt->name);
return 0;
- break;
case OPTION_DISABLED:
printk(KERN_INFO "%s Disabled\n", opt->name);
return 0;
- break;
}
break;
case range_option:
--
1.9.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 29/30] atl1c: remove unnecessary break after return
2014-07-20 14:27 [PATCH 20/30] igb: remove unnecessary break after return Fabian Frederick
` (7 preceding siblings ...)
2014-07-20 14:27 ` [PATCH 28/30] atlx: " Fabian Frederick
@ 2014-07-20 14:27 ` Fabian Frederick
8 siblings, 0 replies; 11+ messages in thread
From: Fabian Frederick @ 2014-07-20 14:27 UTC (permalink / raw)
To: linux-kernel
Cc: davem, joe, Fabian Frederick, Jay Cliburn, Chris Snook, netdev
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
drivers/net/ethernet/atheros/atl1c/atl1c_hw.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_hw.c b/drivers/net/ethernet/atheros/atl1c/atl1c_hw.c
index 1cda49a..52fdfe2 100644
--- a/drivers/net/ethernet/atheros/atl1c/atl1c_hw.c
+++ b/drivers/net/ethernet/atheros/atl1c/atl1c_hw.c
@@ -639,7 +639,6 @@ int atl1c_phy_init(struct atl1c_hw *hw)
dev_err(&pdev->dev, "Wrong Media type %d\n",
hw->media_type);
return -1;
- break;
}
ret_val = atl1c_write_phy_reg(hw, MII_BMCR, mii_bmcr_data);
@@ -682,7 +681,6 @@ int atl1c_get_speed_and_duplex(struct atl1c_hw *hw, u16 *speed, u16 *duplex)
break;
default:
return -1;
- break;
}
if (phy_data & GIGA_PSSR_DPLX)
--
1.9.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH 24/30] sis900: remove unnecessary break after return
2014-07-20 14:27 ` [PATCH 24/30] sis900: " Fabian Frederick
@ 2014-07-21 6:26 ` Daniele Venzano
0 siblings, 0 replies; 11+ messages in thread
From: Daniele Venzano @ 2014-07-21 6:26 UTC (permalink / raw)
To: Fabian Frederick, linux-kernel; +Cc: davem, joe, netdev
Il 20/07/2014 16:27, Fabian Frederick ha scritto:
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
Signed-off-by: Daniele Venzano <venza@brownhat.org>
> ---
> drivers/net/ethernet/sis/sis900.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/sis/sis900.c b/drivers/net/ethernet/sis/sis900.c
> index 6072f09..7bea17c 100644
> --- a/drivers/net/ethernet/sis/sis900.c
> +++ b/drivers/net/ethernet/sis/sis900.c
> @@ -2258,7 +2258,6 @@ static int sis900_set_config(struct net_device *dev, struct ifmap *map)
> case IF_PORT_100BASEFX: /* 100BaseFx */
> /* These Modes are not supported (are they?)*/
> return -EOPNOTSUPP;
> - break;
>
> default:
> return -EINVAL;
>
--
Daniele Venzano
http://www.brownhat.org
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2014-07-21 6:32 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-20 14:27 [PATCH 20/30] igb: remove unnecessary break after return Fabian Frederick
2014-07-20 14:27 ` [PATCH 21/30] 8390: " Fabian Frederick
2014-07-20 14:27 ` [PATCH 22/30] net: tulip: " Fabian Frederick
2014-07-20 14:27 ` [PATCH 23/30] bna: " Fabian Frederick
2014-07-20 14:27 ` [PATCH 24/30] sis900: " Fabian Frederick
2014-07-21 6:26 ` Daniele Venzano
2014-07-20 14:27 ` [PATCH 25/30] niu: " Fabian Frederick
2014-07-20 14:27 ` [PATCH 26/30] ucc_geth: " Fabian Frederick
2014-07-20 14:27 ` [PATCH 27/30] atl1e: " Fabian Frederick
2014-07-20 14:27 ` [PATCH 28/30] atlx: " Fabian Frederick
2014-07-20 14:27 ` [PATCH 29/30] atl1c: " Fabian Frederick
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).