* [PATCH] net: tso: fix unaligned access to crafted TCP header in helper API
@ 2014-10-21 14:06 Karl Beldan
2014-10-22 16:53 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Karl Beldan @ 2014-10-21 14:06 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev, Karl Beldan, Ezequiel Garcia
From: Karl Beldan <karl.beldan@rivierawaves.com>
The crafted header start address is from a driver supplied buffer, which
one can reasonably expect to be aligned on a 4-bytes boundary.
However ATM the TSO helper API is only used by ethernet drivers and
the tcp header will then be aligned to a 2-bytes only boundary from the
header start address.
Signed-off-by: Karl Beldan <karl.beldan@rivierawaves.com>
Cc: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
---
net/core/tso.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/core/tso.c b/net/core/tso.c
index 8c3203c..630b30b 100644
--- a/net/core/tso.c
+++ b/net/core/tso.c
@@ -1,6 +1,7 @@
#include <linux/export.h>
#include <net/ip.h>
#include <net/tso.h>
+#include <asm/unaligned.h>
/* Calculate expected number of TX descriptors */
int tso_count_descs(struct sk_buff *skb)
@@ -23,7 +24,7 @@ void tso_build_hdr(struct sk_buff *skb, char *hdr, struct tso_t *tso,
iph->id = htons(tso->ip_id);
iph->tot_len = htons(size + hdr_len - mac_hdr_len);
tcph = (struct tcphdr *)(hdr + skb_transport_offset(skb));
- tcph->seq = htonl(tso->tcp_seq);
+ put_unaligned_be32(tso->tcp_seq, &tcph->seq);
tso->ip_id++;
if (!is_last) {
--
2.0.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: tso: fix unaligned access to crafted TCP header in helper API
2014-10-21 14:06 [PATCH] net: tso: fix unaligned access to crafted TCP header in helper API Karl Beldan
@ 2014-10-22 16:53 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-10-22 16:53 UTC (permalink / raw)
To: karl.beldan; +Cc: netdev, karl.beldan, ezequiel.garcia
From: Karl Beldan <karl.beldan@gmail.com>
Date: Tue, 21 Oct 2014 16:06:05 +0200
> From: Karl Beldan <karl.beldan@rivierawaves.com>
>
> The crafted header start address is from a driver supplied buffer, which
> one can reasonably expect to be aligned on a 4-bytes boundary.
> However ATM the TSO helper API is only used by ethernet drivers and
> the tcp header will then be aligned to a 2-bytes only boundary from the
> header start address.
>
> Signed-off-by: Karl Beldan <karl.beldan@rivierawaves.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-10-22 16:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-21 14:06 [PATCH] net: tso: fix unaligned access to crafted TCP header in helper API Karl Beldan
2014-10-22 16:53 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).