[PATCH net] openvswitch: Reset key metadata for packet execution.

[PATCH net] openvswitch: Reset key metadata for packet execution.

[Pravin B Shelar]

Userspace packet execute command pass down flow key for given
packet. But userspace can skip some parameter with zero value.
Therefore kernel needs to initialize key metadata to zero.

Fixes: 0714812134 ("openvswitch: Eliminate memset() from flow_extract.")
Signed-off-by: Pravin B Shelar <pshelar@nicira.com>
---
 net/openvswitch/flow.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/net/openvswitch/flow.c b/net/openvswitch/flow.c
index da2fae0..5e41bf2 100644
--- a/net/openvswitch/flow.c
+++ b/net/openvswitch/flow.c
@@ -717,6 +717,8 @@ int ovs_flow_key_extract_userspace(const struct nlattr *attr,
 {
 	int err;
 
+ 	memset(key, 0, OVS_SW_FLOW_KEY_METADATA_SIZE);
+
 	/* Extract metadata from netlink attributes. */
 	err = ovs_nla_get_flow_metadata(attr, key, log);
 	if (err)
-- 
1.7.1

Re: [PATCH net] openvswitch: Reset key metadata for packet execution.

[David Miller]

From: Pravin B Shelar <pshelar@nicira.com>
Date: Tue, 10 Feb 2015 13:35:16 -0800

> Userspace packet execute command pass down flow key for given
> packet. But userspace can skip some parameter with zero value.
> Therefore kernel needs to initialize key metadata to zero.
> 
> Fixes: 0714812134 ("openvswitch: Eliminate memset() from flow_extract.")
> Signed-off-by: Pravin B Shelar <pshelar@nicira.com>

Applied, but...

> + 	memset(key, 0, OVS_SW_FLOW_KEY_METADATA_SIZE);

There's a space before the TAB in that indentation, and git even
warns about this when applying patches.

I fixed it up, but this is one of the basic things you should be
dealing with before submitting your changes.

Thanks.

Re: [PATCH net] openvswitch: Reset key metadata for packet execution.

[Pravin Shelar]

On Wed, Feb 11, 2015 at 2:40 PM, David Miller <davem@davemloft.net> wrote:
> From: Pravin B Shelar <pshelar@nicira.com>
> Date: Tue, 10 Feb 2015 13:35:16 -0800
>
>> Userspace packet execute command pass down flow key for given
>> packet. But userspace can skip some parameter with zero value.
>> Therefore kernel needs to initialize key metadata to zero.
>>
>> Fixes: 0714812134 ("openvswitch: Eliminate memset() from flow_extract.")
>> Signed-off-by: Pravin B Shelar <pshelar@nicira.com>
>
> Applied, but...
>
>> +     memset(key, 0, OVS_SW_FLOW_KEY_METADATA_SIZE);
>
> There's a space before the TAB in that indentation, and git even
> warns about this when applying patches.
>
> I fixed it up, but this is one of the basic things you should be
> dealing with before submitting your changes.
>

Thanks for fixing the patch.