[PATCH RESEND iproute2] ip link set vf: Added "query_rss" command

[PATCH RESEND iproute2] ip link set vf: Added "query_rss" command

[Vlad Zolotarov]

Add a new option to toggle the ability of querying the RSS configuration of a specific VF.

VF RSS information like RSS hash key may be considered sensitive on some devices where
this information is shared between VF and PF and thus its querying may be prohibited by default.

This new option allows a system administrator with privileges to modify a PF state
to control if the above VF querying is allowed or not.

For example:
 To enable RSS querying of VF[0] of ethX:
 >> ip link set dev ethX vf 0 query_rss on

Signed-off-by: Vlad Zolotarov <vladz@cloudius-systems.com>
---
 include/linux/if_link.h |  5 +++++
 ip/iplink.c             | 13 +++++++++++++
 2 files changed, 18 insertions(+)

diff --git a/include/linux/if_link.h b/include/linux/if_link.h
index 3d0d613..fda8153 100644
--- a/include/linux/if_link.h
+++ b/include/linux/if_link.h
@@ -498,6 +498,11 @@ struct ifla_vf_spoofchk {
 	__u32 setting;
 };
 
+struct ifla_vf_rss_query_en {
+	__u32 vf;
+	__u32 setting;
+};
+
 enum {
 	IFLA_VF_LINK_STATE_AUTO,	/* link state of the uplink */
 	IFLA_VF_LINK_STATE_ENABLE,	/* link always up */
diff --git a/ip/iplink.c b/ip/iplink.c
index e6f30e9..708f2ca 100644
--- a/ip/iplink.c
+++ b/ip/iplink.c
@@ -80,6 +80,7 @@ void iplink_usage(void)
 	fprintf(stderr, "				   [ rate TXRATE ] ] \n");
 
 	fprintf(stderr, "				   [ spoofchk { on | off} ] ] \n");
+	fprintf(stderr, "				   [ query_rss { on | off} ] ] \n");
 	fprintf(stderr, "				   [ state { auto | enable | disable} ] ]\n");
 	fprintf(stderr, "			  [ master DEVICE ]\n");
 	fprintf(stderr, "			  [ nomaster ]\n");
@@ -331,6 +332,18 @@ static int iplink_parse_vf(int vf, int *argcp, char ***argvp,
 			ivs.vf = vf;
 			addattr_l(&req->n, sizeof(*req), IFLA_VF_SPOOFCHK, &ivs, sizeof(ivs));
 
+		} else if (matches(*argv, "query_rss") == 0) {
+			struct ifla_vf_rss_query_en ivs;
+			NEXT_ARG();
+			if (matches(*argv, "on") == 0)
+				ivs.setting = 1;
+			else if (matches(*argv, "off") == 0)
+				ivs.setting = 0;
+			else
+				invarg("Invalid \"query_rss\" value\n", *argv);
+			ivs.vf = vf;
+			addattr_l(&req->n, sizeof(*req), IFLA_VF_RSS_QUERY_EN, &ivs, sizeof(ivs));
+
 		} else if (matches(*argv, "state") == 0) {
 			struct ifla_vf_link_state ivl;
 			NEXT_ARG();
-- 
2.1.0

Re: [PATCH RESEND iproute2] ip link set vf: Added "query_rss" command

[Stephen Hemminger]

On Thu, 30 Apr 2015 13:46:43 +0300
Vlad Zolotarov <vladz@cloudius-systems.com> wrote:

> Add a new option to toggle the ability of querying the RSS configuration of a specific VF.
> 
> VF RSS information like RSS hash key may be considered sensitive on some devices where
> this information is shared between VF and PF and thus its querying may be prohibited by default.
> 
> This new option allows a system administrator with privileges to modify a PF state
> to control if the above VF querying is allowed or not.
> 
> For example:
>  To enable RSS querying of VF[0] of ethX:
>  >> ip link set dev ethX vf 0 query_rss on
> 
> Signed-off-by: Vlad Zolotarov <vladz@cloudius-systems.com>

Applied