* [PATCH 06/11] drivers/net: include <module.h> for modular stmmac_platform code
[not found] <1430444867-22342-1-git-send-email-paul.gortmaker@windriver.com>
@ 2015-05-01 1:47 ` Paul Gortmaker
2015-05-04 3:40 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Paul Gortmaker @ 2015-05-01 1:47 UTC (permalink / raw)
To: linux-kernel; +Cc: Paul Gortmaker, Giuseppe Cavallaro, netdev
This file is built off of a tristate Kconfig option and also contains
modular function calls so it should explicitly include module.h to
avoid compile breakage during header shuffles done in the future.
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Cc: netdev@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
index 705bbdf93940..68aec5c460db 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
@@ -23,6 +23,7 @@
*******************************************************************************/
#include <linux/platform_device.h>
+#include <linux/module.h>
#include <linux/io.h>
#include <linux/of.h>
#include <linux/of_net.h>
--
2.2.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 06/11] drivers/net: include <module.h> for modular stmmac_platform code
2015-05-01 1:47 ` [PATCH 06/11] drivers/net: include <module.h> for modular stmmac_platform code Paul Gortmaker
@ 2015-05-04 3:40 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-05-04 3:40 UTC (permalink / raw)
To: paul.gortmaker; +Cc: linux-kernel, peppe.cavallaro, netdev
From: Paul Gortmaker <paul.gortmaker@windriver.com>
Date: Thu, 30 Apr 2015 21:47:42 -0400
> This file is built off of a tristate Kconfig option and also contains
> modular function calls so it should explicitly include module.h to
> avoid compile breakage during header shuffles done in the future.
>
> Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
> Cc: netdev@vger.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Applied, thanks Paul.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-05-04 3:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1430444867-22342-1-git-send-email-paul.gortmaker@windriver.com>
2015-05-01 1:47 ` [PATCH 06/11] drivers/net: include <module.h> for modular stmmac_platform code Paul Gortmaker
2015-05-04 3:40 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).