* [PATCH net] netns: return RTM_NEWNSID instead of RTM_GETNSID on a get
@ 2015-05-11 13:57 Nicolas Dichtel
2015-05-12 22:54 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Nicolas Dichtel @ 2015-05-11 13:57 UTC (permalink / raw)
To: davem; +Cc: netdev, Nicolas Dichtel
Usually, RTM_NEWxxx is returned on a get (same as a dump).
Fixes: 0c7aecd4bde4 ("netns: add rtnl cmd to add and get peer netns ids")
Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
---
David, FYI, this patch will conflict with my last series on net-next.
The prototype of rtnl_net_fill() has changed. In any problem, please let me
know.
net/core/net_namespace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c
index 78fc04ad36fc..572af0011997 100644
--- a/net/core/net_namespace.c
+++ b/net/core/net_namespace.c
@@ -601,7 +601,7 @@ static int rtnl_net_getid(struct sk_buff *skb, struct nlmsghdr *nlh)
}
err = rtnl_net_fill(msg, NETLINK_CB(skb).portid, nlh->nlmsg_seq, 0,
- RTM_GETNSID, net, peer, -1);
+ RTM_NEWNSID, net, peer, -1);
if (err < 0)
goto err_out;
--
2.2.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] netns: return RTM_NEWNSID instead of RTM_GETNSID on a get
2015-05-11 13:57 [PATCH net] netns: return RTM_NEWNSID instead of RTM_GETNSID on a get Nicolas Dichtel
@ 2015-05-12 22:54 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-05-12 22:54 UTC (permalink / raw)
To: nicolas.dichtel; +Cc: netdev
From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Date: Mon, 11 May 2015 15:57:31 +0200
> Usually, RTM_NEWxxx is returned on a get (same as a dump).
>
> Fixes: 0c7aecd4bde4 ("netns: add rtnl cmd to add and get peer netns ids")
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
> ---
>
> David, FYI, this patch will conflict with my last series on net-next.
> The prototype of rtnl_net_fill() has changed. In any problem, please let me
> know.
Applied, thanks Nicolas.
I'll sort out the conflict when I next do a merge, thanks for the heads
up.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-05-12 22:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-11 13:57 [PATCH net] netns: return RTM_NEWNSID instead of RTM_GETNSID on a get Nicolas Dichtel
2015-05-12 22:54 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).