From: Eric Dumazet <eric.dumazet@gmail.com>
To: Alexei Starovoitov <ast@plumgrid.com>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
Daniel Borkmann <daniel@iogearbox.net>,
netdev@vger.kernel.org, davem@davemloft.net, jhs@mojatatu.com
Subject: Re: [PATCH 2/2 net-next] net: move qdisc ingress filtering code where it belongs
Date: Mon, 11 May 2015 16:30:38 -0700 [thread overview]
Message-ID: <1431387038.566.47.camel@edumazet-glaptop2.roam.corp.google.com> (raw)
In-Reply-To: <555134F4.80007@plumgrid.com>
On Mon, 2015-05-11 at 16:02 -0700, Alexei Starovoitov wrote:
> On 5/11/15 7:35 AM, Eric Dumazet wrote:
> >
> > -static inline int deliver_skb(struct sk_buff *skb,
> > +static noinline int deliver_skb(struct sk_buff *skb,
> > struct packet_type *pt_prev,
> > struct net_device *orig_dev)
>
> have tried the above only and didn't see any difference
> for simple 'netif_receive + drop in ip_rcv' test.
> Not sure whether it's actually worth doing. I would leave it as-is.
Yes, this was probably too aggressive.
unlikely() or static_key_false() are no moving code away enough, whole
function including unused code pollutes icache.
Code size increased a lot, while L1/L2 caches on cpu are about the same
than 6 years ago.
For example , commit 7866a621043fbaca3d7389e9b9f69dd1a2e5a855
helped a given workload, but probably made things slower for most common
cases.
next prev parent reply other threads:[~2015-05-11 23:30 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-10 16:59 [PATCH 0/2 net-next] critical ingress path performance improvements Pablo Neira Ayuso
2015-05-10 16:59 ` [PATCH 1/2 net-next] net: kill useless net_*_ingress_queue() definitions when NET_CLS_ACT is unset Pablo Neira Ayuso
2015-05-10 16:58 ` Sergei Shtylyov
2015-05-10 16:59 ` [PATCH 2/2 net-next] net: move qdisc ingress filtering code where it belongs Pablo Neira Ayuso
2015-05-10 17:25 ` Eric Dumazet
2015-05-10 17:45 ` Alexei Starovoitov
2015-05-10 17:59 ` Pablo Neira Ayuso
2015-05-10 18:05 ` Alexei Starovoitov
2015-05-10 18:24 ` Pablo Neira Ayuso
2015-05-10 18:47 ` Alexei Starovoitov
2015-05-10 19:00 ` Pablo Neira Ayuso
2015-05-10 19:06 ` Alexei Starovoitov
2015-05-10 19:20 ` Pablo Neira Ayuso
2015-05-10 19:37 ` Alexei Starovoitov
2015-05-10 19:50 ` Pablo Neira Ayuso
2015-05-10 21:31 ` Daniel Borkmann
2015-05-10 21:44 ` Daniel Borkmann
2015-05-10 23:43 ` Pablo Neira Ayuso
2015-05-11 5:57 ` Alexei Starovoitov
2015-05-11 12:49 ` Jamal Hadi Salim
2015-05-11 12:58 ` Daniel Borkmann
2015-05-11 17:15 ` Alexei Starovoitov
2015-05-11 13:32 ` Pablo Neira Ayuso
2015-05-11 14:35 ` Eric Dumazet
2015-05-11 23:02 ` Alexei Starovoitov
2015-05-11 23:30 ` Eric Dumazet [this message]
2015-05-12 3:21 ` Alexei Starovoitov
2015-05-12 12:55 ` Pablo Neira Ayuso
2015-05-12 13:27 ` Daniel Borkmann
2015-05-12 21:22 ` Alexei Starovoitov
2015-05-12 21:43 ` Daniel Borkmann
2015-05-10 20:40 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1431387038.566.47.camel@edumazet-glaptop2.roam.corp.google.com \
--to=eric.dumazet@gmail.com \
--cc=ast@plumgrid.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).