Re: [PATCH 2/2 net-next] net: move qdisc ingress filtering code where it belongs

[Pablo Neira Ayuso <pablo@netfilter.org>]

On Sun, May 10, 2015 at 11:47:01AM -0700, Alexei Starovoitov wrote:
> On 5/10/15 11:24 AM, Pablo Neira Ayuso wrote:
> >On Sun, May 10, 2015 at 11:05:28AM -0700, Alexei Starovoitov wrote:
> >>On 5/10/15 10:59 AM, Pablo Neira Ayuso wrote:
> >>>No, Daniel is *not* benchmarking the netif_received_core() with no
> >>>filtering at all.
> >>
> >>sorry, not true. We did benchmark all combinations. Daniel posted
> >>his, I'll send numbers from my box as well.
> >
> >Daniel said:
> >
> >"The extra indirection layers however, are not necessary for calling
> >into ingress qdisc. pktgen calling locally into netif_receive_skb()
> >with a dummy u32, single CPU result on a Supermicro X10SLM-F, Xeon
> >E3-1240: before ~21,1 Mpps, after patch ~22,9 Mpps."
> >
> >That explicitly refers to u32, hence qdisc ingress, so he did *not*
> >post any number of the use case I'm indicating.
> 
> I think I'm starting to understand your concern.
> You've read the patch in a way that it slows down netif_receive
> _without_ ingress qdisc?

No. What I said regarding my patchset I said:

"This patch improves performance of the super-critical ingress path by
moving the qdisc ingress code to sch_ingress, where this really
belongs."

The inlined code into the ingress core path seems to have an impact to
people that don't need this, even with the static key.