* [PATCH] drivers: net: xgene: Pre-initialize ret in xgene_enet_get_resources()
@ 2015-06-25 13:13 Geert Uytterhoeven
2015-06-28 23:54 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2015-06-25 13:13 UTC (permalink / raw)
To: David S. Miller, Suman Tripathi, Iyappan Subramanian, Keyur Chudgar
Cc: netdev, linux-kernel, Geert Uytterhoeven
If CONFIG_ACPI=n:
drivers/net/ethernet/apm/xgene/xgene_enet_main.c: In function ‘xgene_enet_get_resources’:
drivers/net/ethernet/apm/xgene/xgene_enet_main.c:951: warning: ‘ret’ may be used uninitialized in this function
If the driver is bound to a legacy platform device, ret will contain
arbitrary data. If it is non-zero, it will be returned to the caller as
an error code.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
index 95153b234c7158c6..299eb4315fe647ba 100644
--- a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
+++ b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
@@ -948,7 +948,7 @@ static int xgene_enet_get_resources(struct xgene_enet_pdata *pdata)
struct resource *res;
void __iomem *base_addr;
u32 offset;
- int ret;
+ int ret = 0;
pdev = pdata->pdev;
dev = &pdev->dev;
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers: net: xgene: Pre-initialize ret in xgene_enet_get_resources()
2015-06-25 13:13 [PATCH] drivers: net: xgene: Pre-initialize ret in xgene_enet_get_resources() Geert Uytterhoeven
@ 2015-06-28 23:54 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-06-28 23:54 UTC (permalink / raw)
To: geert; +Cc: stripathi, isubramanian, kchudgar, netdev, linux-kernel
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Thu, 25 Jun 2015 15:13:29 +0200
> If CONFIG_ACPI=n:
>
> drivers/net/ethernet/apm/xgene/xgene_enet_main.c: In function ‘xgene_enet_get_resources’:
> drivers/net/ethernet/apm/xgene/xgene_enet_main.c:951: warning: ‘ret’ may be used uninitialized in this function
>
> If the driver is bound to a legacy platform device, ret will contain
> arbitrary data. If it is non-zero, it will be returned to the caller as
> an error code.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-06-28 23:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-25 13:13 [PATCH] drivers: net: xgene: Pre-initialize ret in xgene_enet_get_resources() Geert Uytterhoeven
2015-06-28 23:54 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).