netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mac80211_hwsim: unregister genetlink family properly
@ 2015-07-22  3:57 Su Kang Yin
  0 siblings, 0 replies; 3+ messages in thread
From: Su Kang Yin @ 2015-07-22  3:57 UTC (permalink / raw)
  To: Kalle Valo, linux-wireless, netdev, linux-kernel; +Cc: Su Kang Yin

During hwsim_init_netlink(), we should call genl_unregister_family()
if failed on netlink_register_notifier() since the genetlink is
already registered.

Signed-off-by: Su Kang Yin <cantona@cantona.net>
---
 drivers/net/wireless/mac80211_hwsim.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/mac80211_hwsim.c b/drivers/net/wireless/mac80211_hwsim.c
index 99e873d..16d953e 100644
--- a/drivers/net/wireless/mac80211_hwsim.c
+++ b/drivers/net/wireless/mac80211_hwsim.c
@@ -3120,8 +3120,10 @@ static int hwsim_init_netlink(void)
 		goto failure;
 
 	rc = netlink_register_notifier(&hwsim_netlink_notifier);
-	if (rc)
+	if (rc) {
+		genl_unregister_family(&hwsim_genl_family);
 		goto failure;
+	}
 
 	return 0;
 
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] mac80211_hwsim: unregister genetlink family properly
  2015-08-07  8:54 Su Kang Yin
@ 2015-08-13 13:10 ` Johannes Berg
  0 siblings, 0 replies; 3+ messages in thread
From: Johannes Berg @ 2015-08-13 13:10 UTC (permalink / raw)
  To: Su Kang Yin; +Cc: Kalle Valo, linux-wireless, netdev, linux-kernel

On Fri, 2015-08-07 at 16:54 +0800, Su Kang Yin wrote:
> During hwsim_init_netlink(), we should call genl_unregister_family()
> if failed on netlink_register_notifier() since the genetlink is
> already registered.
> 
Applied.

johannes

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] mac80211_hwsim: unregister genetlink family properly
@ 2015-08-07  8:54 Su Kang Yin
  2015-08-13 13:10 ` Johannes Berg
  0 siblings, 1 reply; 3+ messages in thread
From: Su Kang Yin @ 2015-08-07  8:54 UTC (permalink / raw)
  To: Johannes Berg
  Cc: Kalle Valo, linux-wireless, netdev, linux-kernel, Su Kang Yin

During hwsim_init_netlink(), we should call genl_unregister_family()
if failed on netlink_register_notifier() since the genetlink is
already registered.

Signed-off-by: Su Kang Yin <cantona@cantona.net>
---
 drivers/net/wireless/mac80211_hwsim.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/mac80211_hwsim.c b/drivers/net/wireless/mac80211_hwsim.c
index 99e873d..16d953e 100644
--- a/drivers/net/wireless/mac80211_hwsim.c
+++ b/drivers/net/wireless/mac80211_hwsim.c
@@ -3120,8 +3120,10 @@ static int hwsim_init_netlink(void)
 		goto failure;
 
 	rc = netlink_register_notifier(&hwsim_netlink_notifier);
-	if (rc)
+	if (rc) {
+		genl_unregister_family(&hwsim_genl_family);
 		goto failure;
+	}
 
 	return 0;
 
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-08-13 13:10 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-22  3:57 [PATCH] mac80211_hwsim: unregister genetlink family properly Su Kang Yin
2015-08-07  8:54 Su Kang Yin
2015-08-13 13:10 ` Johannes Berg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).