netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: Linux kernel commit breaks IPMI on iface downing
       [not found] <CAJPaPGU2_68J4BZanm+Lw3O+WTiwO3swegh5grP5Bn-XprLOwg@mail.gmail.com>
@ 2015-08-14  1:30 ` Michael Chan
  2015-08-14  9:22   ` Sébastien Bocahu
  0 siblings, 1 reply; 6+ messages in thread
From: Michael Chan @ 2015-08-14  1:30 UTC (permalink / raw)
  To: Sébastien Bocahu, harish.patil; +Cc: davem, netdev

+netdev and Harish who is the current maintainer of bnx2 at qlogic.

The patch in question effectively just removes the
bnx2_set_power_state() call during "ip link set down".  If there is
IPMI, the firmware should know the link needs to stay up when the driver
resets the device during bnx2_close().  This should be a very common
scenario.  Please provide the firmware versions to Harish with ethtool
-i.  Perhaps upgrading the firmware can resolve this issue.

On Thu, 2015-08-13 at 15:47 +0200, Sébastien Bocahu wrote: 
> Hi,
> 
> Being unable to install Debian Jessie via IPMI on mainstream Dell R410
> servers that used to be well supported by Debian Wheezy, I tracked the
> problem down to a specific commit in the Linux kernel, specifically in
> the bnx2 driver.
> The issue is that "ip link set eth0 down" takes the Ethernet part of
> the BMC down (shared NIC for BMC+eth0), cutting off the IPMI session.
> The BMC gets back only after power cycling.
> 
> Hardware: Dell R410 w/ a Broadcom 5716 NIC:
> Ethernet controller: Broadcom Corporation NetXtreme II BCM5716 Gigabit
> Ethernet (rev 20)  )
> Part number: BCM95716C1
> Vendor specific: 6.4.5 (Firmware has been updated to the latest
> version available by Dell's support website)
> 
> I built many kernels to track which change caused the issue and it
> seems that's :
> 25bfb1dd4ba3b2d9a49ce9d9b0cd7be1840e15ed (bnx2: Add pci shutdown handler.)
> 
> Before, 'ip link set eth0 down' would just cause 2/3s of packet loss
> but IPMI would still be working afterwards.
> 
> I'm available for more informations and/or testing if needed.
> 
> Thanks !
> 
> 
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Linux kernel commit breaks IPMI on iface downing
  2015-08-14  1:30 ` Linux kernel commit breaks IPMI on iface downing Michael Chan
@ 2015-08-14  9:22   ` Sébastien Bocahu
  2015-09-04  7:55     ` Sébastien Bocahu
  0 siblings, 1 reply; 6+ messages in thread
From: Sébastien Bocahu @ 2015-08-14  9:22 UTC (permalink / raw)
  To: Michael Chan; +Cc: harish.patil, davem, netdev

The BNX2 firmware has already been updated to the latest version
available from Dell.

root@debian:~# ethtool -i eth0 | grep firmware
firmware-version: 6.4.5 bc 5.2.3 NCSI 2.0.11

2015-08-14 3:30 GMT+02:00 Michael Chan <mchan@broadcom.com>:
> +netdev and Harish who is the current maintainer of bnx2 at qlogic.
>
> The patch in question effectively just removes the
> bnx2_set_power_state() call during "ip link set down".  If there is
> IPMI, the firmware should know the link needs to stay up when the driver
> resets the device during bnx2_close().  This should be a very common
> scenario.  Please provide the firmware versions to Harish with ethtool
> -i.  Perhaps upgrading the firmware can resolve this issue.
>
> On Thu, 2015-08-13 at 15:47 +0200, Sébastien Bocahu wrote:
>> Hi,
>>
>> Being unable to install Debian Jessie via IPMI on mainstream Dell R410
>> servers that used to be well supported by Debian Wheezy, I tracked the
>> problem down to a specific commit in the Linux kernel, specifically in
>> the bnx2 driver.
>> The issue is that "ip link set eth0 down" takes the Ethernet part of
>> the BMC down (shared NIC for BMC+eth0), cutting off the IPMI session.
>> The BMC gets back only after power cycling.
>>
>> Hardware: Dell R410 w/ a Broadcom 5716 NIC:
>> Ethernet controller: Broadcom Corporation NetXtreme II BCM5716 Gigabit
>> Ethernet (rev 20)  )
>> Part number: BCM95716C1
>> Vendor specific: 6.4.5 (Firmware has been updated to the latest
>> version available by Dell's support website)
>>
>> I built many kernels to track which change caused the issue and it
>> seems that's :
>> 25bfb1dd4ba3b2d9a49ce9d9b0cd7be1840e15ed (bnx2: Add pci shutdown handler.)
>>
>> Before, 'ip link set eth0 down' would just cause 2/3s of packet loss
>> but IPMI would still be working afterwards.
>>
>> I'm available for more informations and/or testing if needed.
>>
>> Thanks !
>>
>>
>>
>
>



-- 
Sébastien Bocahu
IT infrastructure manager

4, Rue Montrochet - 69002 - Lyon, France

+33 (0)437651704 - Phone
ReportLinker.com

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Linux kernel commit breaks IPMI on iface downing
  2015-08-14  9:22   ` Sébastien Bocahu
@ 2015-09-04  7:55     ` Sébastien Bocahu
  2015-09-04  8:29       ` Michael Chan
  0 siblings, 1 reply; 6+ messages in thread
From: Sébastien Bocahu @ 2015-09-04  7:55 UTC (permalink / raw)
  To: Michael Chan; +Cc: harish.patil, davem, netdev

Hi,

Any chance this behaviour gets fixed, with either a new firmware or a
workaround in the kernel ?

thanks

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Linux kernel commit breaks IPMI on iface downing
  2015-09-04  7:55     ` Sébastien Bocahu
@ 2015-09-04  8:29       ` Michael Chan
  2015-09-09  1:33         ` Harish Patil
  0 siblings, 1 reply; 6+ messages in thread
From: Michael Chan @ 2015-09-04  8:29 UTC (permalink / raw)
  To: Sébastien Bocahu; +Cc: harish.patil, davem, netdev

On Fri, 2015-09-04 at 09:55 +0200, Sébastien Bocahu wrote: 
> Hi,
> 
> Any chance this behaviour gets fixed, with either a new firmware or a
> workaround in the kernel ?
> 

As I said earlier, when we call bnx2_shutdown_chip(), we inform the
firmware that the driver is shutting down.  The firmware should know
that there is IPMI firmware and the link needs to stay up.

In the older driver, we would also call bnx2_set_power_state() which
would send some additional messages to the firmware before putting the
device in D3hot.  May be these messages are required by the firmware to
keep the link up.  Harish, please check with your firmware team.
Thanks.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Linux kernel commit breaks IPMI on iface downing
  2015-09-04  8:29       ` Michael Chan
@ 2015-09-09  1:33         ` Harish Patil
  2016-08-02  7:58           ` Chen-Yu Tsai
  0 siblings, 1 reply; 6+ messages in thread
From: Harish Patil @ 2015-09-09  1:33 UTC (permalink / raw)
  To: Michael Chan, Sébastien Bocahu; +Cc: David Miller, netdev, Ameen Rahman


>On Fri, 2015-09-04 at 09:55 +0200, Sébastien Bocahu wrote:
>> Hi,
>> 
>> Any chance this behaviour gets fixed, with either a new firmware or a
>> workaround in the kernel ?
>> 
>
>As I said earlier, when we call bnx2_shutdown_chip(), we inform the
>firmware that the driver is shutting down.  The firmware should know
>that there is IPMI firmware and the link needs to stay up.
>
>In the older driver, we would also call bnx2_set_power_state() which
>would send some additional messages to the firmware before putting the
>device in D3hot.  May be these messages are required by the firmware to
>keep the link up.  Harish, please check with your firmware team.
>Thanks.
>
>
>
>

Hi Michael/Sebastien,
ACK. Sure, I will look into it and get back.

Thanks,
Harish


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Linux kernel commit breaks IPMI on iface downing
  2015-09-09  1:33         ` Harish Patil
@ 2016-08-02  7:58           ` Chen-Yu Tsai
  0 siblings, 0 replies; 6+ messages in thread
From: Chen-Yu Tsai @ 2016-08-02  7:58 UTC (permalink / raw)
  To: Harish Patil
  Cc: Michael Chan, Sébastien Bocahu, David Miller, netdev, Ameen Rahman

Hi,

On Wed, Sep 9, 2015 at 9:33 AM, Harish Patil <harish.patil@qlogic.com> wrote:
>
>>On Fri, 2015-09-04 at 09:55 +0200, Sébastien Bocahu wrote:
>>> Hi,
>>>
>>> Any chance this behaviour gets fixed, with either a new firmware or a
>>> workaround in the kernel ?
>>>
>>
>>As I said earlier, when we call bnx2_shutdown_chip(), we inform the
>>firmware that the driver is shutting down.  The firmware should know
>>that there is IPMI firmware and the link needs to stay up.
>>
>>In the older driver, we would also call bnx2_set_power_state() which
>>would send some additional messages to the firmware before putting the
>>device in D3hot.  May be these messages are required by the firmware to
>>keep the link up.  Harish, please check with your firmware team.
>>Thanks.
>>
>>
>>
>>
>
> Hi Michael/Sebastien,
> ACK. Sure, I will look into it and get back.

Sorry to resurrect such an old thread. I'm still having problems with this.

We have a whole bunch of Dell PowerEdge R210 II servers at our datacenter.
These have the NetXtreme II BCM 5716 controller. Most still have the
factory firmware (6.2.12) while a few have been updated to the latest
firmware released by Dell (7.12.19). With both versions, IPMI over LAN
becomes unusable as soon as Ubuntu's installer reconfigures the network.
It only returns after installation is complete and the system is reboot,
after the firmware is reloaded.

This means if anything were to fail during an automated installation,
the system would no longer be controllable remotely. For us this is a
huge inconvenience, as we have hundreds of them. If any go down due
to bad installation scripts or entering a wrong command, someone has
to literally go there and reboot the machine.

I also tested with Ubuntu 16.04.1, running Ubuntu's 4.4.0-31-generic
kernel. IPMI over LAN is unusable as soon as "ip link set XXX down" is
run, and recovers in 1 second after "ip link set XXX up" is run, or when
the system is restarted.

So in addition to IPMI not working on iface down, there might be a
problem with how the installer works, resulting in the prolonged
outage.


Regards
ChenYu

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2016-08-02  7:59 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CAJPaPGU2_68J4BZanm+Lw3O+WTiwO3swegh5grP5Bn-XprLOwg@mail.gmail.com>
2015-08-14  1:30 ` Linux kernel commit breaks IPMI on iface downing Michael Chan
2015-08-14  9:22   ` Sébastien Bocahu
2015-09-04  7:55     ` Sébastien Bocahu
2015-09-04  8:29       ` Michael Chan
2015-09-09  1:33         ` Harish Patil
2016-08-02  7:58           ` Chen-Yu Tsai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).