* [PATCH v2 0/1] Fix for module license in Broadcom Phy Library
@ 2015-10-15 17:37 Arun Parameswaran
2015-10-15 17:37 ` [PATCH v2 1/1] net: phy: bcm-phy-lib: Fix module license issue Arun Parameswaran
0 siblings, 1 reply; 4+ messages in thread
From: Arun Parameswaran @ 2015-10-15 17:37 UTC (permalink / raw)
To: Florian Fainelli, David S . Miller
Cc: netdev-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w,
Arun Parameswaran
Hi
This patchset adds the module description, license & author to the
Broadcom Phy Library (drivers/net/phy/bcm-phy-lib.c) introduced by
the commit: a1cba5613edf5 ("net: phy: Add Broadcom phy library for
common interfaces")
Changes from v1:
-Created the patch based on David Miller's 'net-next' Kernel tree
Arun Parameswaran (1):
net: phy: bcm-phy-lib: Fix module license issue
drivers/net/phy/bcm-phy-lib.c | 5 +++++
1 file changed, 5 insertions(+)
--
2.6.1
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2 1/1] net: phy: bcm-phy-lib: Fix module license issue
2015-10-15 17:37 [PATCH v2 0/1] Fix for module license in Broadcom Phy Library Arun Parameswaran
@ 2015-10-15 17:37 ` Arun Parameswaran
2015-10-15 17:39 ` Florian Fainelli
[not found] ` <1444930633-23314-2-git-send-email-arunp-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
0 siblings, 2 replies; 4+ messages in thread
From: Arun Parameswaran @ 2015-10-15 17:37 UTC (permalink / raw)
To: Florian Fainelli, David S . Miller
Cc: netdev, devicetree, linux-kernel, bcm-kernel-feedback-list,
Arun Parameswaran
The 'bcm-phy-lib.c', added as a part of the commit
"net: phy: Add Broadcom phy library for common interfaces"
was missing the module license. This was causing an issue
when the library is built as a module; "module license
'unspecified' taints kernel".
This patch fixes the issue by adding the module license,
author and description to the bcm-phy-lib.c file.
Fixes: a1cba5613edf5 ("net: phy: Add Broadcom phy library for
common interfaces")
Signed-off-by: Arun Parameswaran <arunp@broadcom.com>
---
drivers/net/phy/bcm-phy-lib.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/phy/bcm-phy-lib.c b/drivers/net/phy/bcm-phy-lib.c
index dd79ea6..ddb377e 100644
--- a/drivers/net/phy/bcm-phy-lib.c
+++ b/drivers/net/phy/bcm-phy-lib.c
@@ -15,6 +15,7 @@
#include <linux/brcmphy.h>
#include <linux/export.h>
#include <linux/mdio.h>
+#include <linux/module.h>
#include <linux/phy.h>
#define MII_BCM_CHANNEL_WIDTH 0x2000
@@ -206,3 +207,7 @@ int bcm_phy_enable_eee(struct phy_device *phydev)
return 0;
}
EXPORT_SYMBOL_GPL(bcm_phy_enable_eee);
+
+MODULE_DESCRIPTION("Broadcom PHY Library");
+MODULE_LICENSE("GPL v2");
+MODULE_AUTHOR("Broadcom Corporation");
--
2.6.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2 1/1] net: phy: bcm-phy-lib: Fix module license issue
2015-10-15 17:37 ` [PATCH v2 1/1] net: phy: bcm-phy-lib: Fix module license issue Arun Parameswaran
@ 2015-10-15 17:39 ` Florian Fainelli
[not found] ` <1444930633-23314-2-git-send-email-arunp-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
1 sibling, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2015-10-15 17:39 UTC (permalink / raw)
To: Arun Parameswaran, David S . Miller
Cc: netdev, devicetree, linux-kernel, bcm-kernel-feedback-list
On 15/10/15 10:37, Arun Parameswaran wrote:
> The 'bcm-phy-lib.c', added as a part of the commit
> "net: phy: Add Broadcom phy library for common interfaces"
> was missing the module license. This was causing an issue
> when the library is built as a module; "module license
> 'unspecified' taints kernel".
>
> This patch fixes the issue by adding the module license,
> author and description to the bcm-phy-lib.c file.
>
> Fixes: a1cba5613edf5 ("net: phy: Add Broadcom phy library for
> common interfaces")
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
> Signed-off-by: Arun Parameswaran <arunp@broadcom.com>
> ---
> drivers/net/phy/bcm-phy-lib.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/net/phy/bcm-phy-lib.c b/drivers/net/phy/bcm-phy-lib.c
> index dd79ea6..ddb377e 100644
> --- a/drivers/net/phy/bcm-phy-lib.c
> +++ b/drivers/net/phy/bcm-phy-lib.c
> @@ -15,6 +15,7 @@
> #include <linux/brcmphy.h>
> #include <linux/export.h>
> #include <linux/mdio.h>
> +#include <linux/module.h>
> #include <linux/phy.h>
>
> #define MII_BCM_CHANNEL_WIDTH 0x2000
> @@ -206,3 +207,7 @@ int bcm_phy_enable_eee(struct phy_device *phydev)
> return 0;
> }
> EXPORT_SYMBOL_GPL(bcm_phy_enable_eee);
> +
> +MODULE_DESCRIPTION("Broadcom PHY Library");
> +MODULE_LICENSE("GPL v2");
> +MODULE_AUTHOR("Broadcom Corporation");
> --
> 2.6.1
>
--
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 1/1] net: phy: bcm-phy-lib: Fix module license issue
[not found] ` <1444930633-23314-2-git-send-email-arunp-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
@ 2015-10-19 2:35 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2015-10-19 2:35 UTC (permalink / raw)
To: arunp-dY08KVG/lbpWk0Htik3J/w
Cc: f.fainelli-Re5JQEeQqe8AvxtiuMwx3w, netdev-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w
From: Arun Parameswaran <arunp-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
Date: Thu, 15 Oct 2015 10:37:13 -0700
> The 'bcm-phy-lib.c', added as a part of the commit
> "net: phy: Add Broadcom phy library for common interfaces"
> was missing the module license. This was causing an issue
> when the library is built as a module; "module license
> 'unspecified' taints kernel".
>
> This patch fixes the issue by adding the module license,
> author and description to the bcm-phy-lib.c file.
>
> Fixes: a1cba5613edf5 ("net: phy: Add Broadcom phy library for
> common interfaces")
> Signed-off-by: Arun Parameswaran <arunp-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
Applied.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-10-19 2:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-15 17:37 [PATCH v2 0/1] Fix for module license in Broadcom Phy Library Arun Parameswaran
2015-10-15 17:37 ` [PATCH v2 1/1] net: phy: bcm-phy-lib: Fix module license issue Arun Parameswaran
2015-10-15 17:39 ` Florian Fainelli
[not found] ` <1444930633-23314-2-git-send-email-arunp-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2015-10-19 2:35 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).