* [PATCH 3/3] net: wireless: rt2x00: Space Required
@ 2015-10-17 21:11 Paul McQuade
2016-01-21 17:10 ` Helmut Schaa
0 siblings, 1 reply; 3+ messages in thread
From: Paul McQuade @ 2015-10-17 21:11 UTC (permalink / raw)
To: paulmcquad
Cc: sgruszka, helmut.schaa, kvalo, linux-wireless, netdev, linux-kernel
Space needed before open parenthesis
Signed-off-by: Paul McQuade <paulmcquad@gmail.com>
---
drivers/net/wireless/rt2x00/rt2x00debug.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/rt2x00/rt2x00debug.c b/drivers/net/wireless/rt2x00/rt2x00debug.c
index 90fdb02..25ee3cb 100644
--- a/drivers/net/wireless/rt2x00/rt2x00debug.c
+++ b/drivers/net/wireless/rt2x00/rt2x00debug.c
@@ -629,7 +629,7 @@ static struct dentry *rt2x00debug_create_file_chipset(const char *name,
data += sprintf(data, "register\tbase\twords\twordsize\n");
#define RT2X00DEBUGFS_SPRINTF_REGISTER(__name) \
{ \
- if(debug->__name.read) \
+ if (debug->__name.read) \
data += sprintf(data, __stringify(__name) \
"\t%d\t%d\t%d\n", \
debug->__name.word_base, \
@@ -699,7 +699,7 @@ void rt2x00debug_register(struct rt2x00_dev *rt2x00dev)
#define RT2X00DEBUGFS_CREATE_REGISTER_ENTRY(__intf, __name) \
({ \
- if(debug->__name.read) { \
+ if (debug->__name.read) { \
(__intf)->__name##_off_entry = \
debugfs_create_u32(__stringify(__name) "_offset", \
S_IRUSR | S_IWUSR, \
--
2.6.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 3/3] net: wireless: rt2x00: Space Required
2015-10-17 21:11 [PATCH 3/3] net: wireless: rt2x00: Space Required Paul McQuade
@ 2016-01-21 17:10 ` Helmut Schaa
0 siblings, 0 replies; 3+ messages in thread
From: Helmut Schaa @ 2016-01-21 17:10 UTC (permalink / raw)
To: Paul McQuade; +Cc: Stanislaw Gruszka, kvalo, linux-wireless, netdev, LKML
On Sat, Oct 17, 2015 at 11:11 PM, Paul McQuade <paulmcquad@gmail.com> wrote:
> Space needed before open parenthesis
>
> Signed-off-by: Paul McQuade <paulmcquad@gmail.com>
Looks valid to me.
Acked-by: Helmut Schaa <helmut.schaa@googlemail.com>
> ---
> drivers/net/wireless/rt2x00/rt2x00debug.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2x00debug.c b/drivers/net/wireless/rt2x00/rt2x00debug.c
> index 90fdb02..25ee3cb 100644
> --- a/drivers/net/wireless/rt2x00/rt2x00debug.c
> +++ b/drivers/net/wireless/rt2x00/rt2x00debug.c
> @@ -629,7 +629,7 @@ static struct dentry *rt2x00debug_create_file_chipset(const char *name,
> data += sprintf(data, "register\tbase\twords\twordsize\n");
> #define RT2X00DEBUGFS_SPRINTF_REGISTER(__name) \
> { \
> - if(debug->__name.read) \
> + if (debug->__name.read) \
> data += sprintf(data, __stringify(__name) \
> "\t%d\t%d\t%d\n", \
> debug->__name.word_base, \
> @@ -699,7 +699,7 @@ void rt2x00debug_register(struct rt2x00_dev *rt2x00dev)
>
> #define RT2X00DEBUGFS_CREATE_REGISTER_ENTRY(__intf, __name) \
> ({ \
> - if(debug->__name.read) { \
> + if (debug->__name.read) { \
> (__intf)->__name##_off_entry = \
> debugfs_create_u32(__stringify(__name) "_offset", \
> S_IRUSR | S_IWUSR, \
> --
> 2.6.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 3/3] net: wireless: rt2x00: Space Required
2015-10-17 21:06 [PATCH 1/3] net: wireless: rt2x00: Space issue Paul McQuade
@ 2015-10-17 21:06 ` Paul McQuade
0 siblings, 0 replies; 3+ messages in thread
From: Paul McQuade @ 2015-10-17 21:06 UTC (permalink / raw)
To: paulmcquad
Cc: sgruszka, helmut.schaa, kvalo, linux-wireless, netdev,
linux-kernel, Paul McQuade
Space needed before open parenthesis
Signed-off-by: Paul McQuade <paulmcquad@gmail.com>#
---
drivers/net/wireless/rt2x00/rt2x00debug.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/rt2x00/rt2x00debug.c b/drivers/net/wireless/rt2x00/rt2x00debug.c
index 90fdb02..25ee3cb 100644
--- a/drivers/net/wireless/rt2x00/rt2x00debug.c
+++ b/drivers/net/wireless/rt2x00/rt2x00debug.c
@@ -629,7 +629,7 @@ static struct dentry *rt2x00debug_create_file_chipset(const char *name,
data += sprintf(data, "register\tbase\twords\twordsize\n");
#define RT2X00DEBUGFS_SPRINTF_REGISTER(__name) \
{ \
- if(debug->__name.read) \
+ if (debug->__name.read) \
data += sprintf(data, __stringify(__name) \
"\t%d\t%d\t%d\n", \
debug->__name.word_base, \
@@ -699,7 +699,7 @@ void rt2x00debug_register(struct rt2x00_dev *rt2x00dev)
#define RT2X00DEBUGFS_CREATE_REGISTER_ENTRY(__intf, __name) \
({ \
- if(debug->__name.read) { \
+ if (debug->__name.read) { \
(__intf)->__name##_off_entry = \
debugfs_create_u32(__stringify(__name) "_offset", \
S_IRUSR | S_IWUSR, \
--
2.6.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-01-21 17:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-17 21:11 [PATCH 3/3] net: wireless: rt2x00: Space Required Paul McQuade
2016-01-21 17:10 ` Helmut Schaa
-- strict thread matches above, loose matches on Subject: below --
2015-10-17 21:06 [PATCH 1/3] net: wireless: rt2x00: Space issue Paul McQuade
2015-10-17 21:06 ` [PATCH 3/3] net: wireless: rt2x00: Space Required Paul McQuade
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).