From: Eric Dumazet <eric.dumazet@gmail.com>
To: Haiyang Zhang <haiyangz@microsoft.com>
Cc: "edumazet@google.com" <edumazet@google.com>,
David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
KY Srinivasan <kys@microsoft.com>
Subject: Re: [patch] tcp: attach SYNACK messages to request sockets instead of listener
Date: Fri, 30 Oct 2015 13:18:51 -0700 [thread overview]
Message-ID: <1446236331.6254.36.camel@edumazet-glaptop2.roam.corp.google.com> (raw)
In-Reply-To: <1446235356.6254.33.camel@edumazet-glaptop2.roam.corp.google.com>
On Fri, 2015-10-30 at 13:02 -0700, Eric Dumazet wrote:
> So it looks like you have a device with a very big hh_len
>
> MAX_TCP_HEADER is not enough space to hold all headers, and this is the
> bug that needs to be fixed. This is scary to realloc all tcp packets !
>
drivers/net/hyperv/netvsc_drv.c sets a needed_headroom of 220 bytes :(
Could you try :
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 4ac653b7b8ac..7dbdd29076be 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -132,8 +132,10 @@ static inline bool dev_xmit_complete(int rc)
* used.
*/
-#if defined(CONFIG_WLAN) || IS_ENABLED(CONFIG_AX25)
-# if defined(CONFIG_MAC80211_MESH)
+#if defined(CONFIG_WLAN) || IS_ENABLED(CONFIG_AX25) || IS_ENABLED(CONFIG_HYPERV_NET)
+# if IS_ENABLED(CONFIG_HYPERV_NET)
+# define LL_MAX_HEADER 384
+# elif defined(CONFIG_MAC80211_MESH)
# define LL_MAX_HEADER 128
# else
# define LL_MAX_HEADER 96
next prev parent reply other threads:[~2015-10-30 20:18 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-29 21:49 [patch] tcp: attach SYNACK messages to request sockets instead of listener Haiyang Zhang
2015-10-29 22:58 ` Eric Dumazet
2015-10-30 19:38 ` Haiyang Zhang
2015-10-30 20:02 ` Eric Dumazet
2015-10-30 20:18 ` Eric Dumazet [this message]
2015-10-30 21:42 ` Haiyang Zhang
2015-10-30 23:52 ` Eric Dumazet
2015-11-01 17:20 ` [PATCH net-next] net: increase LL_MAX_HEADER if HYPERV_NET is enabled Eric Dumazet
2015-11-01 20:58 ` David Miller
2015-11-01 22:36 ` Eric Dumazet
2015-11-01 22:58 ` [PATCH net-next] net: make skb_set_owner_w() more robust Eric Dumazet
2015-11-01 23:18 ` kbuild test robot
2015-11-01 23:27 ` Eric Dumazet
2015-11-01 23:36 ` [PATCH v2 " Eric Dumazet
2015-11-02 20:05 ` Haiyang Zhang
2015-11-02 20:09 ` Eric Dumazet
2015-11-02 20:26 ` David Miller
2015-11-02 21:29 ` David Miller
2015-11-03 7:59 ` [PATCH net-next] net: increase LL_MAX_HEADER if HYPERV_NET is enabled KY Srinivasan
2015-11-03 15:33 ` David Miller
2015-11-03 16:37 ` Eric Dumazet
2015-11-03 17:34 ` Haiyang Zhang
2015-11-03 18:20 ` David Miller
2015-11-03 18:49 ` Haiyang Zhang
2015-11-03 19:50 ` David Miller
2015-11-03 21:00 ` Haiyang Zhang
2015-11-03 18:09 ` KY Srinivasan
2015-10-30 20:28 ` [patch] tcp: attach SYNACK messages to request sockets instead of listener KY Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446236331.6254.36.camel@edumazet-glaptop2.roam.corp.google.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).