* [PATCH iproute2 1/1] tc classifiers: Modernize tcindex classifier
@ 2016-08-17 11:16 Jamal Hadi Salim
2016-08-18 21:57 ` Stephen Hemminger
0 siblings, 1 reply; 3+ messages in thread
From: Jamal Hadi Salim @ 2016-08-17 11:16 UTC (permalink / raw)
To: stephen; +Cc: netdev, Jamal Hadi Salim
From: Jamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
---
tc/f_tcindex.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tc/f_tcindex.c b/tc/f_tcindex.c
index 280d1d4..0a73784 100644
--- a/tc/f_tcindex.c
+++ b/tc/f_tcindex.c
@@ -99,7 +99,7 @@ static int tcindex_parse_opt(struct filter_util *qu, char *handle, int argc,
continue;
} else if (!strcmp(*argv,"action")) {
NEXT_ARG();
- if (parse_police(&argc, &argv, TCA_TCINDEX_ACT, n)) {
+ if (parse_action(&argc, &argv, TCA_TCINDEX_ACT, n)) {
fprintf(stderr, "Illegal \"action\"\n");
return -1;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH iproute2 1/1] tc classifiers: Modernize tcindex classifier
2016-08-17 11:16 [PATCH iproute2 1/1] tc classifiers: Modernize tcindex classifier Jamal Hadi Salim
@ 2016-08-18 21:57 ` Stephen Hemminger
2016-08-22 11:12 ` Jamal Hadi Salim
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Hemminger @ 2016-08-18 21:57 UTC (permalink / raw)
To: Jamal Hadi Salim; +Cc: netdev
On Wed, 17 Aug 2016 07:16:53 -0400
Jamal Hadi Salim <jhs@mojatatu.com> wrote:
> From: Jamal Hadi Salim <jhs@mojatatu.com>
>
> Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
> ---
The is ok for the parsing of config, but you are still using print_police
for display.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH iproute2 1/1] tc classifiers: Modernize tcindex classifier
2016-08-18 21:57 ` Stephen Hemminger
@ 2016-08-22 11:12 ` Jamal Hadi Salim
0 siblings, 0 replies; 3+ messages in thread
From: Jamal Hadi Salim @ 2016-08-22 11:12 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: netdev
On 16-08-18 05:57 PM, Stephen Hemminger wrote:
> The is ok for the parsing of config, but you are still using print_police
> for display.
Thanks for catching that. I will send a v2.
cheers,
jamal
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-08-22 11:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-17 11:16 [PATCH iproute2 1/1] tc classifiers: Modernize tcindex classifier Jamal Hadi Salim
2016-08-18 21:57 ` Stephen Hemminger
2016-08-22 11:12 ` Jamal Hadi Salim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).