* [PATCH 0/4] STM32F429: Add Ethernet fixes
@ 2016-10-20 15:21 Alexandre TORGUE
[not found] ` <1476976886-23781-1-git-send-email-alexandre.torgue-qxv4g6HH51o@public.gmane.org>
2016-10-20 15:21 ` [PATCH 3/4] ARM: dts: stm32f429: Fix Ethernet node on Eval Board Alexandre TORGUE
0 siblings, 2 replies; 7+ messages in thread
From: Alexandre TORGUE @ 2016-10-20 15:21 UTC (permalink / raw)
To: peppe.cavallaro, Maxime Coquelin, arnd, robh
Cc: netdev, linux-arm-kernel, devicetree
This series adds several fixes for Ethernet for stm32f429 MCU.
First 2 patches have already been reviewed some months ago when
stm32 Ethernet glue has been pushed (I added in this series to keep
history). Fixes are:
-Change DT to be compliant to stm32 ethernet glue binding
-Add phy-handle to correctly use mdio subnode
-Remove WoL support
Regards
Alex
Alexandre TORGUE (4):
ARM: dts: stm32f429: Align Ethernet node with new bindings properties
ARM: dts: stm32f429: Update Ethernet node on Eval board
ARM: dts: stm32f429: Fix Ethernet node on Eval Board
ARM: dts: stm32f429: remove Ethernet wake on Lan support
arch/arm/boot/dts/stm32429i-eval.dts | 7 ++++---
arch/arm/boot/dts/stm32f429.dtsi | 10 +++++-----
2 files changed, 9 insertions(+), 8 deletions(-)
--
1.9.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/4] ARM: dts: stm32f429: Align Ethernet node with new bindings properties
[not found] ` <1476976886-23781-1-git-send-email-alexandre.torgue-qxv4g6HH51o@public.gmane.org>
@ 2016-10-20 15:21 ` Alexandre TORGUE
2016-10-20 15:21 ` [PATCH 2/4] ARM: dts: stm32f429: Update Ethernet node on Eval board Alexandre TORGUE
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Alexandre TORGUE @ 2016-10-20 15:21 UTC (permalink / raw)
To: peppe.cavallaro-qxv4g6HH51o, Maxime Coquelin, arnd-r2nGTMty4D4,
robh-DgEjT+Ai2ygdnm+yROfE0A
Cc: netdev-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA
This patch aligns clocks names and node reference according to new
stm32-dwmac glue binding. It also renames Ethernet pinctrl phandle
(indeed there is no need to add 0 as Ethernet instance as there is only
one IP in SOC).
Signed-off-by: Alexandre TORGUE <alexandre.torgue-qxv4g6HH51o@public.gmane.org>
diff --git a/arch/arm/boot/dts/stm32f429.dtsi b/arch/arm/boot/dts/stm32f429.dtsi
index 336ee4f..6350117b 100644
--- a/arch/arm/boot/dts/stm32f429.dtsi
+++ b/arch/arm/boot/dts/stm32f429.dtsi
@@ -313,7 +313,7 @@
};
};
- ethernet0_mii: mii@0 {
+ ethernet_mii: mii@0 {
pins {
pinmux = <STM32F429_PG13_FUNC_ETH_MII_TXD0_ETH_RMII_TXD0>,
<STM32F429_PG14_FUNC_ETH_MII_TXD1_ETH_RMII_TXD1>,
@@ -373,13 +373,13 @@
st,mem2mem;
};
- ethernet0: dwmac@40028000 {
+ mac: ethernet@40028000 {
compatible = "st,stm32-dwmac", "snps,dwmac-3.50a";
reg = <0x40028000 0x8000>;
reg-names = "stmmaceth";
interrupts = <61>, <62>;
interrupt-names = "macirq", "eth_wake_irq";
- clock-names = "stmmaceth", "tx-clk", "rx-clk";
+ clock-names = "stmmaceth", "mac-clk-tx", "mac-clk-rx";
clocks = <&rcc 0 25>, <&rcc 0 26>, <&rcc 0 27>;
st,syscon = <&syscfg 0x4>;
snps,pbl = <8>;
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/4] ARM: dts: stm32f429: Update Ethernet node on Eval board
[not found] ` <1476976886-23781-1-git-send-email-alexandre.torgue-qxv4g6HH51o@public.gmane.org>
2016-10-20 15:21 ` [PATCH 1/4] ARM: dts: stm32f429: Align Ethernet node with new bindings properties Alexandre TORGUE
@ 2016-10-20 15:21 ` Alexandre TORGUE
2016-10-20 15:21 ` [PATCH 4/4] ARM: dts: stm32f429: remove Ethernet wake on Lan support Alexandre TORGUE
2016-10-20 18:41 ` [PATCH 0/4] STM32F429: Add Ethernet fixes David Miller
3 siblings, 0 replies; 7+ messages in thread
From: Alexandre TORGUE @ 2016-10-20 15:21 UTC (permalink / raw)
To: peppe.cavallaro-qxv4g6HH51o, Maxime Coquelin, arnd-r2nGTMty4D4,
robh-DgEjT+Ai2ygdnm+yROfE0A
Cc: netdev-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA
Update new pinctrl phandle name and use new node name.
Signed-off-by: Alexandre TORGUE <alexandre.torgue-qxv4g6HH51o@public.gmane.org>
diff --git a/arch/arm/boot/dts/stm32429i-eval.dts b/arch/arm/boot/dts/stm32429i-eval.dts
index 13c7cd2..fa30bf1 100644
--- a/arch/arm/boot/dts/stm32429i-eval.dts
+++ b/arch/arm/boot/dts/stm32429i-eval.dts
@@ -94,11 +94,12 @@
clock-frequency = <25000000>;
};
-ðernet0 {
+&mac {
status = "okay";
- pinctrl-0 = <ðernet0_mii>;
+ pinctrl-0 = <ðernet_mii>;
pinctrl-names = "default";
- phy-mode = "mii-id";
+ phy-mode = "mii";
+
mdio0 {
#address-cells = <1>;
#size-cells = <0>;
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 3/4] ARM: dts: stm32f429: Fix Ethernet node on Eval Board
2016-10-20 15:21 [PATCH 0/4] STM32F429: Add Ethernet fixes Alexandre TORGUE
[not found] ` <1476976886-23781-1-git-send-email-alexandre.torgue-qxv4g6HH51o@public.gmane.org>
@ 2016-10-20 15:21 ` Alexandre TORGUE
1 sibling, 0 replies; 7+ messages in thread
From: Alexandre TORGUE @ 2016-10-20 15:21 UTC (permalink / raw)
To: peppe.cavallaro, Maxime Coquelin, arnd, robh
Cc: netdev, linux-arm-kernel, devicetree
"phy-handle" entry is mandatory when mdio subnode is used in
Ethernet node.
Signed-off-by: Alexandre TORGUE <alexandre.torgue@st.com>
diff --git a/arch/arm/boot/dts/stm32429i-eval.dts b/arch/arm/boot/dts/stm32429i-eval.dts
index fa30bf1..a11b108 100644
--- a/arch/arm/boot/dts/stm32429i-eval.dts
+++ b/arch/arm/boot/dts/stm32429i-eval.dts
@@ -99,7 +99,7 @@
pinctrl-0 = <ðernet_mii>;
pinctrl-names = "default";
phy-mode = "mii";
-
+ phy-handle = <&phy1>;
mdio0 {
#address-cells = <1>;
#size-cells = <0>;
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 4/4] ARM: dts: stm32f429: remove Ethernet wake on Lan support
[not found] ` <1476976886-23781-1-git-send-email-alexandre.torgue-qxv4g6HH51o@public.gmane.org>
2016-10-20 15:21 ` [PATCH 1/4] ARM: dts: stm32f429: Align Ethernet node with new bindings properties Alexandre TORGUE
2016-10-20 15:21 ` [PATCH 2/4] ARM: dts: stm32f429: Update Ethernet node on Eval board Alexandre TORGUE
@ 2016-10-20 15:21 ` Alexandre TORGUE
2016-10-20 18:41 ` [PATCH 0/4] STM32F429: Add Ethernet fixes David Miller
3 siblings, 0 replies; 7+ messages in thread
From: Alexandre TORGUE @ 2016-10-20 15:21 UTC (permalink / raw)
To: peppe.cavallaro-qxv4g6HH51o, Maxime Coquelin, arnd-r2nGTMty4D4,
robh-DgEjT+Ai2ygdnm+yROfE0A
Cc: netdev-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA
This patch removes WoL (Wake on Lan) support as it is not yet
fully supported and tested.
Signed-off-by: Alexandre TORGUE <alexandre.torgue-qxv4g6HH51o@public.gmane.org>
diff --git a/arch/arm/boot/dts/stm32f429.dtsi b/arch/arm/boot/dts/stm32f429.dtsi
index 6350117b..ad0bc6a 100644
--- a/arch/arm/boot/dts/stm32f429.dtsi
+++ b/arch/arm/boot/dts/stm32f429.dtsi
@@ -377,8 +377,8 @@
compatible = "st,stm32-dwmac", "snps,dwmac-3.50a";
reg = <0x40028000 0x8000>;
reg-names = "stmmaceth";
- interrupts = <61>, <62>;
- interrupt-names = "macirq", "eth_wake_irq";
+ interrupts = <61>;
+ interrupt-names = "macirq";
clock-names = "stmmaceth", "mac-clk-tx", "mac-clk-rx";
clocks = <&rcc 0 25>, <&rcc 0 26>, <&rcc 0 27>;
st,syscon = <&syscfg 0x4>;
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 0/4] STM32F429: Add Ethernet fixes
[not found] ` <1476976886-23781-1-git-send-email-alexandre.torgue-qxv4g6HH51o@public.gmane.org>
` (2 preceding siblings ...)
2016-10-20 15:21 ` [PATCH 4/4] ARM: dts: stm32f429: remove Ethernet wake on Lan support Alexandre TORGUE
@ 2016-10-20 18:41 ` David Miller
[not found] ` <20161020.144140.1794871934594140769.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
3 siblings, 1 reply; 7+ messages in thread
From: David Miller @ 2016-10-20 18:41 UTC (permalink / raw)
To: alexandre.torgue-qxv4g6HH51o
Cc: peppe.cavallaro-qxv4g6HH51o,
mcoquelin.stm32-Re5JQEeQqe8AvxtiuMwx3w, arnd-r2nGTMty4D4,
robh-DgEjT+Ai2ygdnm+yROfE0A, netdev-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA
From: Alexandre TORGUE <alexandre.torgue-qxv4g6HH51o@public.gmane.org>
Date: Thu, 20 Oct 2016 17:21:22 +0200
> This series adds several fixes for Ethernet for stm32f429 MCU.
> First 2 patches have already been reviewed some months ago when
> stm32 Ethernet glue has been pushed (I added in this series to keep
> history). Fixes are:
> -Change DT to be compliant to stm32 ethernet glue binding
> -Add phy-handle to correctly use mdio subnode
> -Remove WoL support
I'm assuming this will be merged via the ARM tree.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 0/4] STM32F429: Add Ethernet fixes
[not found] ` <20161020.144140.1794871934594140769.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
@ 2016-10-24 7:30 ` Alexandre Torgue
0 siblings, 0 replies; 7+ messages in thread
From: Alexandre Torgue @ 2016-10-24 7:30 UTC (permalink / raw)
To: David Miller
Cc: peppe.cavallaro-qxv4g6HH51o,
mcoquelin.stm32-Re5JQEeQqe8AvxtiuMwx3w, arnd-r2nGTMty4D4,
robh-DgEjT+Ai2ygdnm+yROfE0A, netdev-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA
Hi David,
On 10/20/2016 08:41 PM, David Miller wrote:
> From: Alexandre TORGUE <alexandre.torgue-qxv4g6HH51o@public.gmane.org>
> Date: Thu, 20 Oct 2016 17:21:22 +0200
>
>> This series adds several fixes for Ethernet for stm32f429 MCU.
>> First 2 patches have already been reviewed some months ago when
>> stm32 Ethernet glue has been pushed (I added in this series to keep
>> history). Fixes are:
>> -Change DT to be compliant to stm32 ethernet glue binding
>> -Add phy-handle to correctly use mdio subnode
>> -Remove WoL support
>
> I'm assuming this will be merged via the ARM tree.
Yes, I will take it in my next pull request (if no issues).
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-10-24 7:30 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-20 15:21 [PATCH 0/4] STM32F429: Add Ethernet fixes Alexandre TORGUE
[not found] ` <1476976886-23781-1-git-send-email-alexandre.torgue-qxv4g6HH51o@public.gmane.org>
2016-10-20 15:21 ` [PATCH 1/4] ARM: dts: stm32f429: Align Ethernet node with new bindings properties Alexandre TORGUE
2016-10-20 15:21 ` [PATCH 2/4] ARM: dts: stm32f429: Update Ethernet node on Eval board Alexandre TORGUE
2016-10-20 15:21 ` [PATCH 4/4] ARM: dts: stm32f429: remove Ethernet wake on Lan support Alexandre TORGUE
2016-10-20 18:41 ` [PATCH 0/4] STM32F429: Add Ethernet fixes David Miller
[not found] ` <20161020.144140.1794871934594140769.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2016-10-24 7:30 ` Alexandre Torgue
2016-10-20 15:21 ` [PATCH 3/4] ARM: dts: stm32f429: Fix Ethernet node on Eval Board Alexandre TORGUE
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).