netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Andrei Vagin <avagin@gmail.com>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
	Paolo Abeni <pabeni@redhat.com>
Subject: Re: linux-next: BUG: unable to handle kernel NULL pointer dereference in __sk_mem_raise_allocated()
Date: Mon, 14 Nov 2016 15:49:15 -0800	[thread overview]
Message-ID: <1479167355.8455.93.camel@edumazet-glaptop3.roam.corp.google.com> (raw)
In-Reply-To: <1479166501.8455.91.camel@edumazet-glaptop3.roam.corp.google.com>

On Mon, 2016-11-14 at 15:35 -0800, Eric Dumazet wrote:

> 
> Thanks for the report.
> 
> I guess following patch would be needed ?
> 
> diff --git a/net/ipv4/udplite.c b/net/ipv4/udplite.c
> index af817158d830c0da080935ba29e012dffbb89112..12604c0371c451efcc9aad278bb86be9ac4bb813 100644
> --- a/net/ipv4/udplite.c
> +++ b/net/ipv4/udplite.c
> @@ -54,6 +54,7 @@ struct proto 	udplite_prot = {
>  	.hash		   = udp_lib_hash,
>  	.unhash		   = udp_lib_unhash,
>  	.get_port	   = udp_v4_get_port,
> +	.memory_allocated  = &udp_memory_allocated,
>  	.obj_size	   = sizeof(struct udp_sock),
>  	.h.udp_table	   = &udplite_table,
>  #ifdef CONFIG_COMPAT
> diff --git a/net/ipv6/udplite.c b/net/ipv6/udplite.c
> index 47d0d2b87106558fece3496479198005c55b99e7..946025c888cc9519fb3523edbbe8afbb18273326 100644
> --- a/net/ipv6/udplite.c
> +++ b/net/ipv6/udplite.c
> @@ -49,6 +49,7 @@ struct proto udplitev6_prot = {
>  	.hash		   = udp_lib_hash,
>  	.unhash		   = udp_lib_unhash,
>  	.get_port	   = udp_v6_get_port,
> +	.memory_allocated  = &udp_memory_allocated,
>  	.obj_size	   = sizeof(struct udp6_sock),
>  	.h.udp_table	   = &udplite_table,
>  #ifdef CONFIG_COMPAT
> 

.sysctl_mem also needs to be set.

  reply	other threads:[~2016-11-14 23:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-14 23:24 linux-next: BUG: unable to handle kernel NULL pointer dereference in __sk_mem_raise_allocated() Andrei Vagin
2016-11-14 23:35 ` Eric Dumazet
2016-11-14 23:49   ` Eric Dumazet [this message]
2016-11-14 23:58   ` Andrei Vagin
2016-11-15  0:31     ` Eric Dumazet
2016-11-15  8:57       ` Paolo Abeni
2016-11-15  0:02 ` Andrei Vagin
2016-11-15  9:26 ` Paolo Abeni
2016-11-15 14:02   ` Eric Dumazet
2016-11-15 14:07     ` Paolo Abeni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1479167355.8455.93.camel@edumazet-glaptop3.roam.corp.google.com \
    --to=eric.dumazet@gmail.com \
    --cc=avagin@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).