netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Andrei Vagin <avagin@gmail.com>,
	Linux Kernel Network Developers <netdev@vger.kernel.org>
Subject: Re: linux-next: BUG: unable to handle kernel NULL pointer dereference in __sk_mem_raise_allocated()
Date: Tue, 15 Nov 2016 09:57:19 +0100	[thread overview]
Message-ID: <1479200239.4660.3.camel@redhat.com> (raw)
In-Reply-To: <1479169886.8455.111.camel@edumazet-glaptop3.roam.corp.google.com>

On Mon, 2016-11-14 at 16:31 -0800, Eric Dumazet wrote:
> On Mon, 2016-11-14 at 15:58 -0800, Andrei Vagin wrote:
> 
> > 
> > Yes, you are right. It works if we set .memory_allocated and .sysctl_mem.
> 
> Now the question would be :
> 
> Are we okay if UDP and UDPlite share the same limits ?
> 
> I would vote for yes, because these default limits are huge anyway
> (The 50% reduction done in
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=b66e91ccbc34ebd5a2f90f9e1bc1597e2924a500
> only impacted TCP )

Thank you for jumping on this so early!

I'm sorry for the udplite left over: my fault.

I agree with sharing the limits between UDP and UDPlite. I think that
the current ones are so high we can apply also a similar reduction to
UDP (and SCTP, too)

Cheers,

Paolo

  reply	other threads:[~2016-11-15  8:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-14 23:24 linux-next: BUG: unable to handle kernel NULL pointer dereference in __sk_mem_raise_allocated() Andrei Vagin
2016-11-14 23:35 ` Eric Dumazet
2016-11-14 23:49   ` Eric Dumazet
2016-11-14 23:58   ` Andrei Vagin
2016-11-15  0:31     ` Eric Dumazet
2016-11-15  8:57       ` Paolo Abeni [this message]
2016-11-15  0:02 ` Andrei Vagin
2016-11-15  9:26 ` Paolo Abeni
2016-11-15 14:02   ` Eric Dumazet
2016-11-15 14:07     ` Paolo Abeni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1479200239.4660.3.camel@redhat.com \
    --to=pabeni@redhat.com \
    --cc=avagin@gmail.com \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).