netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net] net: skb_flow_get_be16() can be static
@ 2017-01-09 19:18 Eric Dumazet
  2017-01-10 18:31 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Eric Dumazet @ 2017-01-09 19:18 UTC (permalink / raw)
  To: David Miller; +Cc: netdev

From: Eric Dumazet <edumazet@google.com>

Removes following sparse complain :

net/core/flow_dissector.c:70:8: warning: symbol 'skb_flow_get_be16'
was not declared. Should it be static?

Fixes: 972d3876faa8 ("flow dissector: ICMP support")
Signed-off-by: Eric Dumazet <edumazet@google.com>
---
 net/core/flow_dissector.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c
index fe4e1531976c3a36127b6ad4af33f24534af4c52..1b7673aac59d51a5f8b5ef3f2076f1440c017fae 100644
--- a/net/core/flow_dissector.c
+++ b/net/core/flow_dissector.c
@@ -67,8 +67,8 @@ EXPORT_SYMBOL(skb_flow_dissector_init);
  * The function will try to retrieve a be32 entity at
  * offset poff
  */
-__be16 skb_flow_get_be16(const struct sk_buff *skb, int poff, void *data,
-			 int hlen)
+static __be16 skb_flow_get_be16(const struct sk_buff *skb, int poff,
+				void *data, int hlen)
 {
 	__be16 *u, _u;
 

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net] net: skb_flow_get_be16() can be static
  2017-01-09 19:18 [PATCH net] net: skb_flow_get_be16() can be static Eric Dumazet
@ 2017-01-10 18:31 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-01-10 18:31 UTC (permalink / raw)
  To: eric.dumazet; +Cc: netdev

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 09 Jan 2017 11:18:01 -0800

> From: Eric Dumazet <edumazet@google.com>
> 
> Removes following sparse complain :
> 
> net/core/flow_dissector.c:70:8: warning: symbol 'skb_flow_get_be16'
> was not declared. Should it be static?
> 
> Fixes: 972d3876faa8 ("flow dissector: ICMP support")
> Signed-off-by: Eric Dumazet <edumazet@google.com>

Applied.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-01-10 18:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-09 19:18 [PATCH net] net: skb_flow_get_be16() can be static Eric Dumazet
2017-01-10 18:31 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).