netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Make IP 'forwarding' doc more precise
@ 2017-03-10 12:24 Neil Jerram
  2017-03-13  6:29 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Neil Jerram @ 2017-03-10 12:24 UTC (permalink / raw)
  To: netdev; +Cc: Neil Jerram

It wasn't clear if the 'forwarding' setting needs to be enabled on the
interface that packets are received from, or on the interface that
packets are forwarded to, or both.

In fact (according to my code reading) the setting is relevant on the
interface that packets are received from, so this change updates the doc
to say that.

Signed-off-by: Neil Jerram <neil@tigera.io>
---
 Documentation/networking/ip-sysctl.txt | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt
index fc73eeb..ab02304 100644
--- a/Documentation/networking/ip-sysctl.txt
+++ b/Documentation/networking/ip-sysctl.txt
@@ -1006,7 +1006,8 @@ accept_redirects - BOOLEAN
 		FALSE (router)
 
 forwarding - BOOLEAN
-	Enable IP forwarding on this interface.
+	Enable IP forwarding on this interface.  This controls whether packets
+	received _on_ this interface can be forwarded.
 
 mc_forwarding - BOOLEAN
 	Do multicast routing. The kernel needs to be compiled with CONFIG_MROUTE
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Make IP 'forwarding' doc more precise
  2017-03-10 12:24 [PATCH] Make IP 'forwarding' doc more precise Neil Jerram
@ 2017-03-13  6:29 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-03-13  6:29 UTC (permalink / raw)
  To: neil; +Cc: netdev

From: Neil Jerram <neil@tigera.io>
Date: Fri, 10 Mar 2017 12:24:57 +0000

> It wasn't clear if the 'forwarding' setting needs to be enabled on the
> interface that packets are received from, or on the interface that
> packets are forwarded to, or both.
> 
> In fact (according to my code reading) the setting is relevant on the
> interface that packets are received from, so this change updates the doc
> to say that.
> 
> Signed-off-by: Neil Jerram <neil@tigera.io>

Applied.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-03-13  6:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-10 12:24 [PATCH] Make IP 'forwarding' doc more precise Neil Jerram
2017-03-13  6:29 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).