* [PATCHv3 1/2] ethtool: stmmac: Add macros for number of registers
@ 2017-07-07 14:08 thor.thayer
2017-07-07 14:08 ` [PATCHv3 2/2] ethtool: stmmac: Add DMA HW Feature Register thor.thayer
0 siblings, 1 reply; 2+ messages in thread
From: thor.thayer @ 2017-07-07 14:08 UTC (permalink / raw)
To: linville, peppe.cavallaro; +Cc: netdev, thor.thayer
From: Thor Thayer <thor.thayer@linux.intel.com>
This patch adds macros for the number of registers to
loop through to make the code easier to read.
Signed-off-by: Thor Thayer <thor.thayer@linux.intel.com>
---
v2 New commit. Add macros for number of registers.
v3 Only add macros - remove DMA indexing.
---
stmmac.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/stmmac.c b/stmmac.c
index fb69bfe..23ed31a 100644
--- a/stmmac.c
+++ b/stmmac.c
@@ -14,6 +14,10 @@
#include <string.h>
#include "internal.h"
+#define MAC100_DMA_REG_NUM 9
+#define GMAC_REG_NUM 55
+#define GMAC_DMA_REG_NUM 22
+
int st_mac100_dump_regs(struct ethtool_drvinfo *info,
struct ethtool_regs *regs)
{
@@ -36,7 +40,7 @@ int st_mac100_dump_regs(struct ethtool_drvinfo *info,
fprintf(stdout, "\n");
fprintf(stdout, "DMA Registers\n");
- for (i = 0; i < 9; i++)
+ for (i = 0; i < MAC100_DMA_REG_NUM; i++)
fprintf(stdout, "CSR%d 0x%08X\n", i, *stmmac_reg++);
fprintf(stdout, "DMA cur tx buf addr 0x%08X\n", *stmmac_reg++);
@@ -54,12 +58,12 @@ int st_gmac_dump_regs(struct ethtool_drvinfo *info, struct ethtool_regs *regs)
fprintf(stdout, "ST GMAC Registers\n");
fprintf(stdout, "GMAC Registers\n");
- for (i = 0; i < 55; i++)
+ for (i = 0; i < GMAC_REG_NUM; i++)
fprintf(stdout, "Reg%d 0x%08X\n", i, *stmmac_reg++);
fprintf(stdout, "\n");
fprintf(stdout, "DMA Registers\n");
- for (i = 0; i < 22; i++)
+ for (i = 0; i < GMAC_DMA_REG_NUM; i++)
fprintf(stdout, "Reg%d 0x%08X\n", i, *stmmac_reg++);
return 0;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCHv3 2/2] ethtool: stmmac: Add DMA HW Feature Register
2017-07-07 14:08 [PATCHv3 1/2] ethtool: stmmac: Add macros for number of registers thor.thayer
@ 2017-07-07 14:08 ` thor.thayer
0 siblings, 0 replies; 2+ messages in thread
From: thor.thayer @ 2017-07-07 14:08 UTC (permalink / raw)
To: linville, peppe.cavallaro; +Cc: netdev, thor.thayer
From: Thor Thayer <thor.thayer@linux.intel.com>
This patch adds the DMA HW Feature Register which is at the end
of the DMA registers and is documented in Version 3.70a.
Signed-off-by: Thor Thayer <thor.thayer@linux.intel.com>
Acked-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
---
v2 Modify for MACRO changes and add Acked-by
v3 No change
---
stmmac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/stmmac.c b/stmmac.c
index 23ed31a..79ef151 100644
--- a/stmmac.c
+++ b/stmmac.c
@@ -16,7 +16,7 @@
#define MAC100_DMA_REG_NUM 9
#define GMAC_REG_NUM 55
-#define GMAC_DMA_REG_NUM 22
+#define GMAC_DMA_REG_NUM 23
int st_mac100_dump_regs(struct ethtool_drvinfo *info,
struct ethtool_regs *regs)
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-07 14:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-07 14:08 [PATCHv3 1/2] ethtool: stmmac: Add macros for number of registers thor.thayer
2017-07-07 14:08 ` [PATCHv3 2/2] ethtool: stmmac: Add DMA HW Feature Register thor.thayer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).