* [PATCH] net: ethernet: ti: netcp_core: no need in netif_napi_del
@ 2017-09-07 15:32 Ivan Khoronzhuk
2017-09-09 3:54 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Ivan Khoronzhuk @ 2017-09-07 15:32 UTC (permalink / raw)
To: w-kwok2, m-karicheri2, netdev
Cc: linux-kernel, grygorii.strashko, Ivan Khoronzhuk
Don't remove rx_napi specifically just before free_netdev(),
it's supposed to be done in it and is confusing w/o tx_napi deletion.
Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
---
Based on net-next/master
drivers/net/ethernet/ti/netcp_core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/ti/netcp_core.c b/drivers/net/ethernet/ti/netcp_core.c
index eb96a69..437d362 100644
--- a/drivers/net/ethernet/ti/netcp_core.c
+++ b/drivers/net/ethernet/ti/netcp_core.c
@@ -2145,7 +2145,6 @@ static void netcp_delete_interface(struct netcp_device *netcp_device,
of_node_put(netcp->node_interface);
unregister_netdev(ndev);
- netif_napi_del(&netcp->rx_napi);
free_netdev(ndev);
}
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: ethernet: ti: netcp_core: no need in netif_napi_del
2017-09-07 15:32 [PATCH] net: ethernet: ti: netcp_core: no need in netif_napi_del Ivan Khoronzhuk
@ 2017-09-09 3:54 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-09-09 3:54 UTC (permalink / raw)
To: ivan.khoronzhuk
Cc: w-kwok2, m-karicheri2, netdev, linux-kernel, grygorii.strashko
From: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
Date: Thu, 7 Sep 2017 18:32:30 +0300
> Don't remove rx_napi specifically just before free_netdev(),
> it's supposed to be done in it and is confusing w/o tx_napi deletion.
>
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-09 3:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-07 15:32 [PATCH] net: ethernet: ti: netcp_core: no need in netif_napi_del Ivan Khoronzhuk
2017-09-09 3:54 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).