* [PATCH net-next] net: bcmgenet: Avoid calling platform_device_put() twice in bcmgenet_mii_exit()
@ 2017-10-28 5:05 Wei Yongjun
2017-10-30 18:58 ` Doug Berger
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Wei Yongjun @ 2017-10-28 5:05 UTC (permalink / raw)
To: Doug Berger, Florian Fainelli; +Cc: Wei Yongjun, netdev
Remove platform_device_put() call after platform_device_unregister()
from function bcmgenet_mii_exit(), otherwise, we will call
platform_device_put() twice.
Fixes: 9a4e79697009 ("net: bcmgenet: utilize generic Broadcom UniMAC
MDIO controller driver")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/net/ethernet/broadcom/genet/bcmmii.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/genet/bcmmii.c b/drivers/net/ethernet/broadcom/genet/bcmmii.c
index ba3fcfd..5333274 100644
--- a/drivers/net/ethernet/broadcom/genet/bcmmii.c
+++ b/drivers/net/ethernet/broadcom/genet/bcmmii.c
@@ -571,5 +571,4 @@ void bcmgenet_mii_exit(struct net_device *dev)
of_phy_deregister_fixed_link(dn);
of_node_put(priv->phy_dn);
platform_device_unregister(priv->mii_pdev);
- platform_device_put(priv->mii_pdev);
}
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net-next] net: bcmgenet: Avoid calling platform_device_put() twice in bcmgenet_mii_exit()
2017-10-28 5:05 [PATCH net-next] net: bcmgenet: Avoid calling platform_device_put() twice in bcmgenet_mii_exit() Wei Yongjun
@ 2017-10-30 18:58 ` Doug Berger
2017-10-30 19:32 ` Florian Fainelli
2017-11-01 2:56 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Doug Berger @ 2017-10-30 18:58 UTC (permalink / raw)
To: Wei Yongjun, Florian Fainelli; +Cc: netdev
On 10/27/2017 10:05 PM, Wei Yongjun wrote:
> Remove platform_device_put() call after platform_device_unregister()
> from function bcmgenet_mii_exit(), otherwise, we will call
> platform_device_put() twice.
>
> Fixes: 9a4e79697009 ("net: bcmgenet: utilize generic Broadcom UniMAC
> MDIO controller driver")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/net/ethernet/broadcom/genet/bcmmii.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/broadcom/genet/bcmmii.c b/drivers/net/ethernet/broadcom/genet/bcmmii.c
> index ba3fcfd..5333274 100644
> --- a/drivers/net/ethernet/broadcom/genet/bcmmii.c
> +++ b/drivers/net/ethernet/broadcom/genet/bcmmii.c
> @@ -571,5 +571,4 @@ void bcmgenet_mii_exit(struct net_device *dev)
> of_phy_deregister_fixed_link(dn);
> of_node_put(priv->phy_dn);
> platform_device_unregister(priv->mii_pdev);
> - platform_device_put(priv->mii_pdev);
> }
>
Acked-by: Doug Berger <opendmb@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net-next] net: bcmgenet: Avoid calling platform_device_put() twice in bcmgenet_mii_exit()
2017-10-28 5:05 [PATCH net-next] net: bcmgenet: Avoid calling platform_device_put() twice in bcmgenet_mii_exit() Wei Yongjun
2017-10-30 18:58 ` Doug Berger
@ 2017-10-30 19:32 ` Florian Fainelli
2017-11-01 2:56 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2017-10-30 19:32 UTC (permalink / raw)
To: Wei Yongjun, Doug Berger; +Cc: netdev
On 10/27/2017 10:05 PM, Wei Yongjun wrote:
> Remove platform_device_put() call after platform_device_unregister()
> from function bcmgenet_mii_exit(), otherwise, we will call
> platform_device_put() twice.
>
> Fixes: 9a4e79697009 ("net: bcmgenet: utilize generic Broadcom UniMAC
> MDIO controller driver")
Please don't force a wrap to 80 columns for commit subjects.
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> drivers/net/ethernet/broadcom/genet/bcmmii.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/broadcom/genet/bcmmii.c b/drivers/net/ethernet/broadcom/genet/bcmmii.c
> index ba3fcfd..5333274 100644
> --- a/drivers/net/ethernet/broadcom/genet/bcmmii.c
> +++ b/drivers/net/ethernet/broadcom/genet/bcmmii.c
> @@ -571,5 +571,4 @@ void bcmgenet_mii_exit(struct net_device *dev)
> of_phy_deregister_fixed_link(dn);
> of_node_put(priv->phy_dn);
> platform_device_unregister(priv->mii_pdev);
> - platform_device_put(priv->mii_pdev);
> }
>
--
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net-next] net: bcmgenet: Avoid calling platform_device_put() twice in bcmgenet_mii_exit()
2017-10-28 5:05 [PATCH net-next] net: bcmgenet: Avoid calling platform_device_put() twice in bcmgenet_mii_exit() Wei Yongjun
2017-10-30 18:58 ` Doug Berger
2017-10-30 19:32 ` Florian Fainelli
@ 2017-11-01 2:56 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2017-11-01 2:56 UTC (permalink / raw)
To: weiyongjun1; +Cc: opendmb, f.fainelli, netdev
From: Wei Yongjun <weiyongjun1@huawei.com>
Date: Sat, 28 Oct 2017 05:05:46 +0000
> Remove platform_device_put() call after platform_device_unregister()
> from function bcmgenet_mii_exit(), otherwise, we will call
> platform_device_put() twice.
>
> Fixes: 9a4e79697009 ("net: bcmgenet: utilize generic Broadcom UniMAC
> MDIO controller driver")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-11-01 2:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-28 5:05 [PATCH net-next] net: bcmgenet: Avoid calling platform_device_put() twice in bcmgenet_mii_exit() Wei Yongjun
2017-10-30 18:58 ` Doug Berger
2017-10-30 19:32 ` Florian Fainelli
2017-11-01 2:56 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).