* [PATCH iproute2 v2 1/1] ip netns: use strtol() instead of atoi()
@ 2017-10-31 18:24 Roman Mashak
2017-11-01 21:06 ` Stephen Hemminger
0 siblings, 1 reply; 2+ messages in thread
From: Roman Mashak @ 2017-10-31 18:24 UTC (permalink / raw)
To: stephen; +Cc: netdev, jhs, Roman Mashak
Use strtol-based API to parse and validate integer input; atoi() does
not detect errors and may yield undefined behaviour if result can't be
represented.
v2: use get_unsigned() since network namespace is really an unsigned value.
Signed-off-by: Roman Mashak <mrv@mojatatu.com>
---
ip/ipnetns.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/ip/ipnetns.c b/ip/ipnetns.c
index afb4978..bad7933 100644
--- a/ip/ipnetns.c
+++ b/ip/ipnetns.c
@@ -700,7 +700,8 @@ static int netns_set(int argc, char **argv)
{
char netns_path[PATH_MAX];
const char *name;
- int netns, nsid;
+ unsigned int nsid;
+ int netns;
if (argc < 1) {
fprintf(stderr, "No netns name specified\n");
@@ -711,7 +712,8 @@ static int netns_set(int argc, char **argv)
return -1;
}
name = argv[0];
- nsid = atoi(argv[1]);
+ if (get_unsigned(&nsid, argv[1], 0))
+ invarg("Invalid \"netnsid\" value\n", argv[1]);
snprintf(netns_path, sizeof(netns_path), "%s/%s", NETNS_RUN_DIR, name);
netns = open(netns_path, O_RDONLY | O_CLOEXEC);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH iproute2 v2 1/1] ip netns: use strtol() instead of atoi()
2017-10-31 18:24 [PATCH iproute2 v2 1/1] ip netns: use strtol() instead of atoi() Roman Mashak
@ 2017-11-01 21:06 ` Stephen Hemminger
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Hemminger @ 2017-11-01 21:06 UTC (permalink / raw)
To: Roman Mashak; +Cc: netdev, jhs
On Tue, 31 Oct 2017 14:24:19 -0400
Roman Mashak <mrv@mojatatu.com> wrote:
> Use strtol-based API to parse and validate integer input; atoi() does
> not detect errors and may yield undefined behaviour if result can't be
> represented.
>
> v2: use get_unsigned() since network namespace is really an unsigned value.
>
> Signed-off-by: Roman Mashak <mrv@mojatatu.com>
Applied. Thanks Roman
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-01 21:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-31 18:24 [PATCH iproute2 v2 1/1] ip netns: use strtol() instead of atoi() Roman Mashak
2017-11-01 21:06 ` Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).