* [PATCH net-next can] Converting pernet_operations (part #9)
@ 2018-03-19 11:38 Kirill Tkhai
2018-03-19 11:39 ` [PATCH net-next] net: Convert can_pernet_ops Kirill Tkhai
0 siblings, 1 reply; 3+ messages in thread
From: Kirill Tkhai @ 2018-03-19 11:38 UTC (permalink / raw)
To: davem, socketcan, mkl, linux-can, netdev, ktkhai
Hi,
this series continues to review and to convert pernet_operations
to make them possible to be executed in parallel for several
net namespaces at the same time. There is only one patch converting
can_pernet_ops.
Thanks,
Kirill
---
Kirill Tkhai (1):
net: Convert can_pernet_ops
net/can/af_can.c | 1 +
1 file changed, 1 insertion(+)
--
Signed-off-by: Kirill Tkhai <ktkhai@virtuozzo.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH net-next] net: Convert can_pernet_ops
2018-03-19 11:38 [PATCH net-next can] Converting pernet_operations (part #9) Kirill Tkhai
@ 2018-03-19 11:39 ` Kirill Tkhai
2018-03-22 15:14 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Kirill Tkhai @ 2018-03-19 11:39 UTC (permalink / raw)
To: davem, socketcan, mkl, linux-can, netdev, ktkhai
These pernet_operations create and destroy /proc entries
and cancel per-net timer.
Also, there are unneed iterations over empty list of net
devices, since all net devices must be already moved
to init_net or unregistered by default_device_ops. This
already was mentioned here:
https://marc.info/?l=linux-can&m=150169589119335&w=2
So, it looks safe to make them async.
Signed-off-by: Kirill Tkhai <ktkhai@virtuozzo.com>
---
net/can/af_can.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/can/af_can.c b/net/can/af_can.c
index 6da324550eec..e899970398a1 100644
--- a/net/can/af_can.c
+++ b/net/can/af_can.c
@@ -954,6 +954,7 @@ static struct notifier_block can_netdev_notifier __read_mostly = {
static struct pernet_operations can_pernet_ops __read_mostly = {
.init = can_pernet_init,
.exit = can_pernet_exit,
+ .async = true,
};
static __init int can_init(void)
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: Convert can_pernet_ops
2018-03-19 11:39 ` [PATCH net-next] net: Convert can_pernet_ops Kirill Tkhai
@ 2018-03-22 15:14 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2018-03-22 15:14 UTC (permalink / raw)
To: ktkhai; +Cc: socketcan, mkl, linux-can, netdev
From: Kirill Tkhai <ktkhai@virtuozzo.com>
Date: Mon, 19 Mar 2018 14:39:05 +0300
> These pernet_operations create and destroy /proc entries
> and cancel per-net timer.
>
> Also, there are unneed iterations over empty list of net
> devices, since all net devices must be already moved
> to init_net or unregistered by default_device_ops. This
> already was mentioned here:
>
> https://marc.info/?l=linux-can&m=150169589119335&w=2
>
> So, it looks safe to make them async.
>
> Signed-off-by: Kirill Tkhai <ktkhai@virtuozzo.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-22 15:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-19 11:38 [PATCH net-next can] Converting pernet_operations (part #9) Kirill Tkhai
2018-03-19 11:39 ` [PATCH net-next] net: Convert can_pernet_ops Kirill Tkhai
2018-03-22 15:14 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).