* [PATCH] brcm80211: remove redundant condition check before debugfs_remove_recursive
@ 2018-09-12 14:10 zhong jiang
2018-09-20 12:07 ` Kalle Valo
[not found] ` <20180920120709.5FE6960BF7@smtp.codeaurora.org>
0 siblings, 2 replies; 7+ messages in thread
From: zhong jiang @ 2018-09-12 14:10 UTC (permalink / raw)
To: kvalo-sgV2jX0FEOL9JmXXK+q4OQ, davem-fT/PcQaiUtIeIZ0/mPfg9Q
Cc: hante.meuleman-dY08KVG/lbpWk0Htik3J/w,
franky.lin-dY08KVG/lbpWk0Htik3J/w,
arend.vanspriel-dY08KVG/lbpWk0Htik3J/w,
linux-wireless-u79uwXL29TY76Z2rM5mHXA,
brcm80211-dev-list.pdl-dY08KVG/lbpWk0Htik3J/w,
netdev-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
debugfs_remove_recursive has taken IS_ERR_OR_NULL into account. So just
remove the condition check before debugfs_remove_recursive.
Signed-off-by: zhong jiang <zhongjiang-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
---
drivers/net/wireless/broadcom/brcm80211/brcmsmac/debug.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/debug.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/debug.c
index 2fe1f68..3bd54f1 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/debug.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/debug.c
@@ -62,8 +62,7 @@ int brcms_debugfs_attach(struct brcms_pub *drvr)
void brcms_debugfs_detach(struct brcms_pub *drvr)
{
- if (!IS_ERR_OR_NULL(drvr->dbgfs_dir))
- debugfs_remove_recursive(drvr->dbgfs_dir);
+ debugfs_remove_recursive(drvr->dbgfs_dir);
}
struct dentry *brcms_debugfs_get_devdir(struct brcms_pub *drvr)
--
1.7.12.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] brcm80211: remove redundant condition check before debugfs_remove_recursive
2018-09-12 14:10 [PATCH] brcm80211: remove redundant condition check before debugfs_remove_recursive zhong jiang
@ 2018-09-20 12:07 ` Kalle Valo
[not found] ` <20180920120709.5FE6960BF7@smtp.codeaurora.org>
1 sibling, 0 replies; 7+ messages in thread
From: Kalle Valo @ 2018-09-20 12:07 UTC (permalink / raw)
To: zhong jiang
Cc: davem, hante.meuleman, franky.lin, arend.vanspriel,
linux-wireless, brcm80211-dev-list.pdl, netdev, linux-kernel
zhong jiang <zhongjiang@huawei.com> wrote:
> debugfs_remove_recursive has taken IS_ERR_OR_NULL into account. So just
> remove the condition check before debugfs_remove_recursive.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
It seems you already submitted an identical patch four days earlier:
https://patchwork.kernel.org/patch/10593061/
Why the duplicate? Please ALWAYS add a changelog and increase the version number:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#changelog_missing
--
https://patchwork.kernel.org/patch/10597627/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] brcm80211: remove redundant condition check before debugfs_remove_recursive
[not found] ` <20180920120709.5FE6960BF7@smtp.codeaurora.org>
@ 2018-09-20 12:25 ` zhong jiang
2018-09-20 12:30 ` Kalle Valo
0 siblings, 1 reply; 7+ messages in thread
From: zhong jiang @ 2018-09-20 12:25 UTC (permalink / raw)
To: Kalle Valo
Cc: davem, hante.meuleman, franky.lin, arend.vanspriel,
linux-wireless, brcm80211-dev-list.pdl, netdev, linux-kernel
On 2018/9/20 20:07, Kalle Valo wrote:
> zhong jiang <zhongjiang@huawei.com> wrote:
>
>> debugfs_remove_recursive has taken IS_ERR_OR_NULL into account. So just
>> remove the condition check before debugfs_remove_recursive.
>>
>> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> It seems you already submitted an identical patch four days earlier:
>
> https://patchwork.kernel.org/patch/10593061/
>
> Why the duplicate? Please ALWAYS add a changelog and increase the version number:
I am sorry for that. Maybe I send the patch earlier, but I remeber I should forget to cc to
netdev@vger.kernel.org and LMLK. So I repost it. Plese ingore the current patch.
Sincerely,
zhong jiang
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#changelog_missing
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] brcm80211: remove redundant condition check before debugfs_remove_recursive
2018-09-20 12:25 ` zhong jiang
@ 2018-09-20 12:30 ` Kalle Valo
2018-09-20 12:37 ` zhong jiang
0 siblings, 1 reply; 7+ messages in thread
From: Kalle Valo @ 2018-09-20 12:30 UTC (permalink / raw)
To: zhong jiang
Cc: davem, hante.meuleman, franky.lin, arend.vanspriel,
linux-wireless, brcm80211-dev-list.pdl, netdev, linux-kernel
zhong jiang <zhongjiang@huawei.com> writes:
> On 2018/9/20 20:07, Kalle Valo wrote:
>> zhong jiang <zhongjiang@huawei.com> wrote:
>>
>>> debugfs_remove_recursive has taken IS_ERR_OR_NULL into account. So just
>>> remove the condition check before debugfs_remove_recursive.
>>>
>>> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
>> It seems you already submitted an identical patch four days earlier:
>>
>> https://patchwork.kernel.org/patch/10593061/
>>
>> Why the duplicate? Please ALWAYS add a changelog and increase the version number:
>
> I am sorry for that. Maybe I send the patch earlier, but I remeber I
> should forget to cc to
> netdev@vger.kernel.org and LMLK. So I repost it. Plese ingore the current patch.
Even then please increase the version number and mention in the change
log why you sent a new version. Otherwise you will make maintainers
confused and wasting time with asking what has changed.
--
Kalle Valo
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] brcm80211: remove redundant condition check before debugfs_remove_recursive
2018-09-20 12:30 ` Kalle Valo
@ 2018-09-20 12:37 ` zhong jiang
0 siblings, 0 replies; 7+ messages in thread
From: zhong jiang @ 2018-09-20 12:37 UTC (permalink / raw)
To: Kalle Valo
Cc: davem, hante.meuleman, franky.lin, arend.vanspriel,
linux-wireless, brcm80211-dev-list.pdl, netdev, linux-kernel
On 2018/9/20 20:30, Kalle Valo wrote:
> zhong jiang <zhongjiang@huawei.com> writes:
>
>> On 2018/9/20 20:07, Kalle Valo wrote:
>>> zhong jiang <zhongjiang@huawei.com> wrote:
>>>
>>>> debugfs_remove_recursive has taken IS_ERR_OR_NULL into account. So just
>>>> remove the condition check before debugfs_remove_recursive.
>>>>
>>>> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
>>> It seems you already submitted an identical patch four days earlier:
>>>
>>> https://patchwork.kernel.org/patch/10593061/
>>>
>>> Why the duplicate? Please ALWAYS add a changelog and increase the version number:
>> I am sorry for that. Maybe I send the patch earlier, but I remeber I
>> should forget to cc to
>> netdev@vger.kernel.org and LMLK. So I repost it. Plese ingore the current patch.
> Even then please increase the version number and mention in the change
> log why you sent a new version. Otherwise you will make maintainers
> confused and wasting time with asking what has changed.
>
Get it and will keep it in mind . Thanks
Sincerely,
zhong jiang
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] brcm80211: remove redundant condition check before debugfs_remove_recursive
2018-09-08 13:40 zhong jiang
@ 2018-09-20 12:10 ` Kalle Valo
0 siblings, 0 replies; 7+ messages in thread
From: Kalle Valo @ 2018-09-20 12:10 UTC (permalink / raw)
To: zhong jiang
Cc: davem, arend.vanspriel, franky.lin, hante.meuleman,
chi-hsien.lin, wright.feng, linux-wireless,
brcm80211-dev-list.pdl, netdev
zhong jiang <zhongjiang@huawei.com> wrote:
> debugfs_remove_recursive has taken IS_ERR_OR_NULL into account. So just
> remove the condition check before debugfs_remove_recursive.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Patch applied to wireless-drivers-next.git, thanks.
761cb7cdef1a brcm80211: remove redundant condition check before debugfs_remove_recursive
--
https://patchwork.kernel.org/patch/10593061/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] brcm80211: remove redundant condition check before debugfs_remove_recursive
@ 2018-09-08 13:40 zhong jiang
2018-09-20 12:10 ` Kalle Valo
0 siblings, 1 reply; 7+ messages in thread
From: zhong jiang @ 2018-09-08 13:40 UTC (permalink / raw)
To: davem, arend.vanspriel, franky.lin, hante.meuleman, kvalo
Cc: chi-hsien.lin, wright.feng, linux-wireless,
brcm80211-dev-list.pdl, netdev
debugfs_remove_recursive has taken IS_ERR_OR_NULL into account. So just
remove the condition check before debugfs_remove_recursive.
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
drivers/net/wireless/broadcom/brcm80211/brcmsmac/debug.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/debug.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/debug.c
index 2fe1f68..3bd54f1 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/debug.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/debug.c
@@ -62,8 +62,7 @@ int brcms_debugfs_attach(struct brcms_pub *drvr)
void brcms_debugfs_detach(struct brcms_pub *drvr)
{
- if (!IS_ERR_OR_NULL(drvr->dbgfs_dir))
- debugfs_remove_recursive(drvr->dbgfs_dir);
+ debugfs_remove_recursive(drvr->dbgfs_dir);
}
struct dentry *brcms_debugfs_get_devdir(struct brcms_pub *drvr)
--
1.7.12.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-09-20 17:54 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-12 14:10 [PATCH] brcm80211: remove redundant condition check before debugfs_remove_recursive zhong jiang
2018-09-20 12:07 ` Kalle Valo
[not found] ` <20180920120709.5FE6960BF7@smtp.codeaurora.org>
2018-09-20 12:25 ` zhong jiang
2018-09-20 12:30 ` Kalle Valo
2018-09-20 12:37 ` zhong jiang
-- strict thread matches above, loose matches on Subject: below --
2018-09-08 13:40 zhong jiang
2018-09-20 12:10 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).