* [PATCH] atm: solos-pci: make solos_bh() as static
@ 2014-02-19 5:13 Daeseok Youn
2014-02-19 14:54 ` chas williams - CONTRACTOR
2014-02-19 21:39 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Daeseok Youn @ 2014-02-19 5:13 UTC (permalink / raw)
To: chas; +Cc: linux-atm-general, netdev, linux-kernel
>From 6297aabeff748777b520cc0ee835af0a3ddc79e2 Mon Sep 17 00:00:00 2001
From: Daeseok Youn <daeseok.youn@gmail.com>
Date: Wed, 19 Feb 2014 10:49:12 +0900
Subject: [PATCH] atm: solos-pci: make solos_bh() as static
sparse says:
drivers/atm/solos-pci.c:763:6: warning:
symbol 'solos_bh' was not declared. Should it be static?
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
---
drivers/atm/solos-pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/atm/solos-pci.c b/drivers/atm/solos-pci.c
index e3fb496..943cf0d 100644
--- a/drivers/atm/solos-pci.c
+++ b/drivers/atm/solos-pci.c
@@ -760,7 +760,7 @@ static irqreturn_t solos_irq(int irq, void *dev_id)
return IRQ_RETVAL(handled);
}
-void solos_bh(unsigned long card_arg)
+static void solos_bh(unsigned long card_arg)
{
struct solos_card *card = (void *)card_arg;
uint32_t card_flags;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] atm: solos-pci: make solos_bh() as static
2014-02-19 5:13 [PATCH] atm: solos-pci: make solos_bh() as static Daeseok Youn
@ 2014-02-19 14:54 ` chas williams - CONTRACTOR
2014-02-19 21:39 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: chas williams - CONTRACTOR @ 2014-02-19 14:54 UTC (permalink / raw)
To: Daeseok Youn; +Cc: linux-atm-general, netdev, linux-kernel
On Wed, 19 Feb 2014 14:13:54 +0900
Daeseok Youn <daeseok.youn@gmail.com> wrote:
> >From 6297aabeff748777b520cc0ee835af0a3ddc79e2 Mon Sep 17 00:00:00 2001
> From: Daeseok Youn <daeseok.youn@gmail.com>
> Date: Wed, 19 Feb 2014 10:49:12 +0900
> Subject: [PATCH] atm: solos-pci: make solos_bh() as static
>
> sparse says:
>
> drivers/atm/solos-pci.c:763:6: warning:
> symbol 'solos_bh' was not declared. Should it be static?
>
> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
> ---
> drivers/atm/solos-pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/atm/solos-pci.c b/drivers/atm/solos-pci.c
> index e3fb496..943cf0d 100644
> --- a/drivers/atm/solos-pci.c
> +++ b/drivers/atm/solos-pci.c
> @@ -760,7 +760,7 @@ static irqreturn_t solos_irq(int irq, void *dev_id)
> return IRQ_RETVAL(handled);
> }
>
> -void solos_bh(unsigned long card_arg)
> +static void solos_bh(unsigned long card_arg)
> {
> struct solos_card *card = (void *)card_arg;
> uint32_t card_flags;
Acked-by: Chas Williams <chas@cmf.nrl.navy.mil>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] atm: solos-pci: make solos_bh() as static
2014-02-19 5:13 [PATCH] atm: solos-pci: make solos_bh() as static Daeseok Youn
2014-02-19 14:54 ` chas williams - CONTRACTOR
@ 2014-02-19 21:39 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2014-02-19 21:39 UTC (permalink / raw)
To: daeseok.youn; +Cc: chas, linux-atm-general, netdev, linux-kernel
From: Daeseok Youn <daeseok.youn@gmail.com>
Date: Wed, 19 Feb 2014 14:13:54 +0900
> From 6297aabeff748777b520cc0ee835af0a3ddc79e2 Mon Sep 17 00:00:00 2001
> From: Daeseok Youn <daeseok.youn@gmail.com>
> Date: Wed, 19 Feb 2014 10:49:12 +0900
> Subject: [PATCH] atm: solos-pci: make solos_bh() as static
>
> sparse says:
>
> drivers/atm/solos-pci.c:763:6: warning:
> symbol 'solos_bh' was not declared. Should it be static?
>
> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-02-19 21:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-19 5:13 [PATCH] atm: solos-pci: make solos_bh() as static Daeseok Youn
2014-02-19 14:54 ` chas williams - CONTRACTOR
2014-02-19 21:39 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).