netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* net: alteon: replace dev_kfree_skb_irq by dev_consume_skb_irq
@ 2019-01-27 15:56 Yang Wei
  2019-01-29  7:11 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Yang Wei @ 2019-01-27 15:56 UTC (permalink / raw)
  To: linux-acenic, netdev; +Cc: jes, davem, yang.wei9, Yang Wei

dev_consume_skb_irq() should be called in ace_tx_int() when xmit
done. It makes drop profiles more friendly.

Signed-off-by: Yang Wei <yang.wei9@zte.com.cn>
---
 drivers/net/ethernet/alteon/acenic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/alteon/acenic.c b/drivers/net/ethernet/alteon/acenic.c
index 4f11f98..1827ef1 100644
--- a/drivers/net/ethernet/alteon/acenic.c
+++ b/drivers/net/ethernet/alteon/acenic.c
@@ -2059,7 +2059,7 @@ static inline void ace_tx_int(struct net_device *dev,
 		if (skb) {
 			dev->stats.tx_packets++;
 			dev->stats.tx_bytes += skb->len;
-			dev_kfree_skb_irq(skb);
+			dev_consume_skb_irq(skb);
 			info->skb = NULL;
 		}
 
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: net: alteon: replace dev_kfree_skb_irq by dev_consume_skb_irq
  2019-01-27 15:56 net: alteon: replace dev_kfree_skb_irq by dev_consume_skb_irq Yang Wei
@ 2019-01-29  7:11 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-01-29  7:11 UTC (permalink / raw)
  To: albin_yang; +Cc: linux-acenic, netdev, jes, yang.wei9

From: Yang Wei <albin_yang@163.com>
Date: Sun, 27 Jan 2019 23:56:34 +0800

> dev_consume_skb_irq() should be called in ace_tx_int() when xmit
> done. It makes drop profiles more friendly.
> 
> Signed-off-by: Yang Wei <yang.wei9@zte.com.cn>

Applied.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-01-29  7:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-27 15:56 net: alteon: replace dev_kfree_skb_irq by dev_consume_skb_irq Yang Wei
2019-01-29  7:11 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).