From: "Yavuz, Tuba" <tuba@ece.ufl.edu>
To: Greg KH <greg@kroah.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: Error in the hso driver
Date: Sun, 27 Jan 2019 19:49:52 +0000 [thread overview]
Message-ID: <1548618592071.43193@ece.ufl.edu> (raw)
In-Reply-To: <20190127193503.GC25051@kroah.com>
Here is a proposed patch:
--- drivers/net/usb/hso.c.orig 2019-01-27 14:45:58.232683119 -0500
+++ drivers/net/usb/hso.c 2019-01-27 14:47:43.592683629 -0500
@@ -2377,7 +2377,7 @@ static void hso_free_net_device(struct h
remove_net_device(hso_net->parent);
- if (hso_net->net)
+ if (hso_net->net && hso_net->net->reg_state == NETREG_REGISTERED)
unregister_netdev(hso_net->net);
/* start freeing */
Tuba Yavuz, Ph.D.
Assistant Professor
Electrical and Computer Engineering Department
University of Florida
Gainesville, FL 32611
Webpage: http://www.tuba.ece.ufl.edu/
Email: tuba@ece.ufl.edu
Phone: (352) 846 0202
________________________________________
From: Greg KH <greg@kroah.com>
Sent: Sunday, January 27, 2019 2:35 PM
To: Yavuz, Tuba
Cc: netdev@vger.kernel.org; davem@davemloft.net
Subject: Re: Error in the hso driver
On Sun, Jan 27, 2019 at 06:38:41PM +0000, Yavuz, Tuba wrote:
> Hello,
>
>
> On an error path inside the hso_create_net_device function of the hso driver (drivers/net/usb/hso), hso_free_net_device gets called. This causes a negative reference count in the net device if register_netdev has not been called yet as hso_free_net_device calls unregister_netdev regardless. I think the driver should distinguish these cases and call unregister_netdev only if register_netdev has been called.
>
>
> Detected on v4.14-rc2 but I believe the problem still exists in the newer versions.
Can you send a patch to solve this issue? That's the best way to handle
it as you get the proper credit and we can understand exactly what you
are trying to show here.
thanks,
greg k-h
next prev parent reply other threads:[~2019-01-27 19:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1548614320825.86428@ece.ufl.edu>
2019-01-27 19:35 ` Error in the hso driver Greg KH
2019-01-27 19:49 ` Yavuz, Tuba [this message]
2019-01-27 19:53 ` Greg KH
2019-01-27 20:19 ` Andrew Lunn
2019-01-27 20:30 ` Yavuz, Tuba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1548618592071.43193@ece.ufl.edu \
--to=tuba@ece.ufl.edu \
--cc=davem@davemloft.net \
--cc=greg@kroah.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).