From: Andrew Lunn <andrew@lunn.ch>
To: "Yavuz, Tuba" <tuba@ece.ufl.edu>
Cc: Greg KH <greg@kroah.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: Error in the hso driver
Date: Sun, 27 Jan 2019 21:19:24 +0100 [thread overview]
Message-ID: <20190127201924.GA32046@lunn.ch> (raw)
In-Reply-To: <1548618592071.43193@ece.ufl.edu>
On Sun, Jan 27, 2019 at 07:49:52PM +0000, Yavuz, Tuba wrote:
> Here is a proposed patch:
>
> --- drivers/net/usb/hso.c.orig 2019-01-27 14:45:58.232683119 -0500
> +++ drivers/net/usb/hso.c 2019-01-27 14:47:43.592683629 -0500
> @@ -2377,7 +2377,7 @@ static void hso_free_net_device(struct h
>
> remove_net_device(hso_net->parent);
>
> - if (hso_net->net)
> + if (hso_net->net && hso_net->net->reg_state == NETREG_REGISTERED)
> unregister_netdev(hso_net->net);
>
> /* start freeing */
Hi Tuba
Using the free function from the probe often has problems. It is
better to put the cleanup at the end of the probe, and use a
collection of goto's and labels.
Andrew
next prev parent reply other threads:[~2019-01-27 20:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1548614320825.86428@ece.ufl.edu>
2019-01-27 19:35 ` Error in the hso driver Greg KH
2019-01-27 19:49 ` Yavuz, Tuba
2019-01-27 19:53 ` Greg KH
2019-01-27 20:19 ` Andrew Lunn [this message]
2019-01-27 20:30 ` Yavuz, Tuba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190127201924.GA32046@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=greg@kroah.com \
--cc=netdev@vger.kernel.org \
--cc=tuba@ece.ufl.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).