* [PATCH net] net: macb: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles
@ 2019-02-12 16:00 Yang Wei
2019-02-13 16:55 ` Claudiu.Beznea
2019-02-14 5:02 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Yang Wei @ 2019-02-12 16:00 UTC (permalink / raw)
To: netdev; +Cc: nicolas.ferre, davem, yang.wei9, albin_yang
From: Yang Wei <yang.wei9@zte.com.cn>
dev_consume_skb_irq() should be called in at91ether_interrupt() when
skb xmit done. It makes drop profiles(dropwatch, perf) more friendly.
Signed-off-by: Yang Wei <yang.wei9@zte.com.cn>
---
drivers/net/ethernet/cadence/macb_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
index 2b28826..835cc58 100644
--- a/drivers/net/ethernet/cadence/macb_main.c
+++ b/drivers/net/ethernet/cadence/macb_main.c
@@ -3763,7 +3763,7 @@ static irqreturn_t at91ether_interrupt(int irq, void *dev_id)
dev->stats.tx_errors++;
if (lp->skb) {
- dev_kfree_skb_irq(lp->skb);
+ dev_consume_skb_irq(lp->skb);
lp->skb = NULL;
dma_unmap_single(NULL, lp->skb_physaddr,
lp->skb_length, DMA_TO_DEVICE);
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] net: macb: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles
2019-02-12 16:00 [PATCH net] net: macb: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles Yang Wei
@ 2019-02-13 16:55 ` Claudiu.Beznea
2019-02-14 5:02 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Claudiu.Beznea @ 2019-02-13 16:55 UTC (permalink / raw)
To: albin_yang, netdev; +Cc: Nicolas.Ferre, davem, yang.wei9
On 12.02.2019 18:00, Yang Wei wrote:
> From: Yang Wei <yang.wei9@zte.com.cn>
>
> dev_consume_skb_irq() should be called in at91ether_interrupt() when
> skb xmit done. It makes drop profiles(dropwatch, perf) more friendly.
>
> Signed-off-by: Yang Wei <yang.wei9@zte.com.cn>
Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> ---
> drivers/net/ethernet/cadence/macb_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
> index 2b28826..835cc58 100644
> --- a/drivers/net/ethernet/cadence/macb_main.c
> +++ b/drivers/net/ethernet/cadence/macb_main.c
> @@ -3763,7 +3763,7 @@ static irqreturn_t at91ether_interrupt(int irq, void *dev_id)
> dev->stats.tx_errors++;
>
> if (lp->skb) {
> - dev_kfree_skb_irq(lp->skb);
> + dev_consume_skb_irq(lp->skb);
> lp->skb = NULL;
> dma_unmap_single(NULL, lp->skb_physaddr,
> lp->skb_length, DMA_TO_DEVICE);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] net: macb: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles
2019-02-12 16:00 [PATCH net] net: macb: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles Yang Wei
2019-02-13 16:55 ` Claudiu.Beznea
@ 2019-02-14 5:02 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-02-14 5:02 UTC (permalink / raw)
To: albin_yang; +Cc: netdev, nicolas.ferre, yang.wei9
From: Yang Wei <albin_yang@163.com>
Date: Wed, 13 Feb 2019 00:00:02 +0800
> From: Yang Wei <yang.wei9@zte.com.cn>
>
> dev_consume_skb_irq() should be called in at91ether_interrupt() when
> skb xmit done. It makes drop profiles(dropwatch, perf) more friendly.
>
> Signed-off-by: Yang Wei <yang.wei9@zte.com.cn>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-14 5:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-12 16:00 [PATCH net] net: macb: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles Yang Wei
2019-02-13 16:55 ` Claudiu.Beznea
2019-02-14 5:02 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).