* [PATCH v3 2/2] dt-bindings: net: bluetooth: Add device property firmware-name for QCA6174
[not found] <1554368908-22017-2-git-send-email-rjliao@codeaurora.org>
@ 2019-04-10 9:27 ` Rocky Liao
2019-04-23 17:06 ` Marcel Holtmann
` (2 more replies)
0 siblings, 3 replies; 14+ messages in thread
From: Rocky Liao @ 2019-04-10 9:27 UTC (permalink / raw)
To: robh+dt, mark.rutland, marcel, johan.hedberg, thierry.escande
Cc: netdev, devicetree, linux-kernel, linux-bluetooth, linux-arm-msm,
bgodavar, Rocky Liao
This patch adds an optional device property "firmware-name" to allow the
driver to load customized nvm firmware file based on this property.
Signed-off-by: Rocky Liao <rjliao@codeaurora.org>
---
Changes in v3:
* added firmware-name instead of nvm-postfix to specify full firmware name
---
Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
index 824c0e2..2bcea50 100644
--- a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
+++ b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
@@ -16,6 +16,7 @@ Optional properties for compatible string qcom,qca6174-bt:
- enable-gpios: gpio specifier used to enable chip
- clocks: clock provided to the controller (SUSCLK_32KHZ)
+ - firmware-name: specify the name of nvm firmware to load
Required properties for compatible string qcom,wcn3990-bt:
@@ -39,6 +40,7 @@ serial@7570000 {
enable-gpios = <&pm8994_gpios 19 GPIO_ACTIVE_HIGH>;
clocks = <&divclk4>;
+ firmware-name = "nvm_00440302.bin";
};
};
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v3 2/2] dt-bindings: net: bluetooth: Add device property firmware-name for QCA6174
2019-04-10 9:27 ` [PATCH v3 2/2] dt-bindings: net: bluetooth: Add device property firmware-name for QCA6174 Rocky Liao
@ 2019-04-23 17:06 ` Marcel Holtmann
2019-04-24 6:19 ` Rocky Liao
2019-04-26 20:50 ` Rob Herring
2019-05-12 3:19 ` [PATCH v4 " Rocky Liao
2 siblings, 1 reply; 14+ messages in thread
From: Marcel Holtmann @ 2019-04-23 17:06 UTC (permalink / raw)
To: Rocky Liao
Cc: Rob Herring, Mark Rutland, Johan Hedberg, thierry.escande,
netdev, devicetree, linux-kernel, linux-bluetooth, linux-arm-msm,
bgodavar
Hi Rocky,
> This patch adds an optional device property "firmware-name" to allow the
> driver to load customized nvm firmware file based on this property.
>
> Signed-off-by: Rocky Liao <rjliao@codeaurora.org>
> ---
> Changes in v3:
> * added firmware-name instead of nvm-postfix to specify full firmware name
> ---
> Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
> index 824c0e2..2bcea50 100644
> --- a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
> +++ b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
> @@ -16,6 +16,7 @@ Optional properties for compatible string qcom,qca6174-bt:
>
> - enable-gpios: gpio specifier used to enable chip
> - clocks: clock provided to the controller (SUSCLK_32KHZ)
> + - firmware-name: specify the name of nvm firmware to load
>
> Required properties for compatible string qcom,wcn3990-bt:
>
> @@ -39,6 +40,7 @@ serial@7570000 {
>
> enable-gpios = <&pm8994_gpios 19 GPIO_ACTIVE_HIGH>;
> clocks = <&divclk4>;
> + firmware-name = "nvm_00440302.bin";
> };
and how is this a firmware-name property. Wouldn’t this be more like nvm-file or something along these lines. This really needs to be cleared with Rob to pick the right property name.
Regards
Marcel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v3 2/2] dt-bindings: net: bluetooth: Add device property firmware-name for QCA6174
2019-04-23 17:06 ` Marcel Holtmann
@ 2019-04-24 6:19 ` Rocky Liao
2019-04-26 17:45 ` Rob Herring
0 siblings, 1 reply; 14+ messages in thread
From: Rocky Liao @ 2019-04-24 6:19 UTC (permalink / raw)
To: Marcel Holtmann
Cc: Rob Herring, Mark Rutland, Johan Hedberg, thierry.escande,
netdev, devicetree, linux-kernel, linux-bluetooth, linux-arm-msm,
bgodavar
On 2019-04-24 01:06, Marcel Holtmann wrote:
> Hi Rocky,
>
>> This patch adds an optional device property "firmware-name" to allow
>> the
>> driver to load customized nvm firmware file based on this property.
>>
>> Signed-off-by: Rocky Liao <rjliao@codeaurora.org>
>> ---
>> Changes in v3:
>> * added firmware-name instead of nvm-postfix to specify full firmware
>> name
>> ---
>> Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
>> b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
>> index 824c0e2..2bcea50 100644
>> --- a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
>> +++ b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
>> @@ -16,6 +16,7 @@ Optional properties for compatible string
>> qcom,qca6174-bt:
>>
>> - enable-gpios: gpio specifier used to enable chip
>> - clocks: clock provided to the controller (SUSCLK_32KHZ)
>> + - firmware-name: specify the name of nvm firmware to load
>>
>> Required properties for compatible string qcom,wcn3990-bt:
>>
>> @@ -39,6 +40,7 @@ serial@7570000 {
>>
>> enable-gpios = <&pm8994_gpios 19 GPIO_ACTIVE_HIGH>;
>> clocks = <&divclk4>;
>> + firmware-name = "nvm_00440302.bin";
>> };
>
> and how is this a firmware-name property. Wouldn’t this be more like
> nvm-file or something along these lines. This really needs to be
> cleared with Rob to pick the right property name.
>
> Regards
>
> Marcel
Hi Rob,
Are you OK to use a property name "nvm-file" or "firmware-nvm-file"?
Actually we have two firmware files, one is the patch file which is
common to all of the products, the other is the nvm file which is
customized. Using a "nvm-file" or "firmware-nvm-file" property name
would be more clear.
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v3 2/2] dt-bindings: net: bluetooth: Add device property firmware-name for QCA6174
2019-04-24 6:19 ` Rocky Liao
@ 2019-04-26 17:45 ` Rob Herring
2019-04-27 5:59 ` Marcel Holtmann
0 siblings, 1 reply; 14+ messages in thread
From: Rob Herring @ 2019-04-26 17:45 UTC (permalink / raw)
To: Rocky Liao
Cc: Marcel Holtmann, Mark Rutland, Johan Hedberg, Thierry Escande,
netdev, devicetree, linux-kernel, open list:BLUETOOTH DRIVERS,
linux-arm-msm, Balakrishna Godavarthi
On Wed, Apr 24, 2019 at 1:19 AM Rocky Liao <rjliao@codeaurora.org> wrote:
>
> On 2019-04-24 01:06, Marcel Holtmann wrote:
> > Hi Rocky,
> >
> >> This patch adds an optional device property "firmware-name" to allow
> >> the
> >> driver to load customized nvm firmware file based on this property.
> >>
> >> Signed-off-by: Rocky Liao <rjliao@codeaurora.org>
> >> ---
> >> Changes in v3:
> >> * added firmware-name instead of nvm-postfix to specify full firmware
> >> name
> >> ---
> >> Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt | 2 ++
> >> 1 file changed, 2 insertions(+)
> >>
> >> diff --git
> >> a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
> >> b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
> >> index 824c0e2..2bcea50 100644
> >> --- a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
> >> +++ b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
> >> @@ -16,6 +16,7 @@ Optional properties for compatible string
> >> qcom,qca6174-bt:
> >>
> >> - enable-gpios: gpio specifier used to enable chip
> >> - clocks: clock provided to the controller (SUSCLK_32KHZ)
> >> + - firmware-name: specify the name of nvm firmware to load
> >>
> >> Required properties for compatible string qcom,wcn3990-bt:
> >>
> >> @@ -39,6 +40,7 @@ serial@7570000 {
> >>
> >> enable-gpios = <&pm8994_gpios 19 GPIO_ACTIVE_HIGH>;
> >> clocks = <&divclk4>;
> >> + firmware-name = "nvm_00440302.bin";
> >> };
> >
> > and how is this a firmware-name property. Wouldn’t this be more like
> > nvm-file or something along these lines. This really needs to be
> > cleared with Rob to pick the right property name.
> >
> > Regards
> >
> > Marcel
>
> Hi Rob,
>
> Are you OK to use a property name "nvm-file" or "firmware-nvm-file"?
> Actually we have two firmware files, one is the patch file which is
> common to all of the products, the other is the nvm file which is
> customized. Using a "nvm-file" or "firmware-nvm-file" property name
> would be more clear.
'firmware-name' is the standard name for specifying firmware file names.
Rob
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v3 2/2] dt-bindings: net: bluetooth: Add device property firmware-name for QCA6174
2019-04-10 9:27 ` [PATCH v3 2/2] dt-bindings: net: bluetooth: Add device property firmware-name for QCA6174 Rocky Liao
2019-04-23 17:06 ` Marcel Holtmann
@ 2019-04-26 20:50 ` Rob Herring
2019-05-12 3:19 ` [PATCH v4 " Rocky Liao
2 siblings, 0 replies; 14+ messages in thread
From: Rob Herring @ 2019-04-26 20:50 UTC (permalink / raw)
To: Rocky Liao
Cc: robh+dt, mark.rutland, marcel, johan.hedberg, thierry.escande,
netdev, devicetree, linux-kernel, linux-bluetooth, linux-arm-msm,
bgodavar, Rocky Liao
On Wed, 10 Apr 2019 17:27:56 +0800, Rocky Liao wrote:
> This patch adds an optional device property "firmware-name" to allow the
> driver to load customized nvm firmware file based on this property.
>
> Signed-off-by: Rocky Liao <rjliao@codeaurora.org>
> ---
> Changes in v3:
> * added firmware-name instead of nvm-postfix to specify full firmware name
> ---
> Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v3 2/2] dt-bindings: net: bluetooth: Add device property firmware-name for QCA6174
2019-04-26 17:45 ` Rob Herring
@ 2019-04-27 5:59 ` Marcel Holtmann
2019-05-03 7:56 ` Rocky Liao
0 siblings, 1 reply; 14+ messages in thread
From: Marcel Holtmann @ 2019-04-27 5:59 UTC (permalink / raw)
To: Rob Herring
Cc: Rocky Liao, Mark Rutland, Johan Hedberg, Thierry Escande, netdev,
devicetree, linux-kernel, open list:BLUETOOTH DRIVERS,
linux-arm-msm, Balakrishna Godavarthi
Hi Rob,
>>>> This patch adds an optional device property "firmware-name" to allow
>>>> the
>>>> driver to load customized nvm firmware file based on this property.
>>>>
>>>> Signed-off-by: Rocky Liao <rjliao@codeaurora.org>
>>>> ---
>>>> Changes in v3:
>>>> * added firmware-name instead of nvm-postfix to specify full firmware
>>>> name
>>>> ---
>>>> Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt | 2 ++
>>>> 1 file changed, 2 insertions(+)
>>>>
>>>> diff --git
>>>> a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
>>>> b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
>>>> index 824c0e2..2bcea50 100644
>>>> --- a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
>>>> +++ b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
>>>> @@ -16,6 +16,7 @@ Optional properties for compatible string
>>>> qcom,qca6174-bt:
>>>>
>>>> - enable-gpios: gpio specifier used to enable chip
>>>> - clocks: clock provided to the controller (SUSCLK_32KHZ)
>>>> + - firmware-name: specify the name of nvm firmware to load
>>>>
>>>> Required properties for compatible string qcom,wcn3990-bt:
>>>>
>>>> @@ -39,6 +40,7 @@ serial@7570000 {
>>>>
>>>> enable-gpios = <&pm8994_gpios 19 GPIO_ACTIVE_HIGH>;
>>>> clocks = <&divclk4>;
>>>> + firmware-name = "nvm_00440302.bin";
>>>> };
>>>
>>> and how is this a firmware-name property. Wouldn’t this be more like
>>> nvm-file or something along these lines. This really needs to be
>>> cleared with Rob to pick the right property name.
>>>
>>> Regards
>>>
>>> Marcel
>>
>> Hi Rob,
>>
>> Are you OK to use a property name "nvm-file" or "firmware-nvm-file"?
>> Actually we have two firmware files, one is the patch file which is
>> common to all of the products, the other is the nvm file which is
>> customized. Using a "nvm-file" or "firmware-nvm-file" property name
>> would be more clear.
>
> 'firmware-name' is the standard name for specifying firmware file names.
but it is not a firmware file, it is a NVM file. What happens if in the future they need a firmware file and a NVM file?
Regards
Marcel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v3 2/2] dt-bindings: net: bluetooth: Add device property firmware-name for QCA6174
2019-04-27 5:59 ` Marcel Holtmann
@ 2019-05-03 7:56 ` Rocky Liao
2019-05-05 17:32 ` Marcel Holtmann
0 siblings, 1 reply; 14+ messages in thread
From: Rocky Liao @ 2019-05-03 7:56 UTC (permalink / raw)
To: Marcel Holtmann
Cc: Rob Herring, Mark Rutland, Johan Hedberg, Thierry Escande,
netdev, devicetree, linux-kernel, open list:BLUETOOTH DRIVERS,
linux-arm-msm, Balakrishna Godavarthi, linux-bluetooth-owner
Hi Marcel,
On 2019-04-27 13:59, Marcel Holtmann wrote:
> Hi Rob,
>
>>>>> This patch adds an optional device property "firmware-name" to
>>>>> allow
>>>>> the
>>>>> driver to load customized nvm firmware file based on this property.
>>>>>
>>>>> Signed-off-by: Rocky Liao <rjliao@codeaurora.org>
>>>>> ---
>>>>> Changes in v3:
>>>>> * added firmware-name instead of nvm-postfix to specify full
>>>>> firmware
>>>>> name
>>>>> ---
>>>>> Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt | 2 ++
>>>>> 1 file changed, 2 insertions(+)
>>>>>
>>>>> diff --git
>>>>> a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
>>>>> b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
>>>>> index 824c0e2..2bcea50 100644
>>>>> --- a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
>>>>> +++ b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
>>>>> @@ -16,6 +16,7 @@ Optional properties for compatible string
>>>>> qcom,qca6174-bt:
>>>>>
>>>>> - enable-gpios: gpio specifier used to enable chip
>>>>> - clocks: clock provided to the controller (SUSCLK_32KHZ)
>>>>> + - firmware-name: specify the name of nvm firmware to load
>>>>>
>>>>> Required properties for compatible string qcom,wcn3990-bt:
>>>>>
>>>>> @@ -39,6 +40,7 @@ serial@7570000 {
>>>>>
>>>>> enable-gpios = <&pm8994_gpios 19 GPIO_ACTIVE_HIGH>;
>>>>> clocks = <&divclk4>;
>>>>> + firmware-name = "nvm_00440302.bin";
>>>>> };
>>>>
>>>> and how is this a firmware-name property. Wouldn’t this be more like
>>>> nvm-file or something along these lines. This really needs to be
>>>> cleared with Rob to pick the right property name.
>>>>
>>>> Regards
>>>>
>>>> Marcel
>>>
>>> Hi Rob,
>>>
>>> Are you OK to use a property name "nvm-file" or "firmware-nvm-file"?
>>> Actually we have two firmware files, one is the patch file which is
>>> common to all of the products, the other is the nvm file which is
>>> customized. Using a "nvm-file" or "firmware-nvm-file" property name
>>> would be more clear.
>>
>> 'firmware-name' is the standard name for specifying firmware file
>> names.
>
> but it is not a firmware file, it is a NVM file. What happens if in
> the future they need a firmware file and a NVM file?
>
> Regards
>
> Marcel
We won't need to specify a rampatch firmware file in future as it's a
same file for all the boards with same chip, only the NVM firmware file
may have board differences. NVM file is also one of the firmware files
so I think it should be OK to use "firmware-name" property to specify
it.
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v3 2/2] dt-bindings: net: bluetooth: Add device property firmware-name for QCA6174
2019-05-03 7:56 ` Rocky Liao
@ 2019-05-05 17:32 ` Marcel Holtmann
0 siblings, 0 replies; 14+ messages in thread
From: Marcel Holtmann @ 2019-05-05 17:32 UTC (permalink / raw)
To: Rocky Liao
Cc: Rob Herring, Mark Rutland, Johan Hedberg, Thierry Escande,
netdev, devicetree, linux-kernel, open list:BLUETOOTH DRIVERS,
linux-arm-msm, Balakrishna Godavarthi, linux-bluetooth-owner
Hi Rocky,
>>>>>> This patch adds an optional device property "firmware-name" to allow
>>>>>> the
>>>>>> driver to load customized nvm firmware file based on this property.
>>>>>> Signed-off-by: Rocky Liao <rjliao@codeaurora.org>
>>>>>> ---
>>>>>> Changes in v3:
>>>>>> * added firmware-name instead of nvm-postfix to specify full firmware
>>>>>> name
>>>>>> ---
>>>>>> Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt | 2 ++
>>>>>> 1 file changed, 2 insertions(+)
>>>>>> diff --git
>>>>>> a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
>>>>>> b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
>>>>>> index 824c0e2..2bcea50 100644
>>>>>> --- a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
>>>>>> +++ b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
>>>>>> @@ -16,6 +16,7 @@ Optional properties for compatible string
>>>>>> qcom,qca6174-bt:
>>>>>> - enable-gpios: gpio specifier used to enable chip
>>>>>> - clocks: clock provided to the controller (SUSCLK_32KHZ)
>>>>>> + - firmware-name: specify the name of nvm firmware to load
>>>>>> Required properties for compatible string qcom,wcn3990-bt:
>>>>>> @@ -39,6 +40,7 @@ serial@7570000 {
>>>>>> enable-gpios = <&pm8994_gpios 19 GPIO_ACTIVE_HIGH>;
>>>>>> clocks = <&divclk4>;
>>>>>> + firmware-name = "nvm_00440302.bin";
>>>>>> };
>>>>> and how is this a firmware-name property. Wouldn’t this be more like
>>>>> nvm-file or something along these lines. This really needs to be
>>>>> cleared with Rob to pick the right property name.
>>>>> Regards
>>>>> Marcel
>>>> Hi Rob,
>>>> Are you OK to use a property name "nvm-file" or "firmware-nvm-file"?
>>>> Actually we have two firmware files, one is the patch file which is
>>>> common to all of the products, the other is the nvm file which is
>>>> customized. Using a "nvm-file" or "firmware-nvm-file" property name
>>>> would be more clear.
>>> 'firmware-name' is the standard name for specifying firmware file names.
>> but it is not a firmware file, it is a NVM file. What happens if in
>> the future they need a firmware file and a NVM file?
>> Regards
>> Marcel
>
> We won't need to specify a rampatch firmware file in future as it's a same file for all the boards with same chip, only the NVM firmware file may have board differences. NVM file is also one of the firmware files so I think it should be OK to use "firmware-name" property to specify it.
ok then, but I need patches that apply cleanly against bluetooth-next.
Regards
Marcel
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v4 2/2] dt-bindings: net: bluetooth: Add device property firmware-name for QCA6174
2019-04-10 9:27 ` [PATCH v3 2/2] dt-bindings: net: bluetooth: Add device property firmware-name for QCA6174 Rocky Liao
2019-04-23 17:06 ` Marcel Holtmann
2019-04-26 20:50 ` Rob Herring
@ 2019-05-12 3:19 ` Rocky Liao
2019-05-13 15:31 ` Rob Herring
2019-05-15 11:20 ` [PATCH v5 " Rocky Liao
2 siblings, 2 replies; 14+ messages in thread
From: Rocky Liao @ 2019-05-12 3:19 UTC (permalink / raw)
To: robh+dt, mark.rutland, marcel, johan.hedberg, thierry.escande
Cc: netdev, devicetree, linux-kernel, linux-bluetooth, linux-arm-msm,
bgodavar, Rocky Liao
This patch adds an optional device property "firmware-name" to allow the
driver to load customized nvm firmware file based on this property.
Signed-off-by: Rocky Liao <rjliao@codeaurora.org>
---
Changes in v4:
* rebased the code base and merge with latest code
---
Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
index 7ef6118..7a3eda7 100644
--- a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
+++ b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
@@ -17,6 +17,7 @@ Optional properties for compatible string qcom,qca6174-bt:
- enable-gpios: gpio specifier used to enable chip
- clocks: clock provided to the controller (SUSCLK_32KHZ)
+ - firmware-name: specify the name of nvm firmware to load
Required properties for compatible string qcom,wcn399x-bt:
@@ -40,6 +41,7 @@ serial@7570000 {
enable-gpios = <&pm8994_gpios 19 GPIO_ACTIVE_HIGH>;
clocks = <&divclk4>;
+ firmware-name = "nvm_00440302.bin";
};
};
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v4 2/2] dt-bindings: net: bluetooth: Add device property firmware-name for QCA6174
2019-05-12 3:19 ` [PATCH v4 " Rocky Liao
@ 2019-05-13 15:31 ` Rob Herring
2019-05-15 11:20 ` [PATCH v5 " Rocky Liao
1 sibling, 0 replies; 14+ messages in thread
From: Rob Herring @ 2019-05-13 15:31 UTC (permalink / raw)
To: Rocky Liao
Cc: robh+dt, mark.rutland, marcel, johan.hedberg, thierry.escande,
netdev, devicetree, linux-kernel, linux-bluetooth, linux-arm-msm,
bgodavar, Rocky Liao
On Sun, 12 May 2019 11:19:45 +0800, Rocky Liao wrote:
> This patch adds an optional device property "firmware-name" to allow the
> driver to load customized nvm firmware file based on this property.
>
> Signed-off-by: Rocky Liao <rjliao@codeaurora.org>
> ---
> Changes in v4:
> * rebased the code base and merge with latest code
> ---
> Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v5 2/2] dt-bindings: net: bluetooth: Add device property firmware-name for QCA6174
2019-05-12 3:19 ` [PATCH v4 " Rocky Liao
2019-05-13 15:31 ` Rob Herring
@ 2019-05-15 11:20 ` Rocky Liao
2019-06-06 9:40 ` [PATCH v6 " Rocky Liao
1 sibling, 1 reply; 14+ messages in thread
From: Rocky Liao @ 2019-05-15 11:20 UTC (permalink / raw)
To: robh+dt, mark.rutland, marcel, johan.hedberg, thierry.escande
Cc: netdev, devicetree, linux-kernel, linux-bluetooth, linux-arm-msm,
bgodavar, c-hbandi, Rocky Liao
This patch adds an optional device property "firmware-name" to allow the
driver to load customized nvm firmware file based on this property.
Signed-off-by: Rocky Liao <rjliao@codeaurora.org>
Reviewed-by: Rob Herring <robh@kernel.org>
---
Changes in v5:
* Made the change applicable to the wcn399x series chip sets
---
Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
index 7ef6118..68b67d9 100644
--- a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
+++ b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
@@ -17,6 +17,7 @@ Optional properties for compatible string qcom,qca6174-bt:
- enable-gpios: gpio specifier used to enable chip
- clocks: clock provided to the controller (SUSCLK_32KHZ)
+ - firmware-name: specify the name of nvm firmware to load
Required properties for compatible string qcom,wcn399x-bt:
@@ -28,6 +29,7 @@ Required properties for compatible string qcom,wcn399x-bt:
Optional properties for compatible string qcom,wcn399x-bt:
- max-speed: see Documentation/devicetree/bindings/serial/slave-device.txt
+ - firmware-name: specify the name of nvm firmware to load
Examples:
@@ -40,6 +42,7 @@ serial@7570000 {
enable-gpios = <&pm8994_gpios 19 GPIO_ACTIVE_HIGH>;
clocks = <&divclk4>;
+ firmware-name = "nvm_00440302.bin";
};
};
@@ -52,5 +55,6 @@ serial@898000 {
vddrf-supply = <&vreg_l17a_1p3>;
vddch0-supply = <&vreg_l25a_3p3>;
max-speed = <3200000>;
+ firmware-name = "crnv21.bin";
};
};
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v6 2/2] dt-bindings: net: bluetooth: Add device property firmware-name for QCA6174
2019-05-15 11:20 ` [PATCH v5 " Rocky Liao
@ 2019-06-06 9:40 ` Rocky Liao
2019-06-11 22:01 ` Rob Herring
2019-07-06 10:56 ` Marcel Holtmann
0 siblings, 2 replies; 14+ messages in thread
From: Rocky Liao @ 2019-06-06 9:40 UTC (permalink / raw)
To: robh+dt, mark.rutland, marcel, johan.hedberg, thierry.escande
Cc: netdev, devicetree, linux-kernel, linux-bluetooth, linux-arm-msm,
bgodavar, c-hbandi, Rocky Liao
This patch adds an optional device property "firmware-name" to allow the
driver to load customized nvm firmware file based on this property.
Signed-off-by: Rocky Liao <rjliao@codeaurora.org>
---
Changes in v6:
* Added read firmware-name property for both QCA6174 and WCN399X
---
Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
index 7ef6118..68b67d9 100644
--- a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
+++ b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
@@ -17,6 +17,7 @@ Optional properties for compatible string qcom,qca6174-bt:
- enable-gpios: gpio specifier used to enable chip
- clocks: clock provided to the controller (SUSCLK_32KHZ)
+ - firmware-name: specify the name of nvm firmware to load
Required properties for compatible string qcom,wcn399x-bt:
@@ -28,6 +29,7 @@ Required properties for compatible string qcom,wcn399x-bt:
Optional properties for compatible string qcom,wcn399x-bt:
- max-speed: see Documentation/devicetree/bindings/serial/slave-device.txt
+ - firmware-name: specify the name of nvm firmware to load
Examples:
@@ -40,6 +42,7 @@ serial@7570000 {
enable-gpios = <&pm8994_gpios 19 GPIO_ACTIVE_HIGH>;
clocks = <&divclk4>;
+ firmware-name = "nvm_00440302.bin";
};
};
@@ -52,5 +55,6 @@ serial@898000 {
vddrf-supply = <&vreg_l17a_1p3>;
vddch0-supply = <&vreg_l25a_3p3>;
max-speed = <3200000>;
+ firmware-name = "crnv21.bin";
};
};
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v6 2/2] dt-bindings: net: bluetooth: Add device property firmware-name for QCA6174
2019-06-06 9:40 ` [PATCH v6 " Rocky Liao
@ 2019-06-11 22:01 ` Rob Herring
2019-07-06 10:56 ` Marcel Holtmann
1 sibling, 0 replies; 14+ messages in thread
From: Rob Herring @ 2019-06-11 22:01 UTC (permalink / raw)
To: Rocky Liao
Cc: mark.rutland, marcel, johan.hedberg, thierry.escande, netdev,
devicetree, linux-kernel, linux-bluetooth, linux-arm-msm,
bgodavar, c-hbandi
On Thu, Jun 06, 2019 at 05:40:55PM +0800, Rocky Liao wrote:
> This patch adds an optional device property "firmware-name" to allow the
> driver to load customized nvm firmware file based on this property.
>
> Signed-off-by: Rocky Liao <rjliao@codeaurora.org>
> ---
> Changes in v6:
> * Added read firmware-name property for both QCA6174 and WCN399X
> ---
> Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt | 4 ++++
> 1 file changed, 4 insertions(+)
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v6 2/2] dt-bindings: net: bluetooth: Add device property firmware-name for QCA6174
2019-06-06 9:40 ` [PATCH v6 " Rocky Liao
2019-06-11 22:01 ` Rob Herring
@ 2019-07-06 10:56 ` Marcel Holtmann
1 sibling, 0 replies; 14+ messages in thread
From: Marcel Holtmann @ 2019-07-06 10:56 UTC (permalink / raw)
To: Rocky Liao
Cc: robh+dt, mark.rutland, Johan Hedberg, thierry.escande, netdev,
devicetree, linux-kernel, linux-bluetooth, linux-arm-msm,
bgodavar, c-hbandi
Hi Rocky,
> This patch adds an optional device property "firmware-name" to allow the
> driver to load customized nvm firmware file based on this property.
>
> Signed-off-by: Rocky Liao <rjliao@codeaurora.org>
> ---
> Changes in v6:
> * Added read firmware-name property for both QCA6174 and WCN399X
> ---
> Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt | 4 ++++
> 1 file changed, 4 insertions(+)
patch has been applied to bluetooth-next tree.
Regards
Marcel
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2019-07-06 10:56 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1554368908-22017-2-git-send-email-rjliao@codeaurora.org>
2019-04-10 9:27 ` [PATCH v3 2/2] dt-bindings: net: bluetooth: Add device property firmware-name for QCA6174 Rocky Liao
2019-04-23 17:06 ` Marcel Holtmann
2019-04-24 6:19 ` Rocky Liao
2019-04-26 17:45 ` Rob Herring
2019-04-27 5:59 ` Marcel Holtmann
2019-05-03 7:56 ` Rocky Liao
2019-05-05 17:32 ` Marcel Holtmann
2019-04-26 20:50 ` Rob Herring
2019-05-12 3:19 ` [PATCH v4 " Rocky Liao
2019-05-13 15:31 ` Rob Herring
2019-05-15 11:20 ` [PATCH v5 " Rocky Liao
2019-06-06 9:40 ` [PATCH v6 " Rocky Liao
2019-06-11 22:01 ` Rob Herring
2019-07-06 10:56 ` Marcel Holtmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).