From: "David Z. Dai" <zdai@linux.vnet.ibm.com>
To: Alexander Duyck <alexander.duyck@gmail.com>
Cc: alexander.h.duyck@linux.intel.com,
intel-wired-lan@lists.osuosl.org, jeffrey.t.kirsher@intel.com,
netdev@vger.kernel.org, zdai@us.ibm.com
Subject: Re: [next-queue PATCH v2 0/2] Address IRQ related crash seen due to io_perm_failure
Date: Tue, 29 Oct 2019 09:43:07 -0500 [thread overview]
Message-ID: <1572360187.12281.4.camel@oc5348122405> (raw)
In-Reply-To: <20191011153219.22313.60179.stgit@localhost.localdomain>
On Fri, 2019-10-11 at 08:34 -0700, Alexander Duyck wrote:
> David Dai had submitted a patch[1] to address a reported issue with e1000e
> calling pci_disable_msi without first freeing the interrupts. Looking over
> the issue it seems the problem was the fact that e1000e_down was being
> called in e1000_io_error_detected without calling e1000_free_irq, and this
> was resulting in e1000e_close skipping over the call to e1000e_down and
> e1000_free_irq.
>
> The use of the __E1000_DOWN flag for the close test seems to have come from
> the runtime power management changes that were made some time ago. From
> what I can tell in the close path we should be disabling runtime power
> management via a call to pm_runtime_get_sync. As such we can remove the
> test for the __E1000_DOWN bit. However in comparing this with other drivers
> we do need to avoid freeing the IRQs more than once. So in order to address
> that I have copied the approach taken in igb and taken it a bit further so
> that we will always detach the interface and if the interface is up we will
> bring it down and free the IRQs. In addition we are able to reuse some of
> the power management code so I have taken the opportunity to merge those
> bits.
>
> [1]: https://lore.kernel.org/lkml/1570121672-12172-1-git-send-email-zdai@linux.vnet.ibm.com/
>
> v2: Move e1000e_pm_thaw out of CONFIG_PM region to fix build issue on Sparc64
>
> ---
>
> Alexander Duyck (2):
> e1000e: Use rtnl_lock to prevent race conditions between net and pci/pm
> e1000e: Drop unnecessary __E1000_DOWN bit twiddling
>
>
> drivers/net/ethernet/intel/e1000e/netdev.c | 75 +++++++++++++---------------
> 1 file changed, 36 insertions(+), 39 deletions(-)
>
I am not familiar with the process. Don't mean to push you in any way.
Just want to check if these 2 v2 patches will be accepted by upstream?
or any thing else needs to be done to finish the process?
Thanks! - David
prev parent reply other threads:[~2019-10-29 14:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 15:34 [next-queue PATCH v2 0/2] Address IRQ related crash seen due to io_perm_failure Alexander Duyck
2019-10-11 15:34 ` [next-queue PATCH v2 1/2] e1000e: Use rtnl_lock to prevent race conditions between net and pci/pm Alexander Duyck
2019-10-23 2:09 ` Brown, Aaron F
2019-10-11 15:34 ` [next-queue PATCH v2 2/2] e1000e: Drop unnecessary __E1000_DOWN bit twiddling Alexander Duyck
2019-10-23 2:10 ` [Intel-wired-lan] " Brown, Aaron F
2019-10-29 14:43 ` David Z. Dai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1572360187.12281.4.camel@oc5348122405 \
--to=zdai@linux.vnet.ibm.com \
--cc=alexander.duyck@gmail.com \
--cc=alexander.h.duyck@linux.intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=zdai@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).