From: "Brown, Aaron F" <aaron.f.brown@intel.com>
To: Alexander Duyck <alexander.duyck@gmail.com>,
"alexander.h.duyck@linux.intel.com"
<alexander.h.duyck@linux.intel.com>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>,
"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"zdai@us.ibm.com" <zdai@us.ibm.com>,
"zdai@linux.vnet.ibm.com" <zdai@linux.vnet.ibm.com>
Subject: RE: [Intel-wired-lan] [next-queue PATCH v2 2/2] e1000e: Drop unnecessary __E1000_DOWN bit twiddling
Date: Wed, 23 Oct 2019 02:10:09 +0000 [thread overview]
Message-ID: <309B89C4C689E141A5FF6A0C5FB2118B97154E17@ORSMSX103.amr.corp.intel.com> (raw)
In-Reply-To: <20191011153459.22313.17985.stgit@localhost.localdomain>
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Alexander Duyck
> Sent: Friday, October 11, 2019 8:35 AM
> To: alexander.h.duyck@linux.intel.com; intel-wired-lan@lists.osuosl.org;
> Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>
> Cc: netdev@vger.kernel.org; zdai@us.ibm.com; zdai@linux.vnet.ibm.com
> Subject: [Intel-wired-lan] [next-queue PATCH v2 2/2] e1000e: Drop
> unnecessary __E1000_DOWN bit twiddling
>
> From: Alexander Duyck <alexander.h.duyck@linux.intel.com>
>
> Since we no longer check for __E1000_DOWN in e1000e_close we can drop
> the
> spot where we were restoring the bit. This saves us a bit of unnecessary
> complexity.
>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@linux.intel.com>
> ---
> drivers/net/ethernet/intel/e1000e/netdev.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
next prev parent reply other threads:[~2019-10-23 2:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 15:34 [next-queue PATCH v2 0/2] Address IRQ related crash seen due to io_perm_failure Alexander Duyck
2019-10-11 15:34 ` [next-queue PATCH v2 1/2] e1000e: Use rtnl_lock to prevent race conditions between net and pci/pm Alexander Duyck
2019-10-23 2:09 ` Brown, Aaron F
2019-10-11 15:34 ` [next-queue PATCH v2 2/2] e1000e: Drop unnecessary __E1000_DOWN bit twiddling Alexander Duyck
2019-10-23 2:10 ` Brown, Aaron F [this message]
2019-10-29 14:43 ` [next-queue PATCH v2 0/2] Address IRQ related crash seen due to io_perm_failure David Z. Dai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=309B89C4C689E141A5FF6A0C5FB2118B97154E17@ORSMSX103.amr.corp.intel.com \
--to=aaron.f.brown@intel.com \
--cc=alexander.duyck@gmail.com \
--cc=alexander.h.duyck@linux.intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=zdai@linux.vnet.ibm.com \
--cc=zdai@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).