[PATCH 0/2] net: atlantic: make some symbol & function static

[PATCH 0/2] net: atlantic: make some symbol & function static

[zhengbin]

zhengbin (2):
  net: atlantic: make symbol 'aq_pm_ops' static
  net: atlantic: make function
    'aq_ethtool_get_priv_flags','aq_ethtool_set_priv_flags' static

 drivers/net/ethernet/aquantia/atlantic/aq_ethtool.c  | 4 ++--
 drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

--
2.7.4

[PATCH 1/2] net: atlantic: make symbol 'aq_pm_ops' static

[zhengbin]

Fix sparse warnings:

drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c:426:25: warning: symbol 'aq_pm_ops' was not declared. Should it be static?

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
 drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c b/drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c
index a161026..2bb3296 100644
--- a/drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c
+++ b/drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c
@@ -423,7 +423,7 @@ static int aq_pm_resume_restore(struct device *dev)
 	return atl_resume_common(dev, true);
 }

-const struct dev_pm_ops aq_pm_ops = {
+static const struct dev_pm_ops aq_pm_ops = {
 	.suspend = aq_pm_suspend_poweroff,
 	.poweroff = aq_pm_suspend_poweroff,
 	.freeze = aq_pm_freeze,
--
2.7.4

[PATCH 2/2] net: atlantic: make function 'aq_ethtool_get_priv_flags','aq_ethtool_set_priv_flags' static

[zhengbin]

Fix sparse warnings:

drivers/net/ethernet/aquantia/atlantic/aq_ethtool.c:706:5: warning: symbol 'aq_ethtool_get_priv_flags' was not declared. Should it be static?
drivers/net/ethernet/aquantia/atlantic/aq_ethtool.c:713:5: warning: symbol 'aq_ethtool_set_priv_flags' was not declared. Should it be static?

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
 drivers/net/ethernet/aquantia/atlantic/aq_ethtool.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_ethtool.c b/drivers/net/ethernet/aquantia/atlantic/aq_ethtool.c
index 6353a5c..a1f99be 100644
--- a/drivers/net/ethernet/aquantia/atlantic/aq_ethtool.c
+++ b/drivers/net/ethernet/aquantia/atlantic/aq_ethtool.c
@@ -703,14 +703,14 @@ static void aq_set_msg_level(struct net_device *ndev, u32 data)
 	aq_nic->msg_enable = data;
 }

-u32 aq_ethtool_get_priv_flags(struct net_device *ndev)
+static u32 aq_ethtool_get_priv_flags(struct net_device *ndev)
 {
 	struct aq_nic_s *aq_nic = netdev_priv(ndev);

 	return aq_nic->aq_nic_cfg.priv_flags;
 }

-int aq_ethtool_set_priv_flags(struct net_device *ndev, u32 flags)
+static int aq_ethtool_set_priv_flags(struct net_device *ndev, u32 flags)
 {
 	struct aq_nic_s *aq_nic = netdev_priv(ndev);
 	struct aq_nic_cfg_s *cfg;
--
2.7.4

Re: [PATCH 0/2] net: atlantic: make some symbol & function static

[David Miller]

You need to start properly marking your Subject lines with the target
tree your changes are indended to go into.

In this case, the code you are patching only exists in "net-next".

How in the world is a maintainer supposed to know this when reading
your changes?  You don't even bother providing Fixes: tags which
mark the commit that introduced the code being marked static either.