* [PATCH net-next v2] cxgb4: make function 'cxgb4_mqprio_free_hw_resources' static
@ 2019-11-12 7:08 zhengbin
2019-11-12 18:56 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: zhengbin @ 2019-11-12 7:08 UTC (permalink / raw)
To: vishal, davem, netdev; +Cc: zhengbin13
Fix sparse warnings:
drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_mqprio.c:242:6: warning: symbol 'cxgb4_mqprio_free_hw_resources' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: 2d0cb84dd973 ("cxgb4: add ETHOFLD hardware queue support")
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
v1->v2: add Fixes tag
drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_mqprio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_mqprio.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_mqprio.c
index 143cb1f..3880784 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_mqprio.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_mqprio.c
@@ -239,7 +239,7 @@ static int cxgb4_mqprio_alloc_hw_resources(struct net_device *dev)
return ret;
}
-void cxgb4_mqprio_free_hw_resources(struct net_device *dev)
+static void cxgb4_mqprio_free_hw_resources(struct net_device *dev)
{
struct port_info *pi = netdev2pinfo(dev);
struct adapter *adap = netdev2adap(dev);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next v2] cxgb4: make function 'cxgb4_mqprio_free_hw_resources' static
2019-11-12 7:08 [PATCH net-next v2] cxgb4: make function 'cxgb4_mqprio_free_hw_resources' static zhengbin
@ 2019-11-12 18:56 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-11-12 18:56 UTC (permalink / raw)
To: zhengbin13; +Cc: vishal, netdev
From: zhengbin <zhengbin13@huawei.com>
Date: Tue, 12 Nov 2019 15:08:40 +0800
> Fix sparse warnings:
>
> drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_mqprio.c:242:6: warning: symbol 'cxgb4_mqprio_free_hw_resources' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 2d0cb84dd973 ("cxgb4: add ETHOFLD hardware queue support")
> Signed-off-by: zhengbin <zhengbin13@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-12 18:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-12 7:08 [PATCH net-next v2] cxgb4: make function 'cxgb4_mqprio_free_hw_resources' static zhengbin
2019-11-12 18:56 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).