* [PATCH net 0/5] bnxt_en: Bug fixes.
@ 2020-03-22 20:40 Michael Chan
2020-03-22 20:40 ` [PATCH net 1/5] bnxt_en: Fix Priority Bytes and Packets counters in ethtool -S Michael Chan
` (6 more replies)
0 siblings, 7 replies; 26+ messages in thread
From: Michael Chan @ 2020-03-22 20:40 UTC (permalink / raw)
To: davem; +Cc: netdev
5 bug fix patches covering an indexing bug for priority counters, memory
leak when retrieving DCB ETS settings, error path return code, proper
disabling of PCI before freeing context memory, and proper ring accounting
in error path.
Please also apply these to -stable. Thanks.
Edwin Peer (1):
bnxt_en: fix memory leaks in bnxt_dcbnl_ieee_getets()
Michael Chan (3):
bnxt_en: Fix Priority Bytes and Packets counters in ethtool -S.
bnxt_en: Return error if bnxt_alloc_ctx_mem() fails.
bnxt_en: Free context memory after disabling PCI in probe error path.
Vasundhara Volam (1):
bnxt_en: Reset rings if ring reservation fails during open()
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 28 ++++++++++++++++-------
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 2 +-
drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c | 15 ++++++++----
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 8 +++----
4 files changed, 35 insertions(+), 18 deletions(-)
--
2.5.1
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH net 1/5] bnxt_en: Fix Priority Bytes and Packets counters in ethtool -S.
2020-03-22 20:40 [PATCH net 0/5] bnxt_en: Bug fixes Michael Chan
@ 2020-03-22 20:40 ` Michael Chan
2020-03-22 20:40 ` [PATCH net 2/5] bnxt_en: fix memory leaks in bnxt_dcbnl_ieee_getets() Michael Chan
` (5 subsequent siblings)
6 siblings, 0 replies; 26+ messages in thread
From: Michael Chan @ 2020-03-22 20:40 UTC (permalink / raw)
To: davem; +Cc: netdev
There is an indexing bug in determining these ethtool priority
counters. Instead of using the queue ID to index, we need to
normalize by modulo 10 to get the index. This index is then used
to obtain the proper CoS queue counter. Rename bp->pri2cos to
bp->pri2cos_idx to make this more clear.
Fixes: e37fed790335 ("bnxt_en: Add ethtool -S priority counters.")
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 10 +++++++++-
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 2 +-
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 8 ++++----
3 files changed, 14 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index c5c8eff..b66ee1d 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -7406,14 +7406,22 @@ static int bnxt_hwrm_port_qstats_ext(struct bnxt *bp)
pri2cos = &resp2->pri0_cos_queue_id;
for (i = 0; i < 8; i++) {
u8 queue_id = pri2cos[i];
+ u8 queue_idx;
+ /* Per port queue IDs start from 0, 10, 20, etc */
+ queue_idx = queue_id % 10;
+ if (queue_idx > BNXT_MAX_QUEUE) {
+ bp->pri2cos_valid = false;
+ goto qstats_done;
+ }
for (j = 0; j < bp->max_q; j++) {
if (bp->q_ids[j] == queue_id)
- bp->pri2cos[i] = j;
+ bp->pri2cos_idx[i] = queue_idx;
}
}
bp->pri2cos_valid = 1;
}
+qstats_done:
mutex_unlock(&bp->hwrm_cmd_lock);
return rc;
}
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.h b/drivers/net/ethernet/broadcom/bnxt/bnxt.h
index cabef0b..63b1706 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.h
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.h
@@ -1716,7 +1716,7 @@ struct bnxt {
u16 fw_rx_stats_ext_size;
u16 fw_tx_stats_ext_size;
u16 hw_ring_stats_size;
- u8 pri2cos[8];
+ u8 pri2cos_idx[8];
u8 pri2cos_valid;
u16 hwrm_max_req_len;
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
index 1f67e67..3f8a1de 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
@@ -589,25 +589,25 @@ static void bnxt_get_ethtool_stats(struct net_device *dev,
if (bp->pri2cos_valid) {
for (i = 0; i < 8; i++, j++) {
long n = bnxt_rx_bytes_pri_arr[i].base_off +
- bp->pri2cos[i];
+ bp->pri2cos_idx[i];
buf[j] = le64_to_cpu(*(rx_port_stats_ext + n));
}
for (i = 0; i < 8; i++, j++) {
long n = bnxt_rx_pkts_pri_arr[i].base_off +
- bp->pri2cos[i];
+ bp->pri2cos_idx[i];
buf[j] = le64_to_cpu(*(rx_port_stats_ext + n));
}
for (i = 0; i < 8; i++, j++) {
long n = bnxt_tx_bytes_pri_arr[i].base_off +
- bp->pri2cos[i];
+ bp->pri2cos_idx[i];
buf[j] = le64_to_cpu(*(tx_port_stats_ext + n));
}
for (i = 0; i < 8; i++, j++) {
long n = bnxt_tx_pkts_pri_arr[i].base_off +
- bp->pri2cos[i];
+ bp->pri2cos_idx[i];
buf[j] = le64_to_cpu(*(tx_port_stats_ext + n));
}
--
2.5.1
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH net 2/5] bnxt_en: fix memory leaks in bnxt_dcbnl_ieee_getets()
2020-03-22 20:40 [PATCH net 0/5] bnxt_en: Bug fixes Michael Chan
2020-03-22 20:40 ` [PATCH net 1/5] bnxt_en: Fix Priority Bytes and Packets counters in ethtool -S Michael Chan
@ 2020-03-22 20:40 ` Michael Chan
2020-03-22 20:40 ` [PATCH net 3/5] bnxt_en: Return error if bnxt_alloc_ctx_mem() fails Michael Chan
` (4 subsequent siblings)
6 siblings, 0 replies; 26+ messages in thread
From: Michael Chan @ 2020-03-22 20:40 UTC (permalink / raw)
To: davem; +Cc: netdev
From: Edwin Peer <edwin.peer@broadcom.com>
The allocated ieee_ets structure goes out of scope without being freed,
leaking memory. Appropriate result codes should be returned so that
callers do not rely on invalid data passed by reference.
Also cache the ETS config retrieved from the device so that it doesn't
need to be freed. The balance of the code was clearly written with the
intent of having the results of querying the hardware cached in the
device structure. The commensurate store was evidently missed though.
Fixes: 7df4ae9fe855 ("bnxt_en: Implement DCBNL to support host-based DCBX.")
Signed-off-by: Edwin Peer <edwin.peer@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
---
drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c | 15 ++++++++++-----
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c
index fb6f30d..b1511bc 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c
@@ -479,24 +479,26 @@ static int bnxt_dcbnl_ieee_getets(struct net_device *dev, struct ieee_ets *ets)
{
struct bnxt *bp = netdev_priv(dev);
struct ieee_ets *my_ets = bp->ieee_ets;
+ int rc;
ets->ets_cap = bp->max_tc;
if (!my_ets) {
- int rc;
-
if (bp->dcbx_cap & DCB_CAP_DCBX_HOST)
return 0;
my_ets = kzalloc(sizeof(*my_ets), GFP_KERNEL);
if (!my_ets)
- return 0;
+ return -ENOMEM;
rc = bnxt_hwrm_queue_cos2bw_qcfg(bp, my_ets);
if (rc)
- return 0;
+ goto error;
rc = bnxt_hwrm_queue_pri2cos_qcfg(bp, my_ets);
if (rc)
- return 0;
+ goto error;
+
+ /* cache result */
+ bp->ieee_ets = my_ets;
}
ets->cbs = my_ets->cbs;
@@ -505,6 +507,9 @@ static int bnxt_dcbnl_ieee_getets(struct net_device *dev, struct ieee_ets *ets)
memcpy(ets->tc_tsa, my_ets->tc_tsa, sizeof(ets->tc_tsa));
memcpy(ets->prio_tc, my_ets->prio_tc, sizeof(ets->prio_tc));
return 0;
+error:
+ kfree(my_ets);
+ return rc;
}
static int bnxt_dcbnl_ieee_setets(struct net_device *dev, struct ieee_ets *ets)
--
2.5.1
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH net 3/5] bnxt_en: Return error if bnxt_alloc_ctx_mem() fails.
2020-03-22 20:40 [PATCH net 0/5] bnxt_en: Bug fixes Michael Chan
2020-03-22 20:40 ` [PATCH net 1/5] bnxt_en: Fix Priority Bytes and Packets counters in ethtool -S Michael Chan
2020-03-22 20:40 ` [PATCH net 2/5] bnxt_en: fix memory leaks in bnxt_dcbnl_ieee_getets() Michael Chan
@ 2020-03-22 20:40 ` Michael Chan
2020-03-22 20:40 ` [PATCH net 4/5] bnxt_en: Free context memory after disabling PCI in probe error path Michael Chan
` (3 subsequent siblings)
6 siblings, 0 replies; 26+ messages in thread
From: Michael Chan @ 2020-03-22 20:40 UTC (permalink / raw)
To: davem; +Cc: netdev
The current code ignores the return value from
bnxt_hwrm_func_backing_store_cfg(), causing the driver to proceed in
the init path even when this vital firmware call has failed. Fix it
by propagating the error code to the caller.
Fixes: 1b9394e5a2ad ("bnxt_en: Configure context memory on new devices.")
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index b66ee1d..0628a6a 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -6880,12 +6880,12 @@ static int bnxt_alloc_ctx_mem(struct bnxt *bp)
}
ena |= FUNC_BACKING_STORE_CFG_REQ_DFLT_ENABLES;
rc = bnxt_hwrm_func_backing_store_cfg(bp, ena);
- if (rc)
+ if (rc) {
netdev_err(bp->dev, "Failed configuring context mem, rc = %d.\n",
rc);
- else
- ctx->flags |= BNXT_CTX_FLAG_INITED;
-
+ return rc;
+ }
+ ctx->flags |= BNXT_CTX_FLAG_INITED;
return 0;
}
--
2.5.1
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH net 4/5] bnxt_en: Free context memory after disabling PCI in probe error path.
2020-03-22 20:40 [PATCH net 0/5] bnxt_en: Bug fixes Michael Chan
` (2 preceding siblings ...)
2020-03-22 20:40 ` [PATCH net 3/5] bnxt_en: Return error if bnxt_alloc_ctx_mem() fails Michael Chan
@ 2020-03-22 20:40 ` Michael Chan
2020-03-22 20:40 ` [PATCH net 5/5] bnxt_en: Reset rings if ring reservation fails during open() Michael Chan
` (2 subsequent siblings)
6 siblings, 0 replies; 26+ messages in thread
From: Michael Chan @ 2020-03-22 20:40 UTC (permalink / raw)
To: davem; +Cc: netdev
Other shutdown code paths will always disable PCI first to shutdown DMA
before freeing context memory. Do the same sequence in the error path
of probe to be safe and consistent.
Fixes: c20dc142dd7b ("bnxt_en: Disable bus master during PCI shutdown and driver unload.")
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index 0628a6a..95f4c02 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -11970,12 +11970,12 @@ static int bnxt_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
bnxt_hwrm_func_drv_unrgtr(bp);
bnxt_free_hwrm_short_cmd_req(bp);
bnxt_free_hwrm_resources(bp);
- bnxt_free_ctx_mem(bp);
- kfree(bp->ctx);
- bp->ctx = NULL;
kfree(bp->fw_health);
bp->fw_health = NULL;
bnxt_cleanup_pci(bp);
+ bnxt_free_ctx_mem(bp);
+ kfree(bp->ctx);
+ bp->ctx = NULL;
init_err_free:
free_netdev(dev);
--
2.5.1
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH net 5/5] bnxt_en: Reset rings if ring reservation fails during open()
2020-03-22 20:40 [PATCH net 0/5] bnxt_en: Bug fixes Michael Chan
` (3 preceding siblings ...)
2020-03-22 20:40 ` [PATCH net 4/5] bnxt_en: Free context memory after disabling PCI in probe error path Michael Chan
@ 2020-03-22 20:40 ` Michael Chan
2020-03-23 17:27 ` [PATCH net 0/5] bnxt_en: Bug fixes Jakub Kicinski
2020-03-24 4:43 ` David Miller
6 siblings, 0 replies; 26+ messages in thread
From: Michael Chan @ 2020-03-22 20:40 UTC (permalink / raw)
To: davem; +Cc: netdev
From: Vasundhara Volam <vasundhara-v.volam@broadcom.com>
If ring counts are not reset when ring reservation fails,
bnxt_init_dflt_ring_mode() will not be called again to reinitialise
IRQs when open() is called and results in system crash as napi will
also be not initialised. This patch fixes it by resetting the ring
counts.
Fixes: 47558acd56a7 ("bnxt_en: Reserve rings at driver open if none was reserved at probe time.")
Signed-off-by: Vasundhara Volam <vasundhara-v.volam@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index 95f4c02..d28b406 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -11677,6 +11677,10 @@ static int bnxt_set_dflt_rings(struct bnxt *bp, bool sh)
bp->rx_nr_rings++;
bp->cp_nr_rings++;
}
+ if (rc) {
+ bp->tx_nr_rings = 0;
+ bp->rx_nr_rings = 0;
+ }
return rc;
}
--
2.5.1
^ permalink raw reply related [flat|nested] 26+ messages in thread
* Re: [PATCH net 0/5] bnxt_en: Bug fixes.
2020-03-22 20:40 [PATCH net 0/5] bnxt_en: Bug fixes Michael Chan
` (4 preceding siblings ...)
2020-03-22 20:40 ` [PATCH net 5/5] bnxt_en: Reset rings if ring reservation fails during open() Michael Chan
@ 2020-03-23 17:27 ` Jakub Kicinski
2020-03-24 4:43 ` David Miller
6 siblings, 0 replies; 26+ messages in thread
From: Jakub Kicinski @ 2020-03-23 17:27 UTC (permalink / raw)
To: Michael Chan; +Cc: davem, netdev
On Sun, 22 Mar 2020 16:40:00 -0400 Michael Chan wrote:
> 5 bug fix patches covering an indexing bug for priority counters, memory
> leak when retrieving DCB ETS settings, error path return code, proper
> disabling of PCI before freeing context memory, and proper ring accounting
> in error path.
>
> Please also apply these to -stable. Thanks.
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH net 0/5] bnxt_en: Bug fixes.
2020-03-22 20:40 [PATCH net 0/5] bnxt_en: Bug fixes Michael Chan
` (5 preceding siblings ...)
2020-03-23 17:27 ` [PATCH net 0/5] bnxt_en: Bug fixes Jakub Kicinski
@ 2020-03-24 4:43 ` David Miller
6 siblings, 0 replies; 26+ messages in thread
From: David Miller @ 2020-03-24 4:43 UTC (permalink / raw)
To: michael.chan; +Cc: netdev
From: Michael Chan <michael.chan@broadcom.com>
Date: Sun, 22 Mar 2020 16:40:00 -0400
> 5 bug fix patches covering an indexing bug for priority counters, memory
> leak when retrieving DCB ETS settings, error path return code, proper
> disabling of PCI before freeing context memory, and proper ring accounting
> in error path.
Series applied.
> Please also apply these to -stable. Thanks.
Queued up, thanks.
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH net 0/5] bnxt_en: Bug fixes
2024-01-17 23:45 Michael Chan
@ 2024-01-19 2:10 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 26+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-01-19 2:10 UTC (permalink / raw)
To: Michael Chan; +Cc: davem, netdev, edumazet, kuba, pabeni, andrew.gospodarek
Hello:
This series was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:
On Wed, 17 Jan 2024 15:45:10 -0800 you wrote:
> This series contains 5 miscellaneous fixes. The fixes include adding
> delay for FLR, buffer memory leak, RSS table size calculation,
> ethtool self test kernel warning, and mqprio crash.
>
> Michael Chan (5):
> bnxt_en: Wait for FLR to complete during probe
> bnxt_en: Fix memory leak in bnxt_hwrm_get_rings()
> bnxt_en: Fix RSS table entries calculation for P5_PLUS chips
> bnxt_en: Prevent kernel warning when running offline self test
> bnxt_en: Fix possible crash after creating sw mqprio TCs
>
> [...]
Here is the summary with links:
- [net,1/5] bnxt_en: Wait for FLR to complete during probe
https://git.kernel.org/netdev/net/c/e6602b3c07d8
- [net,2/5] bnxt_en: Fix memory leak in bnxt_hwrm_get_rings()
https://git.kernel.org/netdev/net/c/a261fd41f44f
- [net,3/5] bnxt_en: Fix RSS table entries calculation for P5_PLUS chips
https://git.kernel.org/netdev/net/c/602801d18667
- [net,4/5] bnxt_en: Prevent kernel warning when running offline self test
https://git.kernel.org/netdev/net/c/7d544a01450e
- [net,5/5] bnxt_en: Fix possible crash after creating sw mqprio TCs
https://git.kernel.org/netdev/net/c/bb89cf26f515
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH net 0/5] bnxt_en: Bug fixes
@ 2024-01-17 23:45 Michael Chan
2024-01-19 2:10 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 26+ messages in thread
From: Michael Chan @ 2024-01-17 23:45 UTC (permalink / raw)
To: davem; +Cc: netdev, edumazet, kuba, pabeni, andrew.gospodarek
[-- Attachment #1: Type: text/plain, Size: 850 bytes --]
This series contains 5 miscellaneous fixes. The fixes include adding
delay for FLR, buffer memory leak, RSS table size calculation,
ethtool self test kernel warning, and mqprio crash.
Michael Chan (5):
bnxt_en: Wait for FLR to complete during probe
bnxt_en: Fix memory leak in bnxt_hwrm_get_rings()
bnxt_en: Fix RSS table entries calculation for P5_PLUS chips
bnxt_en: Prevent kernel warning when running offline self test
bnxt_en: Fix possible crash after creating sw mqprio TCs
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 49 +++++++++++++------
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 +
drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c | 2 +-
.../net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 7 +--
drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c | 2 +-
5 files changed, 42 insertions(+), 19 deletions(-)
--
2.30.1
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH net 0/5] bnxt_en: Bug fixes
2022-12-27 3:19 Michael Chan
@ 2022-12-28 10:20 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 26+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-12-28 10:20 UTC (permalink / raw)
To: Michael Chan; +Cc: davem, netdev, kuba, edumazet, pabeni, bpf, gospo
Hello:
This series was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:
On Mon, 26 Dec 2022 22:19:35 -0500 you wrote:
> This series fixes a devlink bug and several XDP related bugs. The
> devlink bug causes a kernel crash on VF devices. The XDP driver
> patches fix and clean up the RX XDP path and re-enable header-data
> split that was disabled by mistake when adding the XDP multi-buffer
> support.
>
> Michael Chan (4):
> bnxt_en: Simplify bnxt_xdp_buff_init()
> bnxt_en: Fix XDP RX path
> bnxt_en: Fix first buffer size calculations for XDP multi-buffer
> bnxt_en: Fix HDS and jumbo thresholds for RX packets
>
> [...]
Here is the summary with links:
- [net,1/5] bnxt_en: fix devlink port registration to netdev
https://git.kernel.org/netdev/net/c/0020ae2a4aa8
- [net,2/5] bnxt_en: Simplify bnxt_xdp_buff_init()
https://git.kernel.org/netdev/net/c/bbfc17e50ba2
- [net,3/5] bnxt_en: Fix XDP RX path
https://git.kernel.org/netdev/net/c/9b3e607871ea
- [net,4/5] bnxt_en: Fix first buffer size calculations for XDP multi-buffer
https://git.kernel.org/netdev/net/c/1abeacc1979f
- [net,5/5] bnxt_en: Fix HDS and jumbo thresholds for RX packets
https://git.kernel.org/netdev/net/c/a056ebcc30e2
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH net 0/5] bnxt_en: Bug fixes
@ 2022-12-27 3:19 Michael Chan
2022-12-28 10:20 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 26+ messages in thread
From: Michael Chan @ 2022-12-27 3:19 UTC (permalink / raw)
To: davem; +Cc: netdev, kuba, edumazet, pabeni, bpf, gospo
[-- Attachment #1: Type: text/plain, Size: 881 bytes --]
This series fixes a devlink bug and several XDP related bugs. The
devlink bug causes a kernel crash on VF devices. The XDP driver
patches fix and clean up the RX XDP path and re-enable header-data
split that was disabled by mistake when adding the XDP multi-buffer
support.
Michael Chan (4):
bnxt_en: Simplify bnxt_xdp_buff_init()
bnxt_en: Fix XDP RX path
bnxt_en: Fix first buffer size calculations for XDP multi-buffer
bnxt_en: Fix HDS and jumbo thresholds for RX packets
Vikas Gupta (1):
bnxt_en: fix devlink port registration to netdev
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 27 +++++++++++--------
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 15 ++++++++---
drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c | 20 +++++++-------
drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.h | 6 ++---
4 files changed, 39 insertions(+), 29 deletions(-)
--
2.18.1
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH net 0/5] bnxt_en: Bug fixes
2021-09-05 18:10 Michael Chan
@ 2021-09-05 19:50 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 26+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-09-05 19:50 UTC (permalink / raw)
To: Michael Chan; +Cc: davem, netdev, kuba, edwin.peer, gospo
Hello:
This series was applied to netdev/net.git (refs/heads/master):
On Sun, 5 Sep 2021 14:10:54 -0400 you wrote:
> This series includes 3 fixes related to devlink firmware and chip
> versions. The other 2 patches fix a UDP tunneling issue and an
> error recovery issue.
>
> Edwin Peer (2):
> bnxt_en: fix stored FW_PSID version masks
> bnxt_en: fix read of stored FW_PSID version on P5 devices
>
> [...]
Here is the summary with links:
- [net,1/5] bnxt_en: fix stored FW_PSID version masks
https://git.kernel.org/netdev/net/c/1656db67233e
- [net,2/5] bnxt_en: fix read of stored FW_PSID version on P5 devices
https://git.kernel.org/netdev/net/c/beb55fcf950f
- [net,3/5] bnxt_en: Fix asic.rev in devlink dev info command
https://git.kernel.org/netdev/net/c/6fdab8a3ade2
- [net,4/5] bnxt_en: Fix UDP tunnel logic
https://git.kernel.org/netdev/net/c/7ae9dc356f24
- [net,5/5] bnxt_en: Fix possible unintended driver initiated error recovery
https://git.kernel.org/netdev/net/c/1b2b91831983
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH net 0/5] bnxt_en: Bug fixes
@ 2021-09-05 18:10 Michael Chan
2021-09-05 19:50 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 26+ messages in thread
From: Michael Chan @ 2021-09-05 18:10 UTC (permalink / raw)
To: davem; +Cc: netdev, kuba, edwin.peer, gospo
[-- Attachment #1: Type: text/plain, Size: 707 bytes --]
This series includes 3 fixes related to devlink firmware and chip
versions. The other 2 patches fix a UDP tunneling issue and an
error recovery issue.
Edwin Peer (2):
bnxt_en: fix stored FW_PSID version masks
bnxt_en: fix read of stored FW_PSID version on P5 devices
Michael Chan (3):
bnxt_en: Fix asic.rev in devlink dev info command
bnxt_en: Fix UDP tunnel logic
bnxt_en: Fix possible unintended driver initiated error recovery
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 53 ++++++++++++-------
.../net/ethernet/broadcom/bnxt/bnxt_devlink.c | 51 ++++++++++++------
.../net/ethernet/broadcom/bnxt/bnxt_devlink.h | 4 +-
3 files changed, 72 insertions(+), 36 deletions(-)
--
2.18.1
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH net 0/5] bnxt_en: Bug fixes.
2020-10-26 4:18 Michael Chan
@ 2020-10-27 1:36 ` Jakub Kicinski
0 siblings, 0 replies; 26+ messages in thread
From: Jakub Kicinski @ 2020-10-27 1:36 UTC (permalink / raw)
To: Michael Chan; +Cc: netdev, gospo
On Mon, 26 Oct 2020 00:18:16 -0400 Michael Chan wrote:
> These 5 bug fixes are all related to the firmware reset or AER recovery.
> 2 patches fix the cleanup logic for the workqueue used to handle firmware
> reset and recovery. 1 patch ensures that the chip will have the proper
> BAR addresses latched after fatal AER recovery. 1 patch fixes the
> open path to check for firmware reset abort error. The last one
> sends the fw reset command unconditionally to fix the AER reset logic.
>
> Please queue these for -stable as well. Thanks.
Applied, thanks!
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH net 0/5] bnxt_en: Bug fixes.
@ 2020-10-26 4:18 Michael Chan
2020-10-27 1:36 ` Jakub Kicinski
0 siblings, 1 reply; 26+ messages in thread
From: Michael Chan @ 2020-10-26 4:18 UTC (permalink / raw)
To: kuba; +Cc: netdev, gospo
[-- Attachment #1: Type: text/plain, Size: 1006 bytes --]
These 5 bug fixes are all related to the firmware reset or AER recovery.
2 patches fix the cleanup logic for the workqueue used to handle firmware
reset and recovery. 1 patch ensures that the chip will have the proper
BAR addresses latched after fatal AER recovery. 1 patch fixes the
open path to check for firmware reset abort error. The last one
sends the fw reset command unconditionally to fix the AER reset logic.
Please queue these for -stable as well. Thanks.
Michael Chan (1):
bnxt_en: Check abort error state in bnxt_open_nic().
Vasundhara Volam (4):
bnxt_en: Fix regression in workqueue cleanup logic in
bnxt_remove_one().
bnxt_en: Invoke cancel_delayed_work_sync() for PFs also.
bnxt_en: Re-write PCI BARs after PCI fatal error.
bnxt_en: Send HWRM_FUNC_RESET fw command unconditionally.
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 49 ++++++++++++++---------
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 +
2 files changed, 32 insertions(+), 18 deletions(-)
--
2.18.1
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4166 bytes --]
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH net 0/5] bnxt_en: Bug fixes.
2020-04-26 20:24 Michael Chan
@ 2020-04-27 18:45 ` David Miller
0 siblings, 0 replies; 26+ messages in thread
From: David Miller @ 2020-04-27 18:45 UTC (permalink / raw)
To: michael.chan; +Cc: netdev
From: Michael Chan <michael.chan@broadcom.com>
Date: Sun, 26 Apr 2020 16:24:37 -0400
> A collection of 5 miscellaneous bug fixes covering VF anti-spoof setup
> issues, devlink MSIX max value, AER, context memory allocation error
> path, and VLAN acceleration logic.
>
> Please queue for -stable. Thanks.
Applied and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH net 0/5] bnxt_en: Bug fixes.
@ 2020-04-26 20:24 Michael Chan
2020-04-27 18:45 ` David Miller
0 siblings, 1 reply; 26+ messages in thread
From: Michael Chan @ 2020-04-26 20:24 UTC (permalink / raw)
To: davem; +Cc: netdev
A collection of 5 miscellaneous bug fixes covering VF anti-spoof setup
issues, devlink MSIX max value, AER, context memory allocation error
path, and VLAN acceleration logic.
Please queue for -stable. Thanks.
Michael Chan (4):
bnxt_en: Fix VF anti-spoof filter setup.
bnxt_en: Improve AER slot reset.
bnxt_en: Return error when allocating zero size context memory.
bnxt_en: Fix VLAN acceleration handling in bnxt_fix_features().
Vasundhara Volam (1):
bnxt_en: Reduce BNXT_MSIX_VEC_MAX value to supported CQs per PF.
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 20 +++++++++++++-------
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 -
drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.h | 2 +-
drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c | 10 ++--------
4 files changed, 16 insertions(+), 17 deletions(-)
--
2.5.1
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH net 0/5] bnxt_en: Bug fixes.
2019-10-21 5:34 Michael Chan
@ 2019-10-22 20:29 ` Jakub Kicinski
0 siblings, 0 replies; 26+ messages in thread
From: Jakub Kicinski @ 2019-10-22 20:29 UTC (permalink / raw)
To: Michael Chan; +Cc: davem, netdev, vasundhara-v.volam
On Mon, 21 Oct 2019 01:34:24 -0400, Michael Chan wrote:
> Devlink and error recovery bug fix patches. Most of the work is by
> Vasundhara Volam.
Thanks, applied.
> Please queue patch 1 and 2 for -stable also. Thanks.
FWIW these will likely only reach 5.3 since it looks like the bug dates
to 5.1 but 5.1 and 5.2 branches of stable are already EOL.
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH net 0/5] bnxt_en: Bug fixes.
@ 2019-10-21 5:34 Michael Chan
2019-10-22 20:29 ` Jakub Kicinski
0 siblings, 1 reply; 26+ messages in thread
From: Michael Chan @ 2019-10-21 5:34 UTC (permalink / raw)
To: davem; +Cc: netdev, vasundhara-v.volam
Devlink and error recovery bug fix patches. Most of the work is by
Vasundhara Volam. Please queue patch 1 and 2 for -stable also. Thanks.
Michael Chan (1):
bnxt_en: Fix devlink NVRAM related byte order related issues.
Vasundhara Volam (4):
bnxt_en: Fix the size of devlink MSIX parameters.
bnxt_en: Adjust the time to wait before polling firmware readiness.
bnxt_en: Minor formatting changes in FW devlink_health_reporter
bnxt_en: Avoid disabling pci device in bnxt_remove_one() for already
disabled device.
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 10 +-
drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 112 +++++++++++++---------
drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.h | 3 +-
3 files changed, 73 insertions(+), 52 deletions(-)
--
2.5.1
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH net 0/5] bnxt_en: Bug fixes.
2019-06-29 15:16 Michael Chan
@ 2019-06-30 23:01 ` David Miller
0 siblings, 0 replies; 26+ messages in thread
From: David Miller @ 2019-06-30 23:01 UTC (permalink / raw)
To: michael.chan; +Cc: netdev
From: Michael Chan <michael.chan@broadcom.com>
Date: Sat, 29 Jun 2019 11:16:43 -0400
> Miscellaneous bug fix patches, including two resource handling fixes for
> the RDMA driver, a PCI shutdown patch to add pci_disable_device(), a patch
> to fix ethtool selftest crash, and the last one suppresses an unnecessry
> error message.
Series applied.
> Please also queue patches 1, 2, and 3 for -stable. Thanks.
Queued up.
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH net 0/5] bnxt_en: Bug fixes.
@ 2019-06-29 15:16 Michael Chan
2019-06-30 23:01 ` David Miller
0 siblings, 1 reply; 26+ messages in thread
From: Michael Chan @ 2019-06-29 15:16 UTC (permalink / raw)
To: davem; +Cc: netdev
Miscellaneous bug fix patches, including two resource handling fixes for
the RDMA driver, a PCI shutdown patch to add pci_disable_device(), a patch
to fix ethtool selftest crash, and the last one suppresses an unnecessry
error message.
Please also queue patches 1, 2, and 3 for -stable. Thanks.
Michael Chan (5):
bnxt_en: Disable bus master during PCI shutdown and driver unload.
bnxt_en: Fix ethtool selftest crash under error conditions.
bnxt_en: Fix statistics context reservation logic for RDMA driver.
bnxt_en: Cap the returned MSIX vectors to the RDMA driver.
bnxt_en: Suppress error messages when querying DSCP DCB capabilities.
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 20 +++++++++++++-------
drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c | 2 +-
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 6 +++---
drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c | 4 +++-
4 files changed, 20 insertions(+), 12 deletions(-)
--
2.5.1
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH net 0/5] bnxt_en: Bug fixes.
2016-02-10 22:33 Michael Chan
@ 2016-02-16 20:51 ` David Miller
0 siblings, 0 replies; 26+ messages in thread
From: David Miller @ 2016-02-16 20:51 UTC (permalink / raw)
To: mchan; +Cc: netdev
From: Michael Chan <mchan@broadcom.com>
Date: Wed, 10 Feb 2016 17:33:45 -0500
> Fixed autoneg logic and some related cleanups, fixed tx push operation,
> and reduced default ring sizes.
Series applied, thanks Michael.
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH net 0/5] bnxt_en: Bug fixes.
@ 2016-02-10 22:33 Michael Chan
2016-02-16 20:51 ` David Miller
0 siblings, 1 reply; 26+ messages in thread
From: Michael Chan @ 2016-02-10 22:33 UTC (permalink / raw)
To: davem; +Cc: netdev
Fixed autoneg logic and some related cleanups, fixed tx push operation,
and reduced default ring sizes.
Michael Chan (5):
bnxt_en: Fix ethtool autoneg logic.
bnxt_en: Cleanup and Fix flow control setup logic
bnxt_en: Remove 20G support and advertise only 40GbaseCR4.
bnxt_en: Fix implementation of tx push operation.
bnxt_en: Reduce default ring sizes.
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 62 ++++++++++++-----------
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 15 ++++--
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 46 +++++------------
3 files changed, 56 insertions(+), 67 deletions(-)
--
1.8.3.1
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH net 0/5] bnxt_en: Bug fixes.
2015-11-05 21:25 Michael Chan
@ 2015-11-05 21:35 ` David Miller
0 siblings, 0 replies; 26+ messages in thread
From: David Miller @ 2015-11-05 21:35 UTC (permalink / raw)
To: mchan; +Cc: netdev
From: Michael Chan <mchan@broadcom.com>
Date: Thu, 5 Nov 2015 16:25:46 -0500
> Miscellaneous small bug fixes.
This looks fine, series applied, thanks.
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH net 0/5] bnxt_en: Bug fixes.
@ 2015-11-05 21:25 Michael Chan
2015-11-05 21:35 ` David Miller
0 siblings, 1 reply; 26+ messages in thread
From: Michael Chan @ 2015-11-05 21:25 UTC (permalink / raw)
To: davem; +Cc: netdev
Miscellaneous small bug fixes.
Michael Chan (5):
bnxt_en: Change sp events definitions to represent bit position.
bnxt_en: Determine tcp/ipv6 RSS hash type correctly.
bnxt_en: map CAG_REG_LEGACY_INT_STATUS_MASK to GRC window #4
bnxt_en: Fix comparison of u16 sw_id against negative value.
bnxt_en: More robust SRIOV cleanup sequence.
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 28 ++++++++++++-----
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 26 +++++++++-------
drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c | 40 +++++++++++++++++--------
3 files changed, 64 insertions(+), 30 deletions(-)
--
1.8.3.1
^ permalink raw reply [flat|nested] 26+ messages in thread
end of thread, other threads:[~2024-01-19 2:10 UTC | newest]
Thread overview: 26+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-22 20:40 [PATCH net 0/5] bnxt_en: Bug fixes Michael Chan
2020-03-22 20:40 ` [PATCH net 1/5] bnxt_en: Fix Priority Bytes and Packets counters in ethtool -S Michael Chan
2020-03-22 20:40 ` [PATCH net 2/5] bnxt_en: fix memory leaks in bnxt_dcbnl_ieee_getets() Michael Chan
2020-03-22 20:40 ` [PATCH net 3/5] bnxt_en: Return error if bnxt_alloc_ctx_mem() fails Michael Chan
2020-03-22 20:40 ` [PATCH net 4/5] bnxt_en: Free context memory after disabling PCI in probe error path Michael Chan
2020-03-22 20:40 ` [PATCH net 5/5] bnxt_en: Reset rings if ring reservation fails during open() Michael Chan
2020-03-23 17:27 ` [PATCH net 0/5] bnxt_en: Bug fixes Jakub Kicinski
2020-03-24 4:43 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2024-01-17 23:45 Michael Chan
2024-01-19 2:10 ` patchwork-bot+netdevbpf
2022-12-27 3:19 Michael Chan
2022-12-28 10:20 ` patchwork-bot+netdevbpf
2021-09-05 18:10 Michael Chan
2021-09-05 19:50 ` patchwork-bot+netdevbpf
2020-10-26 4:18 Michael Chan
2020-10-27 1:36 ` Jakub Kicinski
2020-04-26 20:24 Michael Chan
2020-04-27 18:45 ` David Miller
2019-10-21 5:34 Michael Chan
2019-10-22 20:29 ` Jakub Kicinski
2019-06-29 15:16 Michael Chan
2019-06-30 23:01 ` David Miller
2016-02-10 22:33 Michael Chan
2016-02-16 20:51 ` David Miller
2015-11-05 21:25 Michael Chan
2015-11-05 21:35 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).