netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: fugang.duan@nxp.com
To: andrew@lunn.ch, martin.fuzzey@flowbird.group, davem@davemloft.net
Cc: netdev@vger.kernel.org, robh+dt@kernel.org, shawnguo@kernel.org,
	devicetree@vger.kernel.org, kuba@kernel.org, fugang.duan@nxp.com
Subject: [PATCH net v2 0/4] net: ethernet: fec: move GPR reigster offset and bit into DT
Date: Mon, 25 May 2020 15:09:25 +0800	[thread overview]
Message-ID: <1590390569-4394-1-git-send-email-fugang.duan@nxp.com> (raw)

From: Fugang Duan <fugang.duan@nxp.com>

The commit da722186f654 (net: fec: set GPR bit on suspend by DT configuration) set the GPR reigster offset and bit in driver for wol feature.

It bring trouble to enable wol feature on imx6sx/imx6ul/imx7d platforms that have multiple ethernet instances with different GPR bit for stop mode control. So the patch set is to move GPR reigster offset and bit define into DT, and enable imx6q/imx6dl/imx6sx/imx6ul/imx7d stop mode support.

Currently, below NXP i.MX boards support wol:
- imx6q/imx6dl sabresd
- imx6sx sabreauto
- imx7d sdb

imx6q/imx6dl sarebsd board dts file miss the property "fsl,magic-packet;", so patch#4 is to add the property for stop mode support.


v1 -> v2:
 - driver: switch back to store the quirks bitmask in driver_data
 - dt-bindings: rename 'gpr' property string to 'fsl,stop-mode'
 - imx6/7 dtsi: add imx6sx/imx6ul/imx7d ethernet stop mode property

Thanks Martin and Andrew for the review.


Fugang Duan (4):
  net: ethernet: fec: move GPR register offset and bit into DT
  dt-bindings: fec: update the gpr property
  ARM: dts: imx: add ethernet stop mode property
  ARM: dts: imx6qdl-sabresd: enable fec wake-on-lan

 Documentation/devicetree/bindings/net/fsl-fec.txt |   7 +-
 arch/arm/boot/dts/imx6qdl-sabresd.dtsi            |   1 +
 arch/arm/boot/dts/imx6qdl.dtsi                    |   2 +-
 arch/arm/boot/dts/imx6sx.dtsi                     |   2 +
 arch/arm/boot/dts/imx6ul.dtsi                     |   2 +
 arch/arm/boot/dts/imx7d.dtsi                      |   1 +
 arch/arm/boot/dts/imx7s.dtsi                      |   1 +
 drivers/net/ethernet/freescale/fec_main.c         | 103 +++++++---------------
 8 files changed, 47 insertions(+), 72 deletions(-)

-- 
2.7.4


             reply	other threads:[~2020-05-25  7:14 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-25  7:09 fugang.duan [this message]
2020-05-25  7:09 ` [PATCH net v2 1/4] net: ethernet: fec: move GPR register offset and bit into DT fugang.duan
2020-05-25 10:48   ` Sascha Hauer
2020-05-25 15:38     ` [EXT] " Andy Duan
2020-05-25  7:09 ` [PATCH net v2 2/4] dt-bindings: fec: update the gpr property fugang.duan
2020-05-25  7:09 ` [PATCH net v2 3/4] ARM: dts: imx: add ethernet stop mode property fugang.duan
2020-05-25 13:51   ` Andrew Lunn
2020-05-25 15:39     ` [EXT] " Andy Duan
2020-05-25  7:09 ` [PATCH net v2 4/4] ARM: dts: imx6qdl-sabresd: enable fec wake-on-lan fugang.duan
2020-05-25 13:51   ` Andrew Lunn
2020-05-25 15:40     ` [EXT] " Andy Duan
2020-05-25 13:54 ` [PATCH net v2 0/4] net: ethernet: fec: move GPR reigster offset and bit into DT Andrew Lunn
2020-05-25 15:41   ` [EXT] " Andy Duan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1590390569-4394-1-git-send-email-fugang.duan@nxp.com \
    --to=fugang.duan@nxp.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=kuba@kernel.org \
    --cc=martin.fuzzey@flowbird.group \
    --cc=netdev@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).