[PATCH] qed (qed_int.c) disable "MFW indication via attention" SPAM every 5 minutes

[PATCH] qed (qed_int.c) disable "MFW indication via attention" SPAM every 5 minutes

[Laurence Oberman]

This is likely firmware causing this but its starting to annoy customers.
Change the message level to verbose to prevent the spam.
Note that this seems to only show up with ISCSI enabled on the HBA via the 
qedi driver.

Signed-off-by: Laurence Oberman <loberman@redhat.com>
---
 drivers/net/ethernet/qlogic/qed/qed_int.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/qlogic/qed/qed_int.c b/drivers/net/ethernet/qlogic/qed/qed_int.c
index b7b974f..d853eb9 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_int.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_int.c
@@ -1193,7 +1193,8 @@ static int qed_int_attentions(struct qed_hwfn *p_hwfn)
 			index, attn_bits, attn_acks, asserted_bits,
 			deasserted_bits, p_sb_attn_sw->known_attn);
 	} else if (asserted_bits == 0x100) {
-		DP_INFO(p_hwfn, "MFW indication via attention\n");
+		DP_VERBOSE(p_hwfn, NETIF_MSG_INTR,
+			"MFW indication via attention\n");
 	} else {
 		DP_VERBOSE(p_hwfn, NETIF_MSG_INTR,
 			   "MFW indication [deassertion]\n");
-- 
1.8.3.1

Re: [PATCH] qed (qed_int.c) disable "MFW indication via attention" SPAM every 5 minutes

[David Miller]

From: Laurence Oberman <loberman@redhat.com>
Date: Tue, 14 Jul 2020 09:50:29 -0400

> This is likely firmware causing this but its starting to annoy customers.
> Change the message level to verbose to prevent the spam.
> Note that this seems to only show up with ISCSI enabled on the HBA via the 
> qedi driver.
> 
> Signed-off-by: Laurence Oberman <loberman@redhat.com>

Please... I asked you to look at recent changes to this driver and use
a Subject line consistent with those changes.

And if I do:

	git shortlog v5.6.. -- drivers/net/ethernet/qlogic/qed

I see commit header lines using "qed: " as the subsystem prefix.

So I have to ask, where in recent changes to this driver did you see
examples of people explicitly mentioning "(qed_int.c)" or other file
names?  Where did you see other changes not having a colon character
separating the subsystem prefix from the one-line description?

Please, format this properly:

	[PATCH net] qed: Disable "MFW indictation via attention" SPAM every 5 minutes

For the future, just look at what other developers are doing rather than
inventing your own formatting.

Thank you.